Close button is still displayed in Telemetry notification when selecting Privacy Policy

RESOLVED FIXED in Firefox 13

Status

()

Firefox
General
RESOLVED FIXED
6 years ago
6 years ago

People

(Reporter: virgil, Assigned: froydnj)

Tracking

Trunk
Firefox 13
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment, 2 obsolete attachments)

(Reporter)

Description

6 years ago
Mozilla/5.0 (X11; Linux x86_64; rv:11.0a1) Gecko/20111208 Firefox/11.0a1

The Telemetry notification still displays the close (x) button when selecting Learn more (which redirects to Privacy Policy) after receiving the two-state notification.
Bug 697860 states that the close button shouldn't be displayed anymore for the Telemetry Notification.

STR:

1. Start Firefox with a clean profile
2. Restart Firefox to dismiss the "Know your rights" notification and receive the two state Telemetry notification
3. Select Learn more. (This will redirect to the Privacy Policy)

The Telemetry close button is still displayed here. The button should be hidden as specified in bug 697860.
(Reporter)

Updated

6 years ago
Depends on: 697860
Probably not terrible to display the close button here as long as clicking close != a click on No for Telemetry.

Comment 2

6 years ago
Created attachment 581852 [details] [diff] [review]
this should fix it

Comment 3

6 years ago
Vladan, can you wrap this up?
Assignee: nobody → vdjeric
(Assignee)

Comment 4

6 years ago
This will make bug 725407 somewhat less ugly too.
Assignee: vdjeric → nfroyd
Status: NEW → ASSIGNED
(Assignee)

Comment 5

6 years ago
Created attachment 600411 [details] [diff] [review]
patch

Revised patch.  I gave the function a number of parameters so that it's useful for bug 725407.
Attachment #581852 - Attachment is obsolete: true
Attachment #600411 - Flags: review?(dietrich)
Comment on attachment 600411 [details] [diff] [review]
patch

Review of attachment 600411 [details] [diff] [review]:
-----------------------------------------------------------------

a couple of style nits, r=me otherwise.

::: browser/components/nsBrowserGlue.js
@@ +776,5 @@
>      const PREF_TELEMETRY_SERVER_OWNER = "toolkit.telemetry.server_owner";
>      // This is used to reprompt users when privacy message changes
>      const TELEMETRY_PROMPT_REV = 2;
>  
> +    function appendTelemetryNotification(aNotifyBox, message, buttons, hideclose) {

be consistent w/ prefixing parameters with "a" and camel-casing (eg, compare aNotifyBox with hideclose). look elsewhere in file for what styles to follow here.

@@ +777,5 @@
>      // This is used to reprompt users when privacy message changes
>      const TELEMETRY_PROMPT_REV = 2;
>  
> +    function appendTelemetryNotification(aNotifyBox, message, buttons, hideclose) {
> +      let notification = aNotifyBox.appendNotification(message, "telemetry", null, aNotifyBox.PRIORITY_INFO_LOW, buttons);

80 char line length plz
Attachment #600411 - Flags: review?(dietrich) → review+
(Assignee)

Comment 7

6 years ago
Created attachment 600497 [details] [diff] [review]
patch

Made style consistent by using non-a-prefixed things and broke lines as best I could.  Carrying over r+.
Attachment #600411 - Attachment is obsolete: true
Attachment #600497 - Flags: review+
Comment on attachment 600497 [details] [diff] [review]
patch

https://hg.mozilla.org/integration/mozilla-inbound/rev/481410bfe37c
Attachment #600497 - Flags: checkin+
https://hg.mozilla.org/mozilla-central/rev/481410bfe37c
Status: ASSIGNED → RESOLVED
Last Resolved: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla13

Updated

6 years ago
Component: Telemetry → General
Product: Toolkit → Firefox
QA Contact: telemetry → general
Target Milestone: mozilla13 → ---

Updated

6 years ago
OS: Linux → All
Target Milestone: --- → Firefox 13
You need to log in before you can comment on or make changes to this bug.