Closed
Bug 71063
Opened 25 years ago
Closed 25 years ago
Cookies code passes nsInputFileStreams by value
Categories
(Core :: Networking: Cookies, defect)
Tracking
()
RESOLVED
FIXED
People
(Reporter: sfraser_bugs, Assigned: sfraser_bugs)
Details
Attachments
(1 file)
|
663 bytes,
patch
|
Details | Diff | Splinter Review |
cookie_Get() and cookie_GetLine() get nsInputFileStreams passed by value, not by
reference. This is very bad.
|
Assignee | |
Comment 1•25 years ago
|
||
|
||
Comment 2•25 years ago
|
||
r=blake
|
|
||
Comment 3•25 years ago
|
||
Do(n't) we want to pass by ref in cookie_GetLine (which, with your current
patch, would just pass a ref to the copy of the stream to cookie_Get())?
|
|
Assignee | |
Comment 4•25 years ago
|
||
blake was confused in his last comment.
|
|
||
Comment 5•25 years ago
|
||
Sorry, I missed the bottom of the patch to cookie_GetLine. Disregard last
comment.
|
|
||
Comment 6•25 years ago
|
||
a=morse as module owner.
|
|
Assignee | |
Comment 8•25 years ago
|
||
Checked in.
Status: NEW → RESOLVED
Closed: 25 years ago
Resolution: --- → FIXED
|
|
Assignee | |
Comment 9•25 years ago
|
||
Add morse to cc list.
You need to log in
before you can comment on or make changes to this bug.
Description
•