The default bug view has changed. See this FAQ.

"Enable Flash" text is confusing

VERIFIED FIXED

Status

()

Firefox for Android
General
P3
normal
VERIFIED FIXED
5 years ago
5 years ago

People

(Reporter: aaronmt, Assigned: Margaret)

Tracking

unspecified
ARM
Android
Points:
---

Firefox Tracking Flags

(firefox11 fixed, fennec11+)

Details

Attachments

(1 attachment)

(Reporter)

Description

5 years ago
http://hg.mozilla.org/mozilla-central/rev/41ceaff2e5f1 form bug 702653 landed the string, "Enable Flash" (pref_enable_flash). My device by default (Nexus S) currently does not have Flash installed. It is confusing to see Flash enabled yet it is not installed.

Stock browser has "Enable plug-ins"

--
Samsung Nexus S (Android 2.3.6)
Mozilla/5.0 (Android; Linux armv7l; rv:11.0a1) Gecko/20111214 Firefox/11.0a1 Fennec/11.0a1

Comment 1

5 years ago
lets not dictate solutions.  adjusting summary.

brad|snorp - maybe we can disable this option if we don't detect flash?
Summary: Rename "Enable Flash" to "Enable Plug-ins" → "Enable Flash" text is confusing
(In reply to Doug Turner (:dougt) from comment #1)

> brad|snorp - maybe we can disable this option if we don't detect flash?

Not worth the effort IMO. Let's just change the text. Madhava?
(Assignee)

Comment 3

5 years ago
In actuality, the pref enables/disables/tap to play-s all plugins, not just flash. I think we just used flash in the strings because that's the only plugin we have right now. We also use the word Flash in the doorhanger message. Should we change that as well?
Assignee: nobody → margaret.leibovic
(Assignee)

Updated

5 years ago
Keywords: uiwanted
Madhava is on vacation, so in his absence I agree we should change the text to 

"Enable Plugins"

(note no hyphenation)

And Margaret, we should probably change it in the doorhangers for consistency's sake as well.
(Assignee)

Comment 5

5 years ago
Created attachment 582897 [details] [diff] [review]
patch

I changed all the string entity names as well to reduce confusion in the future.
Attachment #582897 - Flags: review?(mark.finkle)
Comment on attachment 582897 [details] [diff] [review]
patch

looks good
Attachment #582897 - Flags: review?(mark.finkle) → review+
(Assignee)

Comment 7

5 years ago
https://hg.mozilla.org/integration/mozilla-inbound/rev/f2935a9c0ffc
Keywords: uiwanted

Updated

5 years ago
Priority: -- → P3
https://hg.mozilla.org/mozilla-central/rev/f2935a9c0ffc
Status: NEW → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
Verified fixed on Mozilla/5.0(Android;Linux armv7l;rv:12.0a1)Gecko/20111221;Firefox/12.0a1 Fennec/12.0a1.
Device: HTC Desire (Android 2.2)
Status: RESOLVED → VERIFIED
tracking-fennec: --- → 11+
https://hg.mozilla.org/releases/mozilla-aurora/rev/f2935a9c0ffc
status-firefox11: --- → fixed
You need to log in before you can comment on or make changes to this bug.