Closed Bug 710703 Opened 10 years ago Closed 10 years ago

"Enable Flash" text is confusing

Categories

(Firefox for Android Graveyard :: General, defect, P3)

ARM
Android
defect

Tracking

(firefox11 fixed, fennec11+)

VERIFIED FIXED
Tracking Status
firefox11 --- fixed
fennec 11+ ---

People

(Reporter: aaronmt, Assigned: Margaret)

Details

Attachments

(1 file)

http://hg.mozilla.org/mozilla-central/rev/41ceaff2e5f1 form bug 702653 landed the string, "Enable Flash" (pref_enable_flash). My device by default (Nexus S) currently does not have Flash installed. It is confusing to see Flash enabled yet it is not installed.

Stock browser has "Enable plug-ins"

--
Samsung Nexus S (Android 2.3.6)
Mozilla/5.0 (Android; Linux armv7l; rv:11.0a1) Gecko/20111214 Firefox/11.0a1 Fennec/11.0a1
lets not dictate solutions.  adjusting summary.

brad|snorp - maybe we can disable this option if we don't detect flash?
Summary: Rename "Enable Flash" to "Enable Plug-ins" → "Enable Flash" text is confusing
(In reply to Doug Turner (:dougt) from comment #1)

> brad|snorp - maybe we can disable this option if we don't detect flash?

Not worth the effort IMO. Let's just change the text. Madhava?
In actuality, the pref enables/disables/tap to play-s all plugins, not just flash. I think we just used flash in the strings because that's the only plugin we have right now. We also use the word Flash in the doorhanger message. Should we change that as well?
Assignee: nobody → margaret.leibovic
Keywords: uiwanted
Madhava is on vacation, so in his absence I agree we should change the text to 

"Enable Plugins"

(note no hyphenation)

And Margaret, we should probably change it in the doorhangers for consistency's sake as well.
Attached patch patchSplinter Review
I changed all the string entity names as well to reduce confusion in the future.
Attachment #582897 - Flags: review?(mark.finkle)
Comment on attachment 582897 [details] [diff] [review]
patch

looks good
Attachment #582897 - Flags: review?(mark.finkle) → review+
Priority: -- → P3
https://hg.mozilla.org/mozilla-central/rev/f2935a9c0ffc
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Verified fixed on Mozilla/5.0(Android;Linux armv7l;rv:12.0a1)Gecko/20111221;Firefox/12.0a1 Fennec/12.0a1.
Device: HTC Desire (Android 2.2)
Status: RESOLVED → VERIFIED
tracking-fennec: --- → 11+
Product: Firefox for Android → Firefox for Android Graveyard
You need to log in before you can comment on or make changes to this bug.