710734 - Expand list of tags and attributes allowed by Bleach in Kuma pages

Status: RESOLVED FIXED

(developer.mozilla.org Graveyard :: Editing, defect)

Description

[Les Orchard [:lorchard]]

MindTouch appears to allow a wider range of tags and attributes to be used by page authors. Expand the list allowed in Kuma, and investigate to see if there are more tags to be allowed. 

From an initial import of 100 pages, I found this:

    * allow HTML comments? (eg. en/JavaScript/Reference)
    * div
        * class=callout-box
        * class=note
    * small (ie. en/AJAX)
    * sup (ie. en/JavaScript)
    * pre (ie. en/Building_an_Extension)
    * h{1-6}
        * <h6> missing?
        * style (ie. en/CSS)
    * video
        * eg. en/CSS/CSS_transitions

Comment 1

[James Bennett [:ubernostrum]]

video and pre already seem to be allowed (i.e., are in the ALLOWED_TAGS list we pass to bleach.clean)?

Will add the rest of them, though.

Comment 2

[[github robot]]

Commit pushed to mdn at https://github.com/mozilla/kuma

https://github.com/mozilla/kuma/commit/d98868f65c38a7f2472eb0772b6e99eabd264daf
bug 710734 - Expand list of tags and attributes allowed by Bleach in Kuma pages

* Tell bleach to allow h6, pre and sup tags in wiki articles.

* Tell bleach to allow attributes on h6 tags in wiki articles.

* Tell bleach to allow HTML comments in wiki articles.

* Tell bleach to allow class attributes on divs in wiki articles.

* Tell bleach to allow style attributes on h1-h6 in wiki articles.

* Minor surgical swap of sumo's ALLOWED_ATTRIBUTES for our own in wiki
  parser.

* Add tests which verify that bleach allows all the tags we care about
  allowing.

* Start testing attributes.

* Test ALL the attributes\!

Comment 3

[Les Orchard [:lorchard]]

We may need to revisit this after further banging on migration, but for now...

Comment 4

[[github robot]]

Commit pushed to mdn_prod at https://github.com/mozilla/kuma

https://github.com/mozilla/kuma/commit/d98868f65c38a7f2472eb0772b6e99eabd264daf
bug 710734 - Expand list of tags and attributes allowed by Bleach in Kuma pages