Closed
Bug 710743
Opened 14 years ago
Closed 13 years ago
Detect X11 in the Source Editor
Categories
(DevTools :: Source Editor, defect, P5)
Tracking
(Not tracked)
RESOLVED
WONTFIX
People
(Reporter: msucan, Assigned: avp)
Details
(Whiteboard: [sourceeditor][good first bug][mentor=msucan])
Attachments
(1 file, 1 obsolete file)
|
2.36 KB,
patch
|
msucan
:
feedback+
karlt
:
feedback+
|
Details | Diff | Splinter Review |
In bug 695032 we added support for copying the selection into the X11 primary buffer. We currently limit this to the Linux platform, but we should do a better job at detecting if X11 is being used (irrespective of the platform).
Updated•14 years ago
|
Whiteboard: [sourceeditor] → [sourceeditor][good-first-bug]
Updated•14 years ago
|
Whiteboard: [sourceeditor][good-first-bug] → [sourceeditor][good first bug]
Updated•14 years ago
|
Whiteboard: [sourceeditor][good first bug] → [sourceeditor][good first bug][mentor=msucan]
Comment 2•14 years ago
|
||
Moving to Source Editor component.
Filter on CHELICERAE.
Component: Developer Tools → Developer Tools: Source Editor
| Assignee | ||
Comment 3•14 years ago
|
||
Hi Mihai,
I am interested in working on this bug. I am a beginner so could you please guide me on getting started with this bug.
Thanks.
| Reporter | ||
Comment 4•14 years ago
|
||
(In reply to Abhishek Potnis [:coolcoder91] from comment #3)
> Hi Mihai,
> I am interested in working on this bug. I am a beginner so could you please
> guide me on getting started with this bug.
>
> Thanks.
Hello Abhishek!
Thanks for your interest in fixing this bug. To start off:
1. the file you need to edit is browser/devtools/sourceeditor/source-editor-orion.jsm.
2. see bug 695032 comment 14, 15 and 16. They explain possible changes to the code, so we detected x11, instead of Linux.
3. see https://developer.mozilla.org/en/Browser_chrome_tests
this page tells you how to run the tests. The Source Editor tests are in browser/devtools/sourceeditor/test. Please make sure that all the tests pass before submitting a patch.
If you need a more general introduction to how you can contribute to the Mozilla codebase, please see https://developer.mozilla.org/en/Introduction - from here you can find how you can get the Firefox source code, how you can build it, how you create and submit patches.
If you need any help, please let me know. Good luck!
Assignee: nobody → abhishekp.bugzilla
Status: NEW → ASSIGNED
| Assignee | ||
Comment 5•14 years ago
|
||
Hi Mihai,
I have edited the file source-editor-orion.jsm and also built firefox for testing. Your advice
of allotting swap partition worked. However when I ran the browser chrome tests, I am getting the following on my terminal, I am pasting only the ending part as it is too large -
TEST-INFO | chrome://mochitests/content/browser/browser/base/content/test/browser_save_video.js | Console message: [JavaScript Warning: "WARN addons.updates: Request failed: 404: Not Found"]
TEST-INFO | chrome://mochitests/content/browser/browser/base/content/test/browser_save_video.js | Console message: [JavaScript Warning: "WARN addons.updates: Request failed: 404: Not Found"]
TEST-INFO | chrome://mochitests/content/browser/browser/base/content/test/browser_save_video.js | Console message: [JavaScript Warning: "WARN addons.updates: Request failed: 404: Not Found"]
TEST-INFO | chrome://mochitests/content/browser/browser/base/content/test/browser_save_video.js | Console message: [JavaScript Warning: "WARN addons.updates: Request failed: 404: Not Found"]
TEST-INFO | chrome://mochitests/content/browser/browser/base/content/test/browser_save_video.js | Console message: [JavaScript Warning: "WARN addons.updates: Request failed: 404: Not Found"]
TEST-UNEXPECTED-FAIL | chrome://mochitests/content/browser/browser/base/content/test/browser_save_video.js | application timed out after 330 seconds with no output
Not taking screenshot here: see the one that was previously logged
INFO | automation.py | Application ran for: 0:11:43.459965
INFO | automation.py | Reading PID log: /tmp/tmpgXSL0hpidlog
==> process 13923 launched child process 14007
==> process 13923 launched child process 14020
INFO | automation.py | Checking for orphan process with PID: 14007
INFO | automation.py | Checking for orphan process with PID: 14020
PROCESS-CRASH | chrome://mochitests/content/browser/browser/base/content/test/browser_save_video.js | application crashed (minidump found)
Crash dump filename: /tmp/tmp50DwBr/minidumps/39dcde89-2207-d160-1ff6c49e-62216af5.dmp
MINIDUMP_STACKWALK not set, can't process dump.
WARNING | automationutils.processLeakLog() | refcount logging is off, so leaks can't be detected!
INFO | runtests.py | Running tests: end.
make: *** [mochitest-browser-chrome] Error 1
make: Leaving directory `/home/abhishek/mozilla-central/obj-i686-pc-linux-gnu'
I am afraid I do not know how to interpret this. Please help me on this. Also shall I submit the edited file as a patch for your feedback ? Please guide me on this.
Thanks.
| Reporter | ||
Comment 6•14 years ago
|
||
Thanks for your work on this bug. Those errors do not concern us.
Please only run the source editor tests. Set TEST_PATH to point to the source editor tests folder: browser/devtools/sourceeeditor/test
For details, see https://developer.mozilla.org/en-US/docs/Browser_chrome_tests
Also, we do not work by uploading modified files here. We work with patches that tell us what you changed in the entire codebase.
To learn how to create patches and how to submit them here see:
https://developer.mozilla.org/en-US/docs/Creating_a_patch
https://developer.mozilla.org/en-US/docs/Developer_Guide/How_to_Submit_a_Patch
Thank you!
| Assignee | ||
Comment 7•14 years ago
|
||
Hi Mihai,
As suggested I ran the source editor tests but I am getting this -
abhishek@abhishek-G41MT-S2P:~/mozilla-central$ TEST_PATH=browser/devtools/sourceeeditor/test make -C obj-i686-pc-linux-gnu/ mochitest-browser-chrome
make: Entering directory `/home/abhishek/mozilla-central/obj-i686-pc-linux-gnu'
rm -f ./mochitest-browser-chrome.log && /home/abhishek/mozilla-central/obj-i686-pc-linux-gnu/_virtualenv/bin/python _tests/testing/mochitest/runtests.py --autorun --close-when-done --console-level=INFO --log-file=./mochitest-browser-chrome.log --file-level=INFO --failure-file=/home/abhishek/mozilla-central/obj-i686-pc-linux-gnu/_tests/testing/mochitest/makefailures.json --testing-modules-dir=/home/abhishek/mozilla-central/obj-i686-pc-linux-gnu/_tests/modules --symbols-path=./dist/crashreporter-symbols --test-path=browser/devtools/sourceeeditor/test --browser-chrome
INFO | runtests.py | Installing extension at /home/abhishek/mozilla-central/obj-i686-pc-linux-gnu/_tests/testing/mochitest/extensions/workerbootstrap to /tmp/tmpCD44VQ.
INFO | runtests.py | Installing extension at /home/abhishek/mozilla-central/obj-i686-pc-linux-gnu/_tests/testing/mochitest/extensions/worker to /tmp/tmpCD44VQ.
INFO | runtests.py | Installing extension at /home/abhishek/mozilla-central/obj-i686-pc-linux-gnu/_tests/testing/mochitest/extensions/specialpowers to /tmp/tmpCD44VQ.
args: ['/home/abhishek/mozilla-central/obj-i686-pc-linux-gnu/dist/bin/xpcshell', '-g', '/home/abhishek/mozilla-central/obj-i686-pc-linux-gnu/dist/bin', '-v', '170', '-f', './httpd.js', '-e', "const _PROFILE_PATH = '/tmp/tmpCD44VQ';const _SERVER_PORT = '8888'; const _SERVER_ADDR = '127.0.0.1'; const _TEST_PREFIX = undefined;", '-f', './server.js']
INFO | runtests.py | Server pid: 2519
args: ['/home/abhishek/mozilla-central/obj-i686-pc-linux-gnu/_virtualenv/bin/python', '/home/abhishek/mozilla-central/obj-i686-pc-linux-gnu/_tests/testing/mochitest/pywebsocket_wrapper.py', '-p', '9988', '-w', '/home/abhishek/mozilla-central/obj-i686-pc-linux-gnu/_tests/testing/mochitest', '-l', '/home/abhishek/mozilla-central/obj-i686-pc-linux-gnu/_tests/testing/mochitest/websock.log', '--log-level=debug', '--allow-handlers-outside-root-dir']
INFO | runtests.py | Websocket server pid: 2527
INFO | runtests.py | Running tests: start.
args: ['/home/abhishek/mozilla-central/obj-i686-pc-linux-gnu/dist/bin/certutil', '-N', '-d', '/tmp/tmpCD44VQ', '-f', '/tmp/tmpCD44VQ/.crtdbpw']
args: ['/home/abhishek/mozilla-central/obj-i686-pc-linux-gnu/dist/bin/certutil', '-A', '-i', '/home/abhishek/mozilla-central/build/pgo/certs/bug483440-attack2b.ca', '-d', '/tmp/tmpCD44VQ', '-f', '/tmp/tmpCD44VQ/.crtdbpw', '-n', 'bug483440-attack2b', '-t', 'CT,,']
args: ['/home/abhishek/mozilla-central/obj-i686-pc-linux-gnu/dist/bin/pk12util', '-i', '/home/abhishek/mozilla-central/build/pgo/certs/mochitest.client', '-w', '/tmp/tmpCD44VQ/.crtdbpw', '-d', '/tmp/tmpCD44VQ']
pk12util: PKCS12 IMPORT SUCCESSFUL
args: ['/home/abhishek/mozilla-central/obj-i686-pc-linux-gnu/dist/bin/certutil', '-A', '-i', '/home/abhishek/mozilla-central/build/pgo/certs/pgoca.ca', '-d', '/tmp/tmpCD44VQ', '-f', '/tmp/tmpCD44VQ/.crtdbpw', '-n', 'pgoca', '-t', 'CT,,']
args: ['/home/abhishek/mozilla-central/obj-i686-pc-linux-gnu/dist/bin/certutil', '-A', '-i', '/home/abhishek/mozilla-central/build/pgo/certs/bug483440-pk10oflo.ca', '-d', '/tmp/tmpCD44VQ', '-f', '/tmp/tmpCD44VQ/.crtdbpw', '-n', 'bug483440-pk10oflo', '-t', 'CT,,']
args: ['/home/abhishek/mozilla-central/obj-i686-pc-linux-gnu/dist/bin/certutil', '-A', '-i', '/home/abhishek/mozilla-central/build/pgo/certs/bug483440-attack7.ca', '-d', '/tmp/tmpCD44VQ', '-f', '/tmp/tmpCD44VQ/.crtdbpw', '-n', 'bug483440-attack7', '-t', 'CT,,']
args: ['/home/abhishek/mozilla-central/obj-i686-pc-linux-gnu/dist/bin/certutil', '-A', '-i', '/home/abhishek/mozilla-central/build/pgo/certs/jartests-object.ca', '-d', '/tmp/tmpCD44VQ', '-f', '/tmp/tmpCD44VQ/.crtdbpw', '-n', 'jartests-object', '-t', 'CT,,CT']
args: ['/home/abhishek/mozilla-central/obj-i686-pc-linux-gnu/dist/bin/ssltunnel', '/tmp/tmpCD44VQ/ssltunnel.cfg']
INFO | automation.py | SSL tunnel pid: 2535
args: ['/home/abhishek/mozilla-central/obj-i686-pc-linux-gnu/dist/bin/firefox-bin', '-no-remote', '-profile', '/tmp/tmpCD44VQ/', 'about:blank']
INFO | automation.py | Application pid: 2536
Server listening on port 4443 with cert pgo server certificate
*** Start BrowserChrome Test Results ***
INFO TEST-START | Shutdown
TEST-UNEXPECTED-FAIL | (browser-test.js) | No tests to run. Did you pass an invalid --test-path?
*** End BrowserChrome Test Results ***
INFO | automation.py | Application ran for: 0:00:04.116909
INFO | automation.py | Reading PID log: /tmp/tmpQRPL78pidlog
WARNING | automationutils.processLeakLog() | refcount logging is off, so leaks can't be detected!
INFO | runtests.py | Running tests: end.
mochitest-browser-chrome failed:
TEST-UNEXPECTED-FAIL | (browser-test.js) | No tests to run. Did you pass an invalid --test-path?
make: *** [mochitest-browser-chrome] Error 1
make: Leaving directory `/home/abhishek/mozilla-central/obj-i686-pc-linux-gnu'
I am attaching the patch as well........
Attachment #653013 -
Flags: feedback?(mihai.sucan)
| Reporter | ||
Comment 8•14 years ago
|
||
(In reply to Abhishek Potnis [:abhishekp] from comment #7)
> Created attachment 653013 [details] [diff] [review]
> edited the source-editor-orion.jsm to detect X11
>
> Hi Mihai,
>
> As suggested I ran the source editor tests but I am getting this -
>
> TEST_PATH=browser/devtools/sourceeeditor/test make -C obj-i686-pc-linux-gnu/
> mochitest-browser-chrome
Test path is wrong, there's a typo. "sourceeditor" instead of "sourceeeditor".
| Assignee | ||
Comment 9•14 years ago
|
||
Extremely Sorry Mihai for bothering you for such a silly mistake. I assure you this will not be repeated.
I tested and got this:
INFO TEST-START | Shutdown
Browser Chrome Test Summary
Passed: 369
Failed: 0
Todo: 0
*** End BrowserChrome Test Results ***
INFO | automation.py | Application ran for: 0:00:23.038755
INFO | automation.py | Reading PID log: /tmp/tmpWEc09Zpidlog
WARNING | automationutils.processLeakLog() | refcount logging is off, so leaks can't be detected!
INFO | runtests.py | Running tests: end.
make: Leaving directory `/home/abhishek/mozilla-central/obj-i686-pc-lin
I have already uploaded the patch for this.........
Thanks.
| Reporter | ||
Comment 10•14 years ago
|
||
Comment on attachment 653013 [details] [diff] [review]
edited the source-editor-orion.jsm to detect X11
Review of attachment 653013 [details] [diff] [review]:
-----------------------------------------------------------------
Thanks for your patch. Only one comment below.
::: browser/devtools/sourceeditor/source-editor-orion.jsm
@@ +131,5 @@
> },
> ];
>
> if (Services.appinfo.OS == "WINNT" ||
> + Services.appinfo.widgetToolkit.slice(0,3) == "gtk") {
Please do not change this here. We only need to detect gtk in the case of primary selection updates.
Attachment #653013 -
Flags: feedback?(mihai.sucan) → feedback+
| Assignee | ||
Comment 11•14 years ago
|
||
Attachment #653013 -
Attachment is obsolete: true
Attachment #653429 -
Flags: feedback?(mihai.sucan)
| Reporter | ||
Comment 12•14 years ago
|
||
Comment on attachment 653429 [details] [diff] [review]
made the suggested changes on source-editor-orion.jsm
Karl: is this a safe change from our contributor? It works on my system (Ubuntu 12.04), but I haven't tried KDE or other systems.
Attachment #653429 -
Flags: feedback?(mihai.sucan)
Attachment #653429 -
Flags: feedback?(karlt)
Attachment #653429 -
Flags: feedback+
Comment 13•14 years ago
|
||
Comment on attachment 653429 [details] [diff] [review]
made the suggested changes on source-editor-orion.jsm
This will work on all systems for our GTK builds.
It won't match for builds with Qt, but that is not listed on https://developer.mozilla.org/en-US/docs/Supported_build_configurations
Attachment #653429 -
Flags: feedback?(karlt) → feedback+
| Reporter | ||
Comment 14•14 years ago
|
||
Karl: thank you for your feedback!
Abhishek: thank you for your patch. We will further analyze the opportunity to land this patch. Once we decide on this, we will get back to you.
Comment 15•14 years ago
|
||
This should ideally be tested on Linux and also on GTK-but-not-Linux, since the point is to convert what is presently a Linux-dependent feature to a GTK-dependent one.
I am under the impression that our Qt backend is for mobile (Maemo e.g.) rather than for Qt-based desktop environments, so it probably isn't appropriate to make this feature available there.
Comment 16•13 years ago
|
||
msucan, is this still in patch-landing limbo? Should it still be tagged "good first bug"? If it doesn't still need more work from a contributor or a person being mentored, I think we should take off the tags that feed it into Bugs Ahoy and openhatch. Thanks!
Flags: needinfo?(mihai.sucan)
| Reporter | ||
Comment 17•13 years ago
|
||
Liz: marking this bug as WONTFIX because there's no obvious/easy way to test what Zack suggested and the benefits are marginal - if they even exist.
Thank you!
Status: ASSIGNED → RESOLVED
Closed: 13 years ago
Flags: needinfo?(mihai.sucan)
Resolution: --- → WONTFIX
Updated•8 years ago
|
Product: Firefox → DevTools
You need to log in
before you can comment on or make changes to this bug.
Description
•