710757 - Cannot use advanced query for any of the Firefox 9 betas

Status: VERIFIED FIXED

(Socorro :: Webapp, task)

Description

[Marcia Knous [:marcia]]

STR:

1. Go to advanced query.
2. Select 9.0b6
3. No results returned. Happens whether you select an individual platform or not.

Same thing happens with all the 9.0 betas. 8.0.1 query returns results.

Sample query where this is happening: https://crash-stats.mozilla.com/query/query?product=Firefox&version=Firefox%3A9.0b1&range_value=1&range_unit=weeks&date=12%2F14%2F2011+09%3A31%3A57&query_search=signature&query_type=contains&query=&reason=&build_id=&process_type=any&hang_type=any&do_query=1

This is different from Bug 709166 which I filed because the UI was not showing.

Comment 1

[Robert Helmer [:rhelmer]]

This is a regression in the SQL query that the code generates, I suspect from bug 681112. I think it'll be easier to patch this and roll forward than try to roll back.

Comment 2

[Robert Helmer [:rhelmer]]

(In reply to Robert Helmer [:rhelmer] from comment #1)
> This is a regression in the SQL query that the code generates, I suspect
> from bug 681112. I think it'll be easier to patch this and roll forward than
> try to roll back.

OK it's definitely the changes from bug 681112. More specifically it has to do with the way multiple version versus single version searches are handled. Note that this works:

https://crash-stats.mozilla.com/query/query?product=Firefox&version=Firefox%3A9.0b5&version=Firefox%3A9.0b4&range_value=1&range_unit=weeks&date=12%2F14%2F2011+09%3A31%3A57&query_search=signature&query_type=contains&query=&reason=&build_id=&process_type=any&hang_type=any&do_query=1

Unselecting one of the versions causes it to not work. Working on a patch for this now.

Comment 3

[[github robot]]

Commits pushed to https://github.com/mozilla/socorro

https://github.com/mozilla/socorro/commit/53470defdaf05f75a8b66c4a57270e65d6cc6ef7
bug 710757 - unbreak search, x can be None or 0, they mean different things here

https://github.com/mozilla/socorro/commit/039bd9f6ae81615c35a82a546d41377476972f12
Merge pull request #226 from rhelmer/bug710757-fix-search

bug 710757 - unbreak search, x can be None or 0, they mean different thi...

Comment 4

[[github robot]]

Commit pushed to https://github.com/mozilla/socorro

https://github.com/mozilla/socorro/commit/53470defdaf05f75a8b66c4a57270e65d6cc6ef7
bug 710757 - unbreak search, x can be None or 0, they mean different things here

Comment 5

[[github robot]]

Commits pushed to https://github.com/mozilla/socorro

https://github.com/mozilla/socorro/commit/53470defdaf05f75a8b66c4a57270e65d6cc6ef7
bug 710757 - unbreak search, x can be None or 0, they mean different things here

https://github.com/mozilla/socorro/commit/d89189fdd411b0bf8a0a22ae83e86e12cad141fe
Merge pull request #227 from rhelmer/bug710757-fix-search

bug 710757 - unbreak search, x can be None or 0, they mean different thi...

Comment 6

[[github robot]]

Commit pushed to https://github.com/mozilla/socorro

https://github.com/mozilla/socorro/commit/c920975555e7f0ca5e6aca020037052340f7a36a
bug 710757 - unbreak search, x can be None or 0, they mean different things here

Comment 7

[Robert Helmer [:rhelmer]]

This now works on stage:
https://crash-stats.allizom.org/query/query?product=Firefox&version=Firefox%3A9.0b1&range_value=1&range_unit=weeks&date=12%2F14%2F2011+09%3A31%3A57&query_search=signature&query_type=contains&query=&reason=&build_id=&process_type=any&hang_type=any&do_query=1

I've updated https://wiki.mozilla.org/Socorro:Releases#Upcoming_Releases

This will go out first thing in the morning.

Comment 8

[Matt Brandt [:mbrandt]]

QA verified on stage. Automation passes. Tested searches for various products, combinations of releases and specific signatures. 

comment 0 points out no results are returned for 9.0b6. I was unable to test this path explicitly on stage because we don't have data. The other paths do work 9.0 betas, 8.0.1