710761 - add test for cycle collector listener begin failure

Status: RESOLVED INCOMPLETE

(Core :: XPConnect, defect)

Description

[Andrew McCreight [:mccr8] (PTO until 12-2)]

This invokes the cycle collector with a special listener implemented in JS.

The begin() fails with an NS_ERROR_FAILURE.  Every other callback clears a flag.  The test fails if the flag is ever cleared.  This actually tests the case where the CC dump file can't be created, without actually dumping a file.

I checked that this test fails without the patch in bug 694436, and passes on m-c on all platforms.

Comment 1

[Andrew McCreight [:mccr8] (PTO until 12-2)]

Attachment: add a test

Test-only change, so just looking for an rs kind of thing.  All other comments welcome, of course.

Comment 2

[Bobby Holley (:bholley)]

Comment on attachment 581678 [details] [diff] [review]
add a test

Same review comments for the other test apply - Look into the broken link, and either use Cc, Ci, etc, or don't define them.

Comment 3

[Andrew McCreight [:mccr8] (PTO until 12-2)]

Ah, good point.  Thanks for the reviews.

Comment 4

[Andrew McCreight [:mccr8] (PTO until 12-2)]

https://hg.mozilla.org/mozilla-central/rev/4946cb558c97

Comment 5

[Andrew McCreight [:mccr8] (PTO until 12-2)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/e517d4c43143

Backed out because it caused an infinite loop with single threading of JS.  Calling JS while on the CC thread is a bad idea, apparently.  I'll rewrite the empty listener in C++ I guess.

Comment 6

[Andrew McCreight [:mccr8] (PTO until 12-2)]

The listener is fixed now, so it will be harder to test this. I think you have to somehow generate an invalid file name.