Closed Bug 710761 Opened 8 years ago Closed 3 years ago
add test for cycle collector listener begin failure
This invokes the cycle collector with a special listener implemented in JS. The begin() fails with an NS_ERROR_FAILURE. Every other callback clears a flag. The test fails if the flag is ever cleared. This actually tests the case where the CC dump file can't be created, without actually dumping a file. I checked that this test fails without the patch in bug 694436, and passes on m-c on all platforms.
Test-only change, so just looking for an rs kind of thing. All other comments welcome, of course.
Assignee: nobody → continuation
Attachment #581678 - Flags: review?(bobbyholley+bmo)
Comment on attachment 581678 [details] [diff] [review] add a test Same review comments for the other test apply - Look into the broken link, and either use Cc, Ci, etc, or don't define them.
Attachment #581678 - Flags: review?(bobbyholley+bmo) → review+
Ah, good point. Thanks for the reviews.
Status: NEW → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla11
https://hg.mozilla.org/integration/mozilla-inbound/rev/e517d4c43143 Backed out because it caused an infinite loop with single threading of JS. Calling JS while on the CC thread is a bad idea, apparently. I'll rewrite the empty listener in C++ I guess.
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
The listener is fixed now, so it will be harder to test this. I think you have to somehow generate an invalid file name.
Assignee: continuation → nobody
Status: REOPENED → RESOLVED
Closed: 8 years ago → 3 years ago
Resolution: --- → INCOMPLETE
You need to log in before you can comment on or make changes to this bug.