Closed Bug 710845 Opened 13 years ago Closed 12 years ago

Don't show disabled search engines in AwesomeBar

Categories

(Firefox for Android Graveyard :: General, defect, P3)

Product:
Firefox for Android Graveyard
Component:
General
Platform:
ARM
Android
Type:
defect

Tracking

(firefox11 verified, firefox12 verified, firefox13 verified, blocking-fennec1.0 beta+, fennec11+)

Status:
VERIFIED FIXED
Milestone:
Firefox 12
Tracking Flags:
Tracking Status
firefox11 --- verified
firefox12 --- verified
firefox13 --- verified
blocking-fennec1.0 --- beta+
fennec 11+ ---

People

(Reporter: cpeterson, Assigned: bnicholson)

References

Details

Attachments

(1 file)

patch
990 bytes, patch
mfinkle
: review+
akeybl
: approval-mozilla-beta+
Details | Diff | Splinter Review 
STR:
1. Go to Add-ons Manager
2. Select and disable Amazon.com search engine
3. Tap in address box and enter a search term

AR:
Amazon.com search engine is list among the Awesome Screen search results.

ER:
Disabled search engines should not be listed in Awesome Screensearch results.
Assignee: nobody → bnicholson
Priority: -- → P3
Based on the other dupes, let's make sure this bug handles: installing, disabling and uninstalling search engines.

We should update the Java UI whenever one of those events happens. The XUL app does that as well.
tracking-fennec: --- → 11+
requesting beta blocker for 11+.   The broken functionality of this bug is exposed in addons manager, and we need to make a decision to either hide it or fix it.   this worked on Fennec XUL.
Keywords: fennecnative-betablocker
Blocks: aom
Summary: Search engine disabled in Add-ons Manager still appears in Awesome Screen search results → Don't show disabled search engines in AwesomeBar
Attached patch patch — — Splinter Review 

        Attachment #592888 -
        Flags: review?(mark.finkle)

        Attachment #592888 -
        Flags: review?(mark.finkle) → review+

    
    

    
  
https://hg.mozilla.org/mozilla-central/rev/192205ad7f9c
Status: NEW → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 12

    
    

    
  
Comment on attachment 592888 [details] [diff] [review]
patch

[Approval Request Comment]
Disabled search engines aren't shown in AwesomeBar. Very low risk.

        Attachment #592888 -
        Flags: approval-mozilla-aurora?

    
    

    
  
Comment on attachment 592888 [details] [diff] [review]
patch

[Triage Comment]

[Triage Comment]
Mobile only - approved for Beta 11.

        Attachment #592888 -
        Flags: approval-mozilla-aurora? → approval-mozilla-beta+

    
    

    
  
Verified fixed on:

Firefox 13.0a1 (2012-02-06)
20120206031148
http://hg.mozilla.org/mozilla-central/rev/814d0b2dbaba
Device: HTC Desire Z
OS: Android 2.3.3

Firefox 12.0a2 (2012-02-06)
20120206042011
http://hg.mozilla.org/releases/mozilla-aurora/rev/9fb0c06ceb49
Device: HTC Desire Z
OS: Android 2.3.3

Firefox 11.0
20120206202409
http://hg.mozilla.org/releases/mozilla-beta/rev/1c0aba74d116
Device: HTC Desire Z
OS: Android 2.3.3
Status: RESOLVED → VERIFIED

          status-firefox12:
          --- → fixed

          status-firefox13:
          --- → fixed
blocking-fennec1.0: --- → beta+
Product: Firefox for Android → Firefox for Android Graveyard

          You need to log in
          before you can comment on or make changes to this bug.
        






  

    
  







  

    

      
Attachment

      

      
      
      
      
    

    

      

        

          

            
General

            

              Creator: 



            

            
Created: 

            
Updated: 

            
Size: