710864 - StrictMode - unclosed stream warning in Fennec Native in AboutHomeContent

Status: RESOLVED FIXED

(Firefox for Android Graveyard :: General, defect)

Description

[Kartikaya Gupta (email:[e-mail])]

Found this at https://bug708934.bugzilla.mozilla.org/attachment.cgi?id=581523 (attachment on bug 708934):

E/StrictMode( 4978): A resource was acquired at attached stack trace but never released. See java.io.Closeable for information on avoiding resource leaks.
E/StrictMode( 4978): java.lang.Throwable: Explicit termination method 'close' not called
E/StrictMode( 4978): at dalvik.system.CloseGuard.open(CloseGuard.java:184)
E/StrictMode( 4978): at java.io.FileInputStream.<init>(FileInputStream.java:80)
E/StrictMode( 4978): at org.mozilla.gecko.AboutHomeContent.getProfileRecommendedAddonsStream(AboutHomeContent.java:162)
E/StrictMode( 4978): at org.mozilla.gecko.AboutHomeContent.getRecommendedAddonsStream(AboutHomeContent.java:170)
E/StrictMode( 4978): at org.mozilla.gecko.AboutHomeContent$4.run(AboutHomeContent.java:184)
E/StrictMode( 4978): at android.os.Handler.handleCallback(Handler.java:605)
E/StrictMode( 4978): at android.os.Handler.dispatchMessage(Handler.java:92)
E/StrictMode( 4978): at android.os.Looper.loop(Looper.java:137)
E/StrictMode( 4978): at org.mozilla.gecko.GeckoAppShell$LooperThread.run(GeckoAppShell.java:153)

Comment 1

[Kartikaya Gupta (email:[e-mail])]

Attachment: (1/2) Close input stream

Comment 2

[Kartikaya Gupta (email:[e-mail])]

Attachment: (2/2) Fix logtags

Comment 3

[Kartikaya Gupta (email:[e-mail])]

https://hg.mozilla.org/mozilla-central/rev/1eff10689611
https://hg.mozilla.org/mozilla-central/rev/bbb2149b613e