Closed
Bug 710878
Opened 14 years ago
Closed 14 years ago
Bookmark label can omit part of the text in the link
Categories
(Firefox :: Bookmarks & History, defect)
Firefox
Bookmarks & History
Tracking
()
RESOLVED
FIXED
Firefox 11
People
(Reporter: paul, Unassigned)
Details
(Whiteboard: [fixed-in-fx-team])
Attachments
(2 files, 1 obsolete file)
|
78 bytes,
text/html
|
Details | |
|
3.25 KB,
patch
|
dietrich
:
review+
|
Details | Diff | Splinter Review |
STR:
1) open the attached HTML file
2) right click on the link
3) click "bookmark this link"
result:
In the dialog, the name of the bookmark is "word1 word2".
expected result:
It should be "word1 word2 word3".
|
Reporter | |
Comment 1•14 years ago
|
||
Twitter work:
Patch by @DvdBng.
Bug found an reported (with a mxr link to the faulty function) by @manchurian.
Attachment #581771 -
Flags: review?(dietrich)
|
||
Comment 2•14 years ago
|
||
Comment on attachment 581771 [details] [diff] [review]
patch v1
Review of attachment 581771 [details] [diff] [review]:
-----------------------------------------------------------------
change looks fine, thanks for fixing this! attach an automated test along with the code change and i can r+ this.
Attachment #581771 -
Flags: review?(dietrich)
|
|
||
Updated•14 years ago
|
OS: Linux → All
Hardware: x86_64 → All
|
|
Reporter | |
Comment 3•14 years ago
|
||
|
|
Reporter | |
Updated•14 years ago
|
Attachment #581771 -
Attachment is obsolete: true
|
|
Reporter | |
Comment 4•14 years ago
|
||
Comment on attachment 582028 [details] [diff] [review]
patch with test
Do you think a try run is necessary?
Attachment #582028 -
Flags: review?(dietrich)
|
|
||
Comment 5•14 years ago
|
||
Comment on attachment 582028 [details] [diff] [review]
patch with test
Review of attachment 582028 [details] [diff] [review]:
-----------------------------------------------------------------
looks great, r=me. thanks!
no need for try test on this... assuming it's passing locally ;)
Attachment #582028 -
Flags: review?(dietrich) → review+
|
|
Reporter | |
Comment 6•14 years ago
|
||
(In reply to Dietrich Ayala (:dietrich) from comment #5)
> Comment on attachment 582028 [details] [diff] [review]
> patch with test
>
> Review of attachment 582028 [details] [diff] [review]:
> -----------------------------------------------------------------
>
> looks great, r=me. thanks!
>
> no need for try test on this... assuming it's passing locally ;)
It is! Thank you.
Whiteboard: [land-in-fx-team]
|
||
Comment 7•14 years ago
|
||
Whiteboard: [land-in-fx-team] → [fixed-in-fx-team]
|
|
||
Comment 8•14 years ago
|
||
Status: NEW → RESOLVED
Closed: 14 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 11
|
||
Comment 9•14 years ago
|
||
Happy 7th birthday! I am of course referring to the original bug 274486, which even has a comment describing the correct way to fix the bug rather than monkeypatching gatherTextUnder into a treewalker like we did for Thunderbird in bug 369341 only 4.75 years ago...
You need to log in
before you can comment on or make changes to this bug.
Description
•