Bookmark label can omit part of the text in the link

RESOLVED FIXED in Firefox 11

Status

()

Firefox
Bookmarks & History
RESOLVED FIXED
6 years ago
6 years ago

People

(Reporter: paul, Unassigned)

Tracking

Trunk
Firefox 11
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: [fixed-in-fx-team])

Attachments

(2 attachments, 1 obsolete attachment)

(Reporter)

Description

6 years ago
Created attachment 581767 [details]
test

STR:

1) open the attached HTML file
2) right click on the link
3) click "bookmark this link"

result:
In the dialog, the name of the bookmark is "word1 word2".

expected result:
It should be "word1 word2 word3".
(Reporter)

Comment 1

6 years ago
Created attachment 581771 [details] [diff] [review]
patch v1

Twitter work:

Patch by @DvdBng.
Bug found an reported (with a mxr link to the faulty function) by @manchurian.
Attachment #581771 - Flags: review?(dietrich)
Comment on attachment 581771 [details] [diff] [review]
patch v1

Review of attachment 581771 [details] [diff] [review]:
-----------------------------------------------------------------

change looks fine, thanks for fixing this! attach an automated test along with the code change and i can r+ this.
Attachment #581771 - Flags: review?(dietrich)
OS: Linux → All
Hardware: x86_64 → All
(Reporter)

Comment 3

6 years ago
Created attachment 582028 [details] [diff] [review]
patch with test
(Reporter)

Updated

6 years ago
Attachment #581771 - Attachment is obsolete: true
(Reporter)

Comment 4

6 years ago
Comment on attachment 582028 [details] [diff] [review]
patch with test

Do you think a try run is necessary?
Attachment #582028 - Flags: review?(dietrich)
Comment on attachment 582028 [details] [diff] [review]
patch with test

Review of attachment 582028 [details] [diff] [review]:
-----------------------------------------------------------------

looks great, r=me. thanks!

no need for try test on this... assuming it's passing locally ;)
Attachment #582028 - Flags: review?(dietrich) → review+
(Reporter)

Comment 6

6 years ago
(In reply to Dietrich Ayala (:dietrich) from comment #5)
> Comment on attachment 582028 [details] [diff] [review]
> patch with test
> 
> Review of attachment 582028 [details] [diff] [review]:
> -----------------------------------------------------------------
> 
> looks great, r=me. thanks!
> 
> no need for try test on this... assuming it's passing locally ;)

It is! Thank you.
Whiteboard: [land-in-fx-team]
https://hg.mozilla.org/integration/fx-team/rev/67500e02c844
Whiteboard: [land-in-fx-team] → [fixed-in-fx-team]
https://hg.mozilla.org/mozilla-central/rev/67500e02c844
Status: NEW → RESOLVED
Last Resolved: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 11

Comment 9

6 years ago
Happy 7th birthday! I am of course referring to the original bug 274486, which even has a comment describing the correct way to fix the bug rather than monkeypatching gatherTextUnder into a treewalker like we did for Thunderbird in bug 369341 only 4.75 years ago...
You need to log in before you can comment on or make changes to this bug.