Last Comment Bug 710946 - BaseShape::getterObj (and setterObj) are not write barriered
: BaseShape::getterObj (and setterObj) are not write barriered
Status: RESOLVED FIXED
:
Product: Core
Classification: Components
Component: JavaScript Engine (show other bugs)
: Trunk
: All All
: -- normal (vote)
: mozilla11
Assigned To: Terrence Cole [:terrence]
:
Mentors:
Depends on:
Blocks: 673454
  Show dependency treegraph
 
Reported: 2011-12-14 17:45 PST by Terrence Cole [:terrence]
Modified: 2011-12-16 05:56 PST (History)
3 users (show)
See Also:
Crash Signature:
(edit)
QA Whiteboard:
Iteration: ---
Points: ---
Has Regression Range: ---
Has STR: ---


Attachments
v1: post barrier BaseShape::getterObj and setterObj (1.62 KB, patch)
2011-12-15 17:53 PST, Terrence Cole [:terrence]
wmccloskey: review+
Details | Diff | Review

Description Terrence Cole [:terrence] 2011-12-14 17:45:23 PST
These fields are immutable, so they do not necessarily need a barrier for incremental collection -- they do, however, need a barrier for generational collection, and for reliable verification of the barriers.  It would be nice to make these HeapPtr's, rather than manually calling the barrier functions, but the fields are unioned with a function pointer, so this is not trivial.
Comment 1 Terrence Cole [:terrence] 2011-12-15 17:53:44 PST
Created attachment 582155 [details] [diff] [review]
v1: post barrier BaseShape::getterObj and setterObj

This is how we are adding barriers for the unioned fields in String, so I think this is probably fine.
Comment 2 Bill McCloskey (:billm) 2011-12-15 17:56:33 PST
Comment on attachment 582155 [details] [diff] [review]
v1: post barrier BaseShape::getterObj and setterObj

Yeah, I guess this is fine.
Comment 3 Terrence Cole [:terrence] 2011-12-15 18:04:49 PST
https://hg.mozilla.org/integration/mozilla-inbound/rev/ea39fc88f948
Comment 4 Ed Morley [:emorley] 2011-12-16 05:56:41 PST
https://hg.mozilla.org/mozilla-central/rev/ea39fc88f948

Note You need to log in before you can comment on or make changes to this bug.