Closed
Bug 710946
Opened 14 years ago
Closed 14 years ago
BaseShape::getterObj (and setterObj) are not write barriered
Categories
(Core :: JavaScript Engine, defect)
Core
JavaScript Engine
Tracking
()
RESOLVED
FIXED
mozilla11
People
(Reporter: terrence, Assigned: terrence)
References
Details
Attachments
(1 file)
|
1.62 KB,
patch
|
billm
:
review+
|
Details | Diff | Splinter Review |
These fields are immutable, so they do not necessarily need a barrier for incremental collection -- they do, however, need a barrier for generational collection, and for reliable verification of the barriers. It would be nice to make these HeapPtr's, rather than manually calling the barrier functions, but the fields are unioned with a function pointer, so this is not trivial.
|
Assignee | |
Comment 1•14 years ago
|
||
This is how we are adding barriers for the unioned fields in String, so I think this is probably fine.
Comment on attachment 582155 [details] [diff] [review]
v1: post barrier BaseShape::getterObj and setterObj
Yeah, I guess this is fine.
Attachment #582155 -
Flags: review?(wmccloskey) → review+
|
|
Assignee | |
Comment 3•14 years ago
|
||
|
||
Comment 4•14 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 14 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla11
You need to log in
before you can comment on or make changes to this bug.
Description
•