Closed
Bug 710950
Opened 14 years ago
Closed 14 years ago
JSScript::function_ is not barriered
Categories
(Core :: JavaScript Engine, defect)
Core
JavaScript Engine
Tracking
()
RESOLVED
FIXED
mozilla11
People
(Reporter: terrence, Assigned: terrence)
References
Details
Attachments
(2 files)
|
2.16 KB,
patch
|
billm
:
review+
|
Details | Diff | Splinter Review |
|
2.15 KB,
patch
|
Details | Diff | Splinter Review |
This is immutable, but will need to be barriered for generational GC. JSFunction is a JSObject, so this should not be difficult to add.
|
Assignee | |
Comment 1•14 years ago
|
||
The field is immutable, so we can return an unwrapped pointer and don't have to worry about it for incremental barriers. We do need post barriers on it during init for detecting cross-generation pointers, however. Just make it a normal HeapPtr.
Comment on attachment 582124 [details] [diff] [review]
v1: barrier function_
Review of attachment 582124 [details] [diff] [review]:
-----------------------------------------------------------------
Good to see these getting fixed!
::: js/src/jsscript.h
@@ +528,5 @@
> js::ScriptOpcodeCounts pcCounters;
>
> private:
> + js::DebugScript *debug;
> + js::HeapPtr<JSFunction> function_;
js::HeapPtrFunction is shorter.
Attachment #582124 -
Flags: review?(wmccloskey) → review+
|
|
Assignee | |
Comment 3•14 years ago
|
||
|
|
Assignee | |
Comment 4•14 years ago
|
||
|
||
Comment 5•14 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 14 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla11
You need to log in
before you can comment on or make changes to this bug.
Description
•