710986 - Possible typo in IsZPositionLEQ()

Status: RESOLVED INVALID

(Core :: Layout, defect)

Description

[Justin Dolske [:Dolske]]

From http://www.viva64.com/en/a/0078/,
2nd section in http://www.viva64.com/external-pictures/txt/mozilla-test.txt


V501 There are identical sub-expressions to the left and to the right of the '||' operator.
nsdisplaylist.cpp 767

static PRBool IsZPositionLEQ(nsDisplayItem* aItem1, nsDisplayItem* aItem2,
                             void* aClosure) {
  if (!aItem1->GetUnderlyingFrame()->Preserves3D() ||
      !aItem1->GetUnderlyingFrame()->Preserves3D()) {
    return IsContentLEQ(aItem1, aItem2, aClosure);
  }
  ...
}

I think there could be written like this.
if (!aItem1->GetUnderlyingFrame()->Preserves3D() ||
    !aItem2->GetUnderlyingFrame()->Preserves3D()) {

Comment 1

[Tim Taubert [:ttaubert] (inactive)]

Introduced with bug 505115, already fixed by bug 684759. Marking as invalid.