710987 - Possible duplicate conditional in WordSplitState::FindSpecialWord()

Status: RESOLVED FIXED

(Core :: Spelling checker, defect)

Description

[Justin Dolske [:Dolske]]

From http://www.viva64.com/en/a/0078/,
4th section in http://www.viva64.com/external-pictures/txt/mozilla-test.txt

V501 There are identical sub-expressions 'protocol.EqualsIgnoreCase ("ftp")' to the left and to the right of the '||' operator.
mozinlinespellwordutil.cpp 1034

Not a error. But one "protocol.EqualsIgnoreCase("ftp")" can be removed.

if (protocol.EqualsIgnoreCase("http") ||
    protocol.EqualsIgnoreCase("https") ||
    protocol.EqualsIgnoreCase("news") ||
    protocol.EqualsIgnoreCase("ftp") ||
    protocol.EqualsIgnoreCase("file") ||
    protocol.EqualsIgnoreCase("javascript") ||
    protocol.EqualsIgnoreCase("ftp")) {

Comment 1

[Thomas Prip Vestergaard [:prip]]

Attachment: Bug 710987 - Remove duplicate conditional

Comment 2

[Jared Wein [:jaws] (please needinfo? me)]

prip: When you are happy with the state of the patch, please request review from gavin by setting the "review?" flag to "[e-mail]" and feedback from ryanvm by setting the "feedback?" flag to "[e-mail]". Thanks for your contribution!

Comment 3

[Jared Wein [:jaws] (please needinfo? me)]

(In reply to Jared Wein [:jwein and :jaws] from comment #2)
> prip: When you are happy with the state of the patch, please request review
> from gavin by setting the "review?" flag to "[e-mail]" and feedback

Sorry, I meant to say to request review from gavin by setting the "review?" flag to "[e-mail]".

Comment 4

[Ryan VanderMeulen [:RyanVM]]

I don't need to provide feedback on this. Thanks for asking, though :)

Comment 5

[Ed Morley [:emorley]]

Comment on attachment 582123 [details] [diff] [review]
Bug 710987 - Remove duplicate conditional

https://hg.mozilla.org/integration/mozilla-inbound/rev/6fcec9ac1164

Comment 6

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/6fcec9ac1164