The default bug view has changed. See this FAQ.

Possible duplicate conditional in WordSplitState::FindSpecialWord()

RESOLVED FIXED in mozilla11

Status

()

Core
Spelling checker
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: Dolske, Assigned: prip)

Tracking

(Blocks: 1 bug)

unspecified
mozilla11
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: [pvs-studio][good first bug][lang=c++][mentor=jwein])

Attachments

(1 attachment)

(Reporter)

Description

5 years ago
From http://www.viva64.com/en/a/0078/,
4th section in http://www.viva64.com/external-pictures/txt/mozilla-test.txt

V501 There are identical sub-expressions 'protocol.EqualsIgnoreCase ("ftp")' to the left and to the right of the '||' operator.
mozinlinespellwordutil.cpp 1034

Not a error. But one "protocol.EqualsIgnoreCase("ftp")" can be removed.

if (protocol.EqualsIgnoreCase("http") ||
    protocol.EqualsIgnoreCase("https") ||
    protocol.EqualsIgnoreCase("news") ||
    protocol.EqualsIgnoreCase("ftp") ||
    protocol.EqualsIgnoreCase("file") ||
    protocol.EqualsIgnoreCase("javascript") ||
    protocol.EqualsIgnoreCase("ftp")) {
(Reporter)

Updated

5 years ago
Blocks: 710966
Whiteboard: [pvs-studio] → [pvs-studio][good first bug][lang=c++]
(Assignee)

Comment 1

5 years ago
Created attachment 582123 [details] [diff] [review]
Bug 710987 - Remove duplicate conditional
prip: When you are happy with the state of the patch, please request review from gavin by setting the "review?" flag to "roc@ocallahan.org" and feedback from ryanvm by setting the "feedback?" flag to "ryanvm@gmail.com". Thanks for your contribution!
Assignee: nobody → thomas
Status: NEW → ASSIGNED
Whiteboard: [pvs-studio][good first bug][lang=c++] → [pvs-studio][good first bug][lang=c++][mentor=jwein]
(In reply to Jared Wein [:jwein and :jaws] from comment #2)
> prip: When you are happy with the state of the patch, please request review
> from gavin by setting the "review?" flag to "roc@ocallahan.org" and feedback

Sorry, I meant to say to request review from gavin by setting the "review?" flag to "gavin.sharp@gmail.com".
I don't need to provide feedback on this. Thanks for asking, though :)
(Assignee)

Updated

5 years ago
Attachment #582123 - Flags: review?(roc)
Attachment #582123 - Flags: feedback?(ryanvm)
Attachment #582123 - Flags: feedback?(ryanvm)
Attachment #582123 - Flags: review?(roc)
Attachment #582123 - Flags: review+
Attachment #582123 - Flags: checkin?
Comment on attachment 582123 [details] [diff] [review]
Bug 710987 - Remove duplicate conditional

https://hg.mozilla.org/integration/mozilla-inbound/rev/6fcec9ac1164
Attachment #582123 - Flags: checkin? → checkin+
https://hg.mozilla.org/mozilla-central/rev/6fcec9ac1164
Status: ASSIGNED → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla11
You need to log in before you can comment on or make changes to this bug.