710992 - Possible bad memset in pixman_image_set_transform()

Status: RESOLVED FIXED

(Core :: Graphics, defect)

Description

[Justin Dolske [:Dolske]]

From http://www.viva64.com/en/a/0078/,
13th section in http://www.viva64.com/external-pictures/txt/mozilla-test.txt

V575 The 'memcmp' function processes '0' elements. Inspect the third argument.
pixman-image.c 520

pixman_bool_t
pixman_image_set_transform (...)
{
  memcmp (common->transform, transform, sizeof (pixman_transform_t) == 0))
}

I think there could be written like this.
memcmp (common->transform, transform, sizeof (pixman_transform_t)) == 0)

Comment 1

[Thomas Prip Vestergaard [:prip]]

Attachment: Bug 710992 - Fix third argument in memcmp call in pixman-image.c

Comment 2

[Jared Wein [:jaws] (please needinfo? me)]

prip: When you are happy with the state of the patch, please request review from roc by setting the "review?" flag to "[e-mail]". Thanks for your contribution!

Comment 3

[Robert O'Callahan (:roc) (email my personal email if necessary)]

Comment on attachment 582133 [details] [diff] [review]
Bug 710992 - Fix third argument in memcmp call in pixman-image.c

Review of attachment 582133 [details] [diff] [review]:
-----------------------------------------------------------------

This is good. For landing, however, the patch needs to be prepped as a patch in gfx/cairo. See the README there for examples.

Also, this patch really needs to go upstream. Probably should post it to the cairo mailing list.

Comment 4

[Thomas Prip Vestergaard [:prip]]

Attachment: Bug 710992 - Fix third argument in memcmp call in pixman-image.c

Prepped as gfx/cairo-patch

Comment 5

[Robert O'Callahan (:roc) (email my personal email if necessary)]

Comment on attachment 582616 [details] [diff] [review]
Bug 710992 - Fix third argument in memcmp call in pixman-image.c

+bad-memset.patch: Fix third argument in memcmp call in pixman-image.c

This belongs under "pixman patches"

Comment 6

[Thomas Prip Vestergaard [:prip]]

Attachment: Bug 710992 - Fix third argument in memcmp call in pixman-image.c

Sorry - did not know that. Fixed now!

Comment 7

[Ed Morley [:emorley]]

In addition to the patch, doesn't the change also need to be made to the actual file?

Comment 8

[Robert O'Callahan (:roc) (email my personal email if necessary)]

Comment on attachment 582133 [details] [diff] [review]
Bug 710992 - Fix third argument in memcmp call in pixman-image.c

You're right, Ed. We can just land both of these patches.

Comment 9

[:Ms2ger (he/him; ⌚ UTC+1/+2)]

I'll land it.

Comment 10

[:Ms2ger (he/him; ⌚ UTC+1/+2)]

Thanks for the patch.

https://hg.mozilla.org/mozilla-central/rev/7d23dd6c50eb

Comment 11

[Søren Sandmann]

When you discover bugs in pixman, please report them upstream as well. 

Bug reports and patches can be sent to

       [e-mail]

or filed here:

       https://bugs.freedesktop.org/enter_bug.cgi?product=pixman