710996 - Possible double-assignment in JS_GetValidFrameCalleeObject()

Status: RESOLVED FIXED

(Core :: JavaScript Engine, defect)

Description

[Justin Dolske [:Dolske]]

From http://www.viva64.com/en/a/0078/,
20th section in http://www.viva64.com/external-pictures/txt/mozilla-test.txt

V519 The '* vp' variable is assigned values twice successively. Perhaps this is a mistake. Check lines: 711, 712.
jsdbgapi.cpp 712

JS_PUBLIC_API(JSBool)
JS_GetValidFrameCalleeObject(JSContext *cx, JSStackFrame *fp, jsval *vp)
{
    Value v;

    if (!Valueify(fp)->getValidCalleeObject(cx, &v))
        return false;
    *vp = v.isObject() ? v : JSVAL_VOID;
    *vp = v;
    return true;
}

Comment 1

[Felix Fung (:felix)]

Attachment: Double-assignment in JS_GetValidFrameCalleeObject()

Comment 2

[David Mandelin [:dmandelin]]

Comment on attachment 581905 [details] [diff] [review]
Double-assignment in JS_GetValidFrameCalleeObject()

Review of attachment 581905 [details] [diff] [review]:
-----------------------------------------------------------------

This one looks like an actual bug.

Comment 3

[Felix Fung (:felix)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/6388d336d451

Comment 4

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/6388d336d451