710997 - Possible double-assignment in PuppetWidget::DispatchPaintEvent()

Status: RESOLVED FIXED

(Core :: Widget, defect)

Description

[Justin Dolske [:Dolske]]

From http://www.viva64.com/en/a/0078/,
21st section in http://www.viva64.com/external-pictures/txt/mozilla-test.txt

V519 The 'event.refPoint.x' variable is assigned values twice successively. Perhaps this is a mistake. Check lines: 545, 546.
puppetwidget.cpp 546

nsresult
PuppetWidget::DispatchPaintEvent()
{
  ...
  event.refPoint.x = dirtyRect.x;
  event.refPoint.x = dirtyRect.y;
  ...
}

I think there could be written like this.
event.refPoint.y = dirtyRect.y;

Comment 1

[Pranav Ravichandran [:pranavrc]]

Attachment: Proposed patch

Comment 2

[Josh Matthews [:jdm]]

Comment on attachment 583428 [details] [diff] [review]
Proposed patch

Thanks Pranav!

Comment 3

[Josh Matthews [:jdm]]

Pranav, I'm going to check in this patch to the tree. In future, could you follow the directions at https://developer.mozilla.org/en/Mercurial_FAQ#How_can_I_generate_a_patch_for_somebody_else_to_check-in_for_me.3F which will make it easier for other people to check in you patches? Thanks in advance!

Comment 4

[Josh Matthews [:jdm]]

http://hg.mozilla.org/integration/mozilla-inbound/rev/15b9a0278499

Comment 5

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/15b9a0278499

Pranav congrats on your first patch in the tree! 

Hope to see you on IRC in #developers soon (see https://wiki.mozilla.org/IRC#Getting_Started for details). If you'd like to fix another bug (it would be awesome if you did!) but need some inspiration, pop on & say hi - and we'll find something for you :-)