Last Comment Bug 710997 - Possible double-assignment in PuppetWidget::DispatchPaintEvent()
: Possible double-assignment in PuppetWidget::DispatchPaintEvent()
[pvs-studio][good first bug][lang=c++...
Product: Core
Classification: Components
Component: Widget (show other bugs)
: unspecified
: All All
-- normal (vote)
: mozilla12
Assigned To: Pranav Ravichandran [:pranavrc]
Depends on:
Blocks: 710966
  Show dependency treegraph
Reported: 2011-12-14 23:56 PST by Justin Dolske [:Dolske]
Modified: 2012-02-01 13:57 PST (History)
4 users (show)
See Also:
Crash Signature:
QA Whiteboard:
Iteration: ---
Points: ---
Has Regression Range: ---
Has STR: ---

Proposed patch (778 bytes, patch)
2011-12-21 01:42 PST, Pranav Ravichandran [:pranavrc]
cjones.bugs: review+
Details | Diff | Splinter Review

Description User image Justin Dolske [:Dolske] 2011-12-14 23:56:03 PST
21st section in

V519 The 'event.refPoint.x' variable is assigned values twice successively. Perhaps this is a mistake. Check lines: 545, 546.
puppetwidget.cpp 546

  event.refPoint.x = dirtyRect.x;
  event.refPoint.x = dirtyRect.y;

I think there could be written like this.
event.refPoint.y = dirtyRect.y;
Comment 1 User image Pranav Ravichandran [:pranavrc] 2011-12-21 01:42:54 PST
Created attachment 583428 [details] [diff] [review]
Proposed patch
Comment 2 User image Josh Matthews [:jdm] 2011-12-21 10:29:56 PST
Comment on attachment 583428 [details] [diff] [review]
Proposed patch

Thanks Pranav!
Comment 3 User image Josh Matthews [:jdm] 2011-12-21 10:41:35 PST
Pranav, I'm going to check in this patch to the tree. In future, could you follow the directions at which will make it easier for other people to check in you patches? Thanks in advance!
Comment 5 User image Ed Morley [:emorley] 2011-12-22 03:53:29 PST

Pranav congrats on your first patch in the tree! 

Hope to see you on IRC in #developers soon (see for details). If you'd like to fix another bug (it would be awesome if you did!) but need some inspiration, pop on & say hi - and we'll find something for you :-)

Note You need to log in before you can comment on or make changes to this bug.