Closed Bug 71100 Opened 20 years ago Closed 20 years ago

cleanup in ParseSelector()

Categories

(Core :: CSS Parsing and Computation, defect)

defect
Not set
normal

Tracking

()

RESOLVED FIXED

People

(Reporter: glazou, Assigned: glazou)

References

Details

Attachments

(3 files)

The implementation of the new :not() pseudo-class (see bug 65133) requires
cleanup of nsCSSStyleRuleImpl::ParseSelector and fixing 65133 is high priority
for the composer team.

Marking also dependency of 65133 to current bug.

People receiving bug notification : please do not modify nsCSSParser.cpp
during the coming 48 hours w/o telling me before. Thanks a lot...
assigning to myself
Status: NEW → ASSIGNED
Blocks: selectors3
The changes look fine, but they are really hard to read as diffs (cvs completly
whacks the context). I do not like the aOutValue argument to the
ParseXXXSelector because I'm not sure what it is suppossed to mean. You have a
return value and an aOutValue - please at least document what it means, or give
it a more significant name. That is minor, sr=attinasi anyway.
I'm nosy (sorry).  AFAICT, aOutValue is a waste of cycles and code space.  It's
something that I wouldn't want others to imitate in code on cvs.mozilla.org, so
I'm here to back up (and emphasize) Marc's comment.

/be
I notice the outliner pseudo parsing code has moved.  I assume the logic was all
kept the same?
nothing related to -moz-outliner-* was changed ; the logic is the same, the
code is the same.
I agree myself with Marc and Brendan... Changing my code.
checked in (r=peterl, sr=attinasi)
Status: ASSIGNED → RESOLVED
Closed: 20 years ago
Resolution: --- → FIXED
Comment on attachment 27167 [details] [diff] [review]
new and cleaner version of the patch ; saves some cycles

>+        if (!ParseOutlinerPseudoElement(aErrorCode, aSelector))
>+          aParsingStatus = SELECTOR_PARSING_STOPPED_ERROR;
>+          return;

Just for the record, Oops!  bz is fixing this as part of bug 62843.
You need to log in before you can comment on or make changes to this bug.