Closed Bug 711034 Opened 8 years ago Closed 8 years ago

Native Fennec is still creating places.sqlite

Categories

(Firefox for Android :: General, defect)

x86_64
Android
defect
Not set

Tracking

()

RESOLVED FIXED

People

(Reporter: gcp, Assigned: gcp)

References

Details

Attachments

(1 file)

Native Fennec is supposed to use the Android DB or a local DB, but in fact the places.sqlite file is still created and the cache is eating up 0.5MB RAM.
Assignee: nobody → gpascutto
Depends on: 702037
Database::Init() should bail out, so I don't see how's that possible since should be the only code path initing the database.
As far as I can see, it's because configure.in doesn't contain what's needed to make MOZ_ANDROID_HISTORY actually take effect. Fixed that, seems to be OK now.

I also tried to build without MOZ_PLACES, but, well, I guess bug 702037 already explains that doesn't work.
Blocks: 699199
(In reply to Gian-Carlo Pascutto (:gcp) from comment #2)
> I also tried to build without MOZ_PLACES, but, well, I guess bug 702037
> already explains that doesn't work.

Can't work since Android history should be in its own component for that to work, as I said there.
Btw, thanks for fixing those missing bits.
Comment on attachment 582007 [details] [diff] [review]
Patch 1. Make MOZ_ANDROID_HISTORY actually work

Review of attachment 582007 [details] [diff] [review]:
-----------------------------------------------------------------

missed this, i guess, when we merged birch over.
Attachment #582007 - Flags: review?(doug.turner) → review+
I'm now seeing:

I/Gecko   (23085): ###!!! ASSERTION: nsAndroidHistory not thread-safe: '_mOwningThread.GetThread() == PR_GetCurrentThread()', file /home/morbo/hg/mozilla-central/toolkit/components/places/nsAndroidHistory.cpp, line 44
I/Gecko   (23085): ###!!! ASSERTION: nsAndroidHistory not thread-safe: '_mOwningThread.GetThread() == PR_GetCurrentThread()', file /home/morbo/hg/mozilla-central/toolkit/components/places/nsAndroidHistory.cpp, line 44

I don't know the source - our Java code seems to be calling it properly on the Gecko thread.
https://hg.mozilla.org/mozilla-central/rev/1bb4179d747e
Status: NEW → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.