71106 - [XUL Syntax] Change DOM "create" and "destroy" popup events and add new shown/hidden popup events

Status: RESOLVED FIXED

(Core :: XUL, defect)

Description

[David Hyatt]

The events for menu opening and closing are too generically named.  They should
be renamed to popupShowing and popupHiding.

While I'm in here, the nsIDOMMenuLIstener file should be renamed to
nsIDOMXULListener, and the associated event names should be cleaned up
as well.

Comment 1

[Ben Goodger (use ben at mozilla dot org for email)]

What's the rationale behind the change in name of the latter entity? You're 
going from "Menu" (very specific) to "XUL" (very general).

Comment 2

[David Hyatt]

The menu listener contains all the XUL events. :)  Go look at nsIDOMMenuListener.

Comment 3

[David Hyatt]

This is a compliance issue for popups.  Two new DOM events must also be 
added.  This bug will cover both issues.

Comment 4

[David Hyatt]

Attachment: Patch to add events, change names of other events, and patch the XUL and XBL.

Comment 5

[jag (Peter Annema)]

r=jag

Comment 6

[Johnny Stenback (:jst)]

Any reason to not make nsIDOMXULListener scriptable? And since it's named
nsIDOMXUL... it should be moved into dom/public/idl/xul (if it's converted into
XPIDL).

Nits of the day, bad indentation at:

+nsresult nsXBLXULHandler::PopupShown(nsIDOMEvent* aEvent)
 {
-  if (!mProtoHandler)
+ if (!mProtoHandler)
     return NS_ERROR_FAILURE;


Same problem in nsXBLXULHandler::PopupHiding, nsXBLXULHandler::PopupHidden.
Other than that, sr=jst

Comment 7

[David Hyatt]

All of the DOM event listeners are grouped under coreEvents.  None of them are
scriptable.  If we want to fix that, IMO, we should just do it for all the
listeners at the same time, but it doesn't really matter, since you'd never use
these classes in JS (you'd just hook up the functions using addEventListener).  

I also think the file is in the right place, since it is an event listener, and
all other event listener files are in that directory.

Comment 8

[David Hyatt]

Fixed.