711096 - No Form Autocomplete Suggestions pop-up is shown on identical result

Status: RESOLVED WONTFIX

(Firefox for Android Graveyard :: General, defect, P2)

Description

[Martijn Wargers (dead)]

https://litmus.mozilla.org/show_test.cgi?id=26563 is failing currently.
The question is, what behavior do we want to have.

The text in the patch from bug 695444 seems to suggest, current behavior is what is wanted.
+        // Do not show the value if it is the current one in the input field
In that case, the litmus test needs to be rewritten.

Steps to reproduce:
- Go to bugzilla.mozilla.org
- Tap on the search field
- Enter a 'mozillatest' and press Enter
- On the resulting page, tap on the search field

Expected result:
Form Autocomplete Suggestions pop-up should come up and show 'mozillatest'.

Actual result:
No Form Autocomplete Suggestions pop-up is shown at all.

Note bug 262206, Firefox on Desktop does show the idental result form autocomplete suggestions pop-up.
I personally prefer the behavior on mobile, but it might be good to be consistent on mobile an desktop if possible.

Comment 2

[:Margaret Leibovic]

(In reply to Martijn Wargers [:mw22] (QA - IRC nick: mw22) from comment #0)

> Note bug 262206, Firefox on Desktop does show the idental result form
> autocomplete suggestions pop-up.
> I personally prefer the behavior on mobile, but it might be good to be
> consistent on mobile an desktop if possible.

I just copied what was done in XUL fennec [1], but I agree that we should probably be consistent with desktop (as well as with most autocomplete popups I've seen on the web).

[1] http://mxr.mozilla.org/mozilla-central/source/mobile/xul/chrome/content/common-ui.js#823

Comment 3

[:Margaret Leibovic]

Actually, looking at the hg blame, this behavior was added to fix bug 636858, so maybe we want to keep it?

Finkle, what do you think?

Comment 4

[Mark Finkle (:mfinkle) (use needinfo?)]

When we may want to differ from desktop, we bring in the UX guys to make the call.

I can see why we may not want to show the popup result for "foo" when "foo" is in the editbox. It kinda makes me think the autocomplete is confused. I don't have strong feelings one way or the other.

Madhava, Ian & Patryk: Any thoughts?

Comment 5

[:Margaret Leibovic]

Attachment: patch

On IRC Madhava told me that he has no strong opinion either way, and concluded:
[06 15:09:23] <madhava> well, with no other particular considerations, we might as well do the same as desktop

So, that's what this patch does.

Comment 6

[Alex Limi (:limi) — Firefox UX Team]

I'd say that it's actually desktop that is confused in this case — if the value is already in the input box, I don't see why we would show it in the autocomplete. Maybe it's because it lets you delete an exact entry? (if so, that's a pretty narrow edge case, IMO)

Comment 7

[:Margaret Leibovic]

Okay, now after talking to Limi, he thinks we should change the desktop behavior to make it match what we're doing on mobile, so I filed bug 716117 about that.

Martijn, can you make sure the litmus test gets updated?