Closed Bug 711125 Opened 9 years ago Closed 9 years ago

Make the debugger client's setBreakpoint pause the debuggee automatically

Categories

(DevTools :: Debugger, defect, P2)

defect

Tracking

(Not tracked)

RESOLVED FIXED
Firefox 13

People

(Reporter: past, Assigned: past)

References

Details

Attachments

(1 file, 3 obsolete files)

Currently calling TC_setBreakpoint returns an error if the debuggee is running. It would be better for clients to make setBreakpoint interrupt the debuggee in such cases, set the breakpoint and resume.
Attached patch WIP (obsolete) — Splinter Review
This is still work in progress.
Attached patch Working patch (obsolete) — Splinter Review
I was stuck making the test work, until I realised that it uncovered a bug in the client request dispatcher. It now no longer confuses unsolicited notifications from the server as responses to active client requests. The unit test catches this, as well as any issues in the basic interrupt-then-breakpoint functionality.
Attachment #582312 - Attachment is obsolete: true
Attachment #582846 - Flags: review?(dcamp)
Attachment #582846 - Flags: review?(dcamp) → review+
This is ready to land after its dependencies are reviewed.
Priority: -- → P2
No longer blocks: 707987
Attached patch Working patch v2 (obsolete) — Splinter Review
Rebased on top of latest changes during super review.
Attachment #582846 - Attachment is obsolete: true
Status: NEW → ASSIGNED
Updated patch metadata.
Attachment #590654 - Attachment is obsolete: true
Attachment #595698 - Flags: review+
Attachment #595698 - Attachment description: Working patch v2.1 → [in-fx-team] Working patch v2.1
https://hg.mozilla.org/integration/fx-team/rev/9d7cb5d5b085
Whiteboard: [land-in-fx-team] → [fixed-in-fx-team]
https://hg.mozilla.org/mozilla-central/rev/9d7cb5d5b085
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Whiteboard: [fixed-in-fx-team]
Target Milestone: --- → Firefox 13
Product: Firefox → DevTools
You need to log in before you can comment on or make changes to this bug.