Closed
Bug 711125
Opened 13 years ago
Closed 13 years ago
Make the debugger client's setBreakpoint pause the debuggee automatically
Categories
(DevTools :: Debugger, defect, P2)
DevTools
Debugger
Tracking
(Not tracked)
RESOLVED
FIXED
Firefox 13
People
(Reporter: past, Assigned: past)
References
Details
Attachments
(1 file, 3 obsolete files)
8.71 KB,
patch
|
past
:
review+
|
Details | Diff | Splinter Review |
Currently calling TC_setBreakpoint returns an error if the debuggee is running. It would be better for clients to make setBreakpoint interrupt the debuggee in such cases, set the breakpoint and resume.
Assignee | ||
Comment 2•13 years ago
|
||
I was stuck making the test work, until I realised that it uncovered a bug in the client request dispatcher. It now no longer confuses unsolicited notifications from the server as responses to active client requests. The unit test catches this, as well as any issues in the basic interrupt-then-breakpoint functionality.
Attachment #582312 -
Attachment is obsolete: true
Attachment #582846 -
Flags: review?(dcamp)
Updated•13 years ago
|
Attachment #582846 -
Flags: review?(dcamp) → review+
Assignee | ||
Comment 3•13 years ago
|
||
This is ready to land after its dependencies are reviewed.
Priority: -- → P2
Assignee | ||
Comment 4•13 years ago
|
||
Rebased on top of latest changes during super review.
Attachment #582846 -
Attachment is obsolete: true
Assignee | ||
Updated•13 years ago
|
Status: NEW → ASSIGNED
Assignee | ||
Comment 5•13 years ago
|
||
Try run: https://tbpl.mozilla.org/?tree=Try&rev=e808fa2475c6
Whiteboard: [land-in-fx-team]
Assignee | ||
Comment 6•13 years ago
|
||
Updated patch metadata.
Attachment #590654 -
Attachment is obsolete: true
Attachment #595698 -
Flags: review+
Assignee | ||
Updated•13 years ago
|
Attachment #595698 -
Attachment description: Working patch v2.1 → [in-fx-team] Working patch v2.1
Assignee | ||
Comment 7•13 years ago
|
||
https://hg.mozilla.org/integration/fx-team/rev/9d7cb5d5b085
Whiteboard: [land-in-fx-team] → [fixed-in-fx-team]
Comment 8•13 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/9d7cb5d5b085
Status: ASSIGNED → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
Whiteboard: [fixed-in-fx-team]
Target Milestone: --- → Firefox 13
Updated•6 years ago
|
Product: Firefox → DevTools
You need to log in
before you can comment on or make changes to this bug.
Description
•