Currently calling TC_setBreakpoint returns an error if the debuggee is running. It would be better for clients to make setBreakpoint interrupt the debuggee in such cases, set the breakpoint and resume.
Created attachment 582846 [details] [diff] [review] Working patch I was stuck making the test work, until I realised that it uncovered a bug in the client request dispatcher. It now no longer confuses unsolicited notifications from the server as responses to active client requests. The unit test catches this, as well as any issues in the basic interrupt-then-breakpoint functionality.
This is ready to land after its dependencies are reviewed.
Priority: -- → P2
Created attachment 590654 [details] [diff] [review] Working patch v2 Rebased on top of latest changes during super review.
Attachment #582846 - Attachment is obsolete: true
Status: NEW → ASSIGNED
Created attachment 595698 [details] [diff] [review] [in-fx-team] Working patch v2.1 Updated patch metadata.
Attachment #595698 - Attachment description: Working patch v2.1 → [in-fx-team] Working patch v2.1
Whiteboard: [land-in-fx-team] → [fixed-in-fx-team]
Status: ASSIGNED → RESOLVED
Last Resolved: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 13
You need to log in before you can comment on or make changes to this bug.