Make the debugger client's setBreakpoint pause the debuggee automatically

RESOLVED FIXED in Firefox 13

Status

()

Firefox
Developer Tools: Debugger
P2
normal
RESOLVED FIXED
6 years ago
5 years ago

People

(Reporter: past, Assigned: past)

Tracking

Trunk
Firefox 13
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment, 3 obsolete attachments)

Currently calling TC_setBreakpoint returns an error if the debuggee is running. It would be better for clients to make setBreakpoint interrupt the debuggee in such cases, set the breakpoint and resume.
Created attachment 582312 [details] [diff] [review]
WIP

This is still work in progress.
Created attachment 582846 [details] [diff] [review]
Working patch

I was stuck making the test work, until I realised that it uncovered a bug in the client request dispatcher. It now no longer confuses unsolicited notifications from the server as responses to active client requests. The unit test catches this, as well as any issues in the basic interrupt-then-breakpoint functionality.
Attachment #582312 - Attachment is obsolete: true
Attachment #582846 - Flags: review?(dcamp)

Updated

6 years ago
Attachment #582846 - Flags: review?(dcamp) → review+
This is ready to land after its dependencies are reviewed.
Priority: -- → P2
Blocks: 719122
Blocks: 707987

Updated

5 years ago
No longer blocks: 707987
Created attachment 590654 [details] [diff] [review]
Working patch v2

Rebased on top of latest changes during super review.
Attachment #582846 - Attachment is obsolete: true
Status: NEW → ASSIGNED
Try run:

https://tbpl.mozilla.org/?tree=Try&rev=e808fa2475c6
Whiteboard: [land-in-fx-team]
Created attachment 595698 [details] [diff] [review]
[in-fx-team] Working patch v2.1

Updated patch metadata.
Attachment #590654 - Attachment is obsolete: true
Attachment #595698 - Flags: review+
Attachment #595698 - Attachment description: Working patch v2.1 → [in-fx-team] Working patch v2.1
https://hg.mozilla.org/integration/fx-team/rev/9d7cb5d5b085
Whiteboard: [land-in-fx-team] → [fixed-in-fx-team]
https://hg.mozilla.org/mozilla-central/rev/9d7cb5d5b085
Status: ASSIGNED → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
Whiteboard: [fixed-in-fx-team]
Target Milestone: --- → Firefox 13
You need to log in before you can comment on or make changes to this bug.