711125 - Make the debugger client's setBreakpoint pause the debuggee automatically

Status: RESOLVED FIXED

(DevTools :: Debugger, defect, P2)

Description

[Panos Astithas (he/him) [:past] (please ni?)]

Currently calling TC_setBreakpoint returns an error if the debuggee is running. It would be better for clients to make setBreakpoint interrupt the debuggee in such cases, set the breakpoint and resume.

Comment 1

[Panos Astithas (he/him) [:past] (please ni?)]

Attachment: WIP

This is still work in progress.

Comment 2

[Panos Astithas (he/him) [:past] (please ni?)]

Attachment: Working patch

I was stuck making the test work, until I realised that it uncovered a bug in the client request dispatcher. It now no longer confuses unsolicited notifications from the server as responses to active client requests. The unit test catches this, as well as any issues in the basic interrupt-then-breakpoint functionality.

Comment 3

[Panos Astithas (he/him) [:past] (please ni?)]

This is ready to land after its dependencies are reviewed.

Comment 4

[Panos Astithas (he/him) [:past] (please ni?)]

Attachment: Working patch v2

Rebased on top of latest changes during super review.

Comment 5

[Panos Astithas (he/him) [:past] (please ni?)]

Try run:

https://tbpl.mozilla.org/?tree=Try&rev=e808fa2475c6

Comment 6

[Panos Astithas (he/him) [:past] (please ni?)]

Attachment: [in-fx-team] Working patch v2.1

Updated patch metadata.

Comment 7

[Panos Astithas (he/him) [:past] (please ni?)]

https://hg.mozilla.org/integration/fx-team/rev/9d7cb5d5b085

Comment 8

[Tim Taubert [:ttaubert] (inactive)]

https://hg.mozilla.org/mozilla-central/rev/9d7cb5d5b085