711136 - thumbnails on about:home are really poor quality

Status: VERIFIED FIXED

(Firefox for Android Graveyard :: General, defect, P1)

Description

[Dietrich Ayala (:dietrich)]

they are super pixelated and grody looking.

Comment 1

[Dietrich Ayala (:dietrich)]

going to zimbra shows this off quite well.

Comment 2

[Mark Finkle (:mfinkle) (use needinfo?)]

I think we can just bump up the size of the saved thumbnails a little bit. We are saving them as 96x96 pixel. I see that the ICS browser code uses 240x160

Comment 3

[Brad Lassey [:blassey] (use needinfo?)]

Attachment: patch

Comment 4

[Brad Lassey [:blassey] (use needinfo?)]

Attachment: screen shot

Comment 5

[Mark Finkle (:mfinkle) (use needinfo?)]

Comment on attachment 587614 [details] [diff] [review]
patch

r+, but lets use 240x160 for the dimensions

Comment 6

[Matt Brubeck (:mbrubeck)]

https://hg.mozilla.org/mozilla-central/rev/ba96b6a034c2

Comment 7

[Steffen Wilberg]

(In reply to Matt Brubeck (:mbrubeck) from comment #6)
> https://hg.mozilla.org/mozilla-central/rev/ba96b6a034c2
That still specifies 120x80 !?

Comment 8

[Mark Finkle (:mfinkle) (use needinfo?)]

(In reply to Steffen Wilberg from comment #7)
> (In reply to Matt Brubeck (:mbrubeck) from comment #6)
> > https://hg.mozilla.org/mozilla-central/rev/ba96b6a034c2
> That still specifies 120x80 !?

That is the mdpi values. The patch is scaling those based on the DPI, so on ICS where the DPI scale is 2, we are at 240x160.

Comment 9

[Brad Lassey [:blassey] (use needinfo?)]

Comment on attachment 587614 [details] [diff] [review]
patch

[Approval Request Comment]
Regression caused by (bug #): 
User impact if declined: 
unreadable, unrecognizable  thumbnails
Testing completed (on m-c, etc.): 
Risk to taking this patch (and alternatives if risky):
using more memory in the DB to store the thumbnails

Comment 10

[Brad Lassey [:blassey] (use needinfo?)]

https://hg.mozilla.org/releases/mozilla-aurora/rev/c8c9d0727e27

Comment 11

[Catalin Suciu [:csuciu]]

Verified fixed on Nightly 12.0a1 (2012-01-31)
                  Aurora  11.0a2 (2012-01-31)
Device:Samsung Galaxy S2 (Android 2.3.4)