Closed Bug 711147 Opened 14 years ago Closed 12 years ago

content loader contentScriptFile should accept URL instance

Categories

(Add-on SDK Graveyard :: General, enhancement, P3)

Product:
Add-on SDK Graveyard
Component:
General
Type:
enhancement

Tracking

(Not tracked)

Status:
RESOLVED FIXED
Milestone:
mozilla28

People

(Reporter: erikvvold, Assigned: zombie)

Details

(Whiteboard: [good first bug])

Attachments

(1 file)

link to pr 1292
46 bytes, text/x-github-pull-request
jsantell
: review+
Details | Review
'contentScriptFile' constructor property for Loader in packages/api-utils/lib/content/loader.js does not accept a URL instance from require('url'), and it should. I ran in to this while exploring the idea of returning a URL from self.data.url in bug 707745.
Assignee: nobody → erikvvold
Severity: normal → enhancement
Status: NEW → ASSIGNED
Priority: -- → P5
Taking myself off things that I won't be able to get to for awhile.
Assignee: erikvvold → nobody
Whiteboard: [good first bug]
Assignee: nobody → tomica+amo
Attached file link to pr 1292 —
Attachment #832689 - Flags: review?(jsantell)
Commits pushed to master at https://github.com/mozilla/addon-sdk https://github.com/mozilla/addon-sdk/commit/34bccd4b0b564ada9087b598394166f7a5ba8690 bug 711147 - contentScriptFile now accepts URLs and some new tests to ensure that.. bug 711147 - contentScriptFile as URL worker test https://github.com/mozilla/addon-sdk/commit/ff9fec575a1f32301e38fc61111c0ab776df004d Merge pull request #1292 from zombie/711147-content-loader-url Fix bug 711147 - contentScriptFile now accepts URLs, r=@jsantell
Status: ASSIGNED → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Attachment #832689 - Flags: review?(jsantell) → review+
Target Milestone: --- → mozilla28
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: