Closed Bug 711185 Opened 12 years ago Closed 12 years ago

Form autocomplete popup can be larger than amount of entries visible

Categories

(Firefox for Android Graveyard :: General, defect, P3)

ARM
Android
defect

Tracking

(firefox11 verified, firefox12 verified, firefox13 verified, fennec11+)

VERIFIED FIXED
Firefox 13
Tracking Status
firefox11 --- verified
firefox12 --- verified
firefox13 --- verified
fennec 11+ ---

People

(Reporter: martijn.martijn, Assigned: sriram)

References

()

Details

(Keywords: testcase, uiwanted)

Attachments

(2 files)

Attached image Screenshot
- Go to http://people.mozilla.org/~mwargers/tests/autocomplete_forms/textinput_form.html
- Tap on the input, type 'abc' and submit the form
- Tap on the input again
- Type 'a' -> form autocomplete popup appears with 'abc' in it


Expected result:
- Form autocomplete popup is just as high as the amount of entries in the autocomplete popup (1 for me)

Actual result:
- Form autocomplete popup is larger that the one entry that is visible
Also, I think the form autocomplete popup should get larger if there for example 10 autocomplete entries. It shouldn't stay fixed to the size of 3.5 entries, as it is now.
Assignee: nobody → margaret.leibovic
Priority: -- → P3
Handing this off to Sriram, since he worked on the Android widget part of this popup.
Assignee: margaret.leibovic → sriram
tracking-fennec: --- → 11+
It was decided to have a space of 3 items always. Adding :ibarlow to comment on the same.
Keywords: uiwanted
Hey guys, I actually can't remember if we set a specific rule like that or not. 

I think the desired behaviour is that the menu *should* resize to fit more or less content, with a minimum height of 1 row, and a maximum height of whatever will fit without going underneath the keyboard.
Attached patch WIPSplinter Review
This works fine as expected. The height takes either the minimum height as per the rows in it or the available space to show it. I am sorry about the comments added there, but couldn't find a better way to present the comments :D

UX team doesnt want the autocompletelist to switch between being above and below while typing - depending on the space available. However, getting this working that way is a bit hard. We would have to store the direction where it was shown.

http://cl.ly/2d41230R2O2o140h0331 and http://cl.ly/2n17220c040N2S1v381t - this is just an edge case as the textbox wouldn't always be this low to not have space below it.

If the implementation is fine and the UX team is fine with it, this WIP works well.
Attachment #593955 - Flags: review?(mark.finkle)
Attachment #593955 - Flags: review?(mark.finkle) → review+
https://hg.mozilla.org/mozilla-central/rev/132b4bbf6e61
Status: NEW → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 13
Comment on attachment 593955 [details] [diff] [review]
WIP

[Approval Request Comment]
User impact if declined: 
The list will show a default size irrespective of the number of list items. Poor UI.

Testing completed (on m-c, etc.): Landed on m-c on 02/03

Risk to taking this patch (and alternatives if risky):
No risk. Only resizing based on the number of entries is done.

String changes made by this patch: None.
Attachment #593955 - Flags: approval-mozilla-beta?
Comment on attachment 593955 [details] [diff] [review]
WIP

[Triage Comment]
Approved for beta

(is this already in aurora?)
Attachment #593955 - Flags: approval-mozilla-beta? → approval-mozilla-beta+
Verified fixed on: 

Nightly 13.0a1 (2012-02-09)
Aurora 12.0a2 (2012-02-09)
Beta 11.0 (2012-02-08)(20120208140504 - http://hg.mozilla.org/releases/mozilla-beta/rev/eab0f523de86)
Device: Samsung Google Nexus S - Android 2.3.6
Product: Firefox for Android → Firefox for Android Graveyard
You need to log in before you can comment on or make changes to this bug.