Closed Bug 711199 Opened 8 years ago Closed 8 years ago

Replace menu icon images

Categories

(Firefox for Android :: General, defect, P4)

ARM
Android
defect

Tracking

()

VERIFIED FIXED
Firefox 12
Tracking Status
firefox11 --- fixed
firefox12 --- verified

People

(Reporter: ibarlow, Assigned: mbrubeck)

Details

(Whiteboard: [has patch])

Attachments

(2 files)

Attached file menu icons
Please replace the current bottom menu icons in GB / Froyo phones with these new and more visually consistent ones. Thanks!
OS: Mac OS X → Android
Hardware: x86 → ARM
Priority: -- → P4
Assignee: nobody → mbrubeck
Attached patch patchSplinter Review
Since the new icons are for both Froyo (v8) and Gingerbread (v9), we no longer need separate icon files for v9.
Attachment #587756 - Flags: review?(lucasr.at.mozilla)
Status: NEW → ASSIGNED
Whiteboard: [has patch]
Comment on attachment 587756 [details] [diff] [review]
patch

Review of attachment 587756 [details] [diff] [review]:
-----------------------------------------------------------------

The new icons work fine on both white and black backgrounds, right?
Attachment #587756 - Flags: review?(lucasr.at.mozilla) → review+
http://hg.mozilla.org/integration/mozilla-inbound/rev/c75c08fdf2c3

(In reply to Lucas Rocha (:lucasr) from comment #2)
> The new icons work fine on both white and black backgrounds, right?

Yes.
Target Milestone: --- → Firefox 12
Comment on attachment 587756 [details] [diff] [review]
patch

[Approval Request Comment]
Android-only, image-only patch that just provides some theme polish.
Attachment #587756 - Flags: approval-mozilla-aurora?
https://hg.mozilla.org/mozilla-central/rev/c75c08fdf2c3
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Verified on Nightly (12.0a1)
Samsung Nexus S (Android 4.0.3)
20120113052739
http://hg.mozilla.org/mozilla-central/rev/790cd9bba7f5
Status: RESOLVED → VERIFIED
^ Whoops, above was tested on Galaxy SII (Android 2.3.4) Gingerbread
Comment on attachment 587756 [details] [diff] [review]
patch

[Triage Comment]
Mobile only - approved for Aurora.
Attachment #587756 - Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
You need to log in before you can comment on or make changes to this bug.