Replace menu icon images

VERIFIED FIXED in Firefox 11

Status

()

Firefox for Android
General
P4
normal
VERIFIED FIXED
5 years ago
9 months ago

People

(Reporter: ibarlow, Assigned: mbrubeck)

Tracking

unspecified
Firefox 12
ARM
Android
Points:
---

Firefox Tracking Flags

(firefox11 fixed, firefox12 verified)

Details

(Whiteboard: [has patch])

Attachments

(2 attachments)

(Reporter)

Description

5 years ago
Created attachment 582052 [details]
menu icons

Please replace the current bottom menu icons in GB / Froyo phones with these new and more visually consistent ones. Thanks!

Updated

5 years ago
OS: Mac OS X → Android
Hardware: x86 → ARM
Priority: -- → P4
Assignee: nobody → mbrubeck
(Assignee)

Comment 1

5 years ago
Created attachment 587756 [details] [diff] [review]
patch

Since the new icons are for both Froyo (v8) and Gingerbread (v9), we no longer need separate icon files for v9.
Attachment #587756 - Flags: review?(lucasr.at.mozilla)
(Assignee)

Updated

5 years ago
Status: NEW → ASSIGNED
Whiteboard: [has patch]
Comment on attachment 587756 [details] [diff] [review]
patch

Review of attachment 587756 [details] [diff] [review]:
-----------------------------------------------------------------

The new icons work fine on both white and black backgrounds, right?
Attachment #587756 - Flags: review?(lucasr.at.mozilla) → review+
(Assignee)

Comment 3

5 years ago
http://hg.mozilla.org/integration/mozilla-inbound/rev/c75c08fdf2c3

(In reply to Lucas Rocha (:lucasr) from comment #2)
> The new icons work fine on both white and black backgrounds, right?

Yes.
Target Milestone: --- → Firefox 12
(Assignee)

Comment 4

5 years ago
Comment on attachment 587756 [details] [diff] [review]
patch

[Approval Request Comment]
Android-only, image-only patch that just provides some theme polish.
Attachment #587756 - Flags: approval-mozilla-aurora?
https://hg.mozilla.org/mozilla-central/rev/c75c08fdf2c3
Status: ASSIGNED → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
Verified on Nightly (12.0a1)
Samsung Nexus S (Android 4.0.3)
20120113052739
http://hg.mozilla.org/mozilla-central/rev/790cd9bba7f5
Status: RESOLVED → VERIFIED
status-firefox11: --- → affected
status-firefox12: --- → verified
^ Whoops, above was tested on Galaxy SII (Android 2.3.4) Gingerbread

Comment 8

5 years ago
Comment on attachment 587756 [details] [diff] [review]
patch

[Triage Comment]
Mobile only - approved for Aurora.
Attachment #587756 - Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
(Assignee)

Comment 9

5 years ago
https://hg.mozilla.org/releases/mozilla-aurora/rev/b9b826d27871
status-firefox11: affected → fixed
You need to log in before you can comment on or make changes to this bug.