Closed Bug 711266 Opened 8 years ago Closed 8 years ago

GC: JSRope::flatten should call post barriers unconditionally

Categories

(Core :: JavaScript Engine, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
mozilla11

People

(Reporter: terrence, Assigned: terrence)

References

Details

Attachments

(1 file)

For incremental barriers we check if compartment()->needsBarrier to defer the cost when we are not in a GC cycle.  We cannot do this for cross-generation barriers.  We need to remove the checks on the post barriers and rename the enum to something  more specific.
The changes to flatten are straightforward.  I do not think we need pre barriers on init, but do let me know if I am mistaken here.
Attachment #582152 - Flags: review?(wmccloskey)
Attachment #582152 - Flags: review?(wmccloskey) → review+
https://hg.mozilla.org/mozilla-central/rev/aa1c4b29d4e4
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla11
You need to log in before you can comment on or make changes to this bug.