The default bug view has changed. See this FAQ.

GC: JSRope::flatten should call post barriers unconditionally

RESOLVED FIXED in mozilla11

Status

()

Core
JavaScript Engine
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: terrence, Assigned: terrence)

Tracking

Trunk
mozilla11
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Assignee)

Description

5 years ago
For incremental barriers we check if compartment()->needsBarrier to defer the cost when we are not in a GC cycle.  We cannot do this for cross-generation barriers.  We need to remove the checks on the post barriers and rename the enum to something  more specific.
(Assignee)

Comment 1

5 years ago
Created attachment 582152 [details] [diff] [review]
v1: more post barriers on base

The changes to flatten are straightforward.  I do not think we need pre barriers on init, but do let me know if I am mistaken here.
Attachment #582152 - Flags: review?(wmccloskey)
Attachment #582152 - Flags: review?(wmccloskey) → review+
(Assignee)

Comment 2

5 years ago
https://hg.mozilla.org/integration/mozilla-inbound/rev/aa1c4b29d4e4
https://hg.mozilla.org/mozilla-central/rev/aa1c4b29d4e4
Status: ASSIGNED → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla11
You need to log in before you can comment on or make changes to this bug.