711266 - GC: JSRope::flatten should call post barriers unconditionally

Status: RESOLVED FIXED

(Core :: JavaScript Engine, defect)

Description

[Terrence Cole [:terrence]]

For incremental barriers we check if compartment()->needsBarrier to defer the cost when we are not in a GC cycle.  We cannot do this for cross-generation barriers.  We need to remove the checks on the post barriers and rename the enum to something  more specific.

Comment 1

[Terrence Cole [:terrence]]

Attachment: v1: more post barriers on base

The changes to flatten are straightforward.  I do not think we need pre barriers on init, but do let me know if I am mistaken here.

Comment 2

[Terrence Cole [:terrence]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/aa1c4b29d4e4

Comment 3

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/aa1c4b29d4e4