Last Comment Bug 711266 - GC: JSRope::flatten should call post barriers unconditionally
: GC: JSRope::flatten should call post barriers unconditionally
Status: RESOLVED FIXED
:
Product: Core
Classification: Components
Component: JavaScript Engine (show other bugs)
: Trunk
: All All
: -- normal (vote)
: mozilla11
Assigned To: Terrence Cole [:terrence]
:
: Jason Orendorff [:jorendorff]
Mentors:
Depends on:
Blocks: 673454
  Show dependency treegraph
 
Reported: 2011-12-15 15:40 PST by Terrence Cole [:terrence]
Modified: 2011-12-16 05:57 PST (History)
1 user (show)
See Also:
Crash Signature:
(edit)
QA Whiteboard:
Iteration: ---
Points: ---
Has Regression Range: ---
Has STR: ---


Attachments
v1: more post barriers on base (5.58 KB, patch)
2011-12-15 17:18 PST, Terrence Cole [:terrence]
wmccloskey: review+
Details | Diff | Splinter Review

Description Terrence Cole [:terrence] 2011-12-15 15:40:31 PST
For incremental barriers we check if compartment()->needsBarrier to defer the cost when we are not in a GC cycle.  We cannot do this for cross-generation barriers.  We need to remove the checks on the post barriers and rename the enum to something  more specific.
Comment 1 Terrence Cole [:terrence] 2011-12-15 17:18:33 PST
Created attachment 582152 [details] [diff] [review]
v1: more post barriers on base

The changes to flatten are straightforward.  I do not think we need pre barriers on init, but do let me know if I am mistaken here.
Comment 2 Terrence Cole [:terrence] 2011-12-15 17:39:58 PST
https://hg.mozilla.org/integration/mozilla-inbound/rev/aa1c4b29d4e4
Comment 3 Ed Morley [:emorley] 2011-12-16 05:57:25 PST
https://hg.mozilla.org/mozilla-central/rev/aa1c4b29d4e4

Note You need to log in before you can comment on or make changes to this bug.