Last Comment Bug 711273 - rm cruft: JS_REQUIRES_STACK, find-child.py, jsstack.js, fallibility of PutBlockObject/UnwindScope
: rm cruft: JS_REQUIRES_STACK, find-child.py, jsstack.js, fallibility of PutBlo...
Status: RESOLVED FIXED
:
Product: Core
Classification: Components
Component: JavaScript Engine (show other bugs)
: unspecified
: All All
: -- normal (vote)
: mozilla12
Assigned To: Luke Wagner [:luke]
:
Mentors:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2011-12-15 15:53 PST by Luke Wagner [:luke]
Modified: 2012-01-03 03:46 PST (History)
4 users (show)
See Also:
Crash Signature:
(edit)
QA Whiteboard:
Iteration: ---
Points: ---
Has Regression Range: ---
Has STR: ---


Attachments
rm cruft (50.78 KB, patch)
2011-12-15 15:53 PST, Luke Wagner [:luke]
no flags Details | Diff | Review
rm cruft 2 (52.10 KB, patch)
2011-12-15 18:14 PST, Luke Wagner [:luke]
no flags Details | Diff | Review
rm cruft 3 (52.19 KB, patch)
2011-12-15 18:17 PST, Luke Wagner [:luke]
jwalden+bmo: review+
Details | Diff | Review

Description Luke Wagner [:luke] 2011-12-15 15:53:52 PST
Created attachment 582137 [details] [diff] [review]
rm cruft

I'm afraid this is a bit of a grab bag of cruft removal.  It started with evilpie's (evilpies'?) observation that PutBlockObject/UnwindScope really aren't fallible and then I kept finding cruft.

  17 files changed, 66 insertions(+), 584 deletions(-)
Comment 1 Chris Leary [:cdleary] (not checking bugmail) 2011-12-15 16:05:37 PST
CC'ing Tom: what's the appropriate possessive plural for evilpie?
Comment 2 Luke Wagner [:luke] 2011-12-15 18:14:13 PST
Created attachment 582160 [details] [diff] [review]
rm cruft 2

lil' bit more.
Comment 3 Luke Wagner [:luke] 2011-12-15 18:17:15 PST
Created attachment 582161 [details] [diff] [review]
rm cruft 3

One more ounce of cruft (dead comment).
Comment 4 Jeff Walden [:Waldo] (remove +bmo to email) 2011-12-16 11:11:15 PST
Comment on attachment 582161 [details] [diff] [review]
rm cruft 3

Review of attachment 582161 [details] [diff] [review]:
-----------------------------------------------------------------

http://www.youtube.com/watch?v=mUP3A9imOYU

::: js/src/jsobj.h
@@ +1500,5 @@
>  
>  #define OBJ_BLOCK_COUNT(cx,obj)                                               \
>      (obj)->propertyCount()
>  #define OBJ_BLOCK_DEPTH(cx,obj)                                               \
> +    ((uint32)(obj)->getFixedSlot(JSSLOT_BLOCK_DEPTH).toInt32())

uint32_t, and a C++ cast.
Comment 6 Marco Bonardo [::mak] 2012-01-03 03:46:23 PST
https://hg.mozilla.org/mozilla-central/rev/6ff43da616be

Note You need to log in before you can comment on or make changes to this bug.