rm cruft: JS_REQUIRES_STACK, find-child.py, jsstack.js, fallibility of PutBlockObject/UnwindScope

RESOLVED FIXED in mozilla12

Status

()

Core
JavaScript Engine
RESOLVED FIXED
6 years ago
6 years ago

People

(Reporter: luke, Assigned: luke)

Tracking

unspecified
mozilla12
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment, 2 obsolete attachments)

(Assignee)

Description

6 years ago
Created attachment 582137 [details] [diff] [review]
rm cruft

I'm afraid this is a bit of a grab bag of cruft removal.  It started with evilpie's (evilpies'?) observation that PutBlockObject/UnwindScope really aren't fallible and then I kept finding cruft.

  17 files changed, 66 insertions(+), 584 deletions(-)
Attachment #582137 - Flags: review?(jwalden+bmo)
CC'ing Tom: what's the appropriate possessive plural for evilpie?
(Assignee)

Comment 2

6 years ago
Created attachment 582160 [details] [diff] [review]
rm cruft 2

lil' bit more.
Attachment #582160 - Flags: review?(jwalden+bmo)
(Assignee)

Comment 3

6 years ago
Created attachment 582161 [details] [diff] [review]
rm cruft 3

One more ounce of cruft (dead comment).
Attachment #582137 - Attachment is obsolete: true
Attachment #582160 - Attachment is obsolete: true
Attachment #582137 - Flags: review?(jwalden+bmo)
Attachment #582160 - Flags: review?(jwalden+bmo)
Attachment #582161 - Flags: review?(jwalden+bmo)
Attachment #582161 - Attachment is patch: true
Comment on attachment 582161 [details] [diff] [review]
rm cruft 3

Review of attachment 582161 [details] [diff] [review]:
-----------------------------------------------------------------

http://www.youtube.com/watch?v=mUP3A9imOYU

::: js/src/jsobj.h
@@ +1500,5 @@
>  
>  #define OBJ_BLOCK_COUNT(cx,obj)                                               \
>      (obj)->propertyCount()
>  #define OBJ_BLOCK_DEPTH(cx,obj)                                               \
> +    ((uint32)(obj)->getFixedSlot(JSSLOT_BLOCK_DEPTH).toInt32())

uint32_t, and a C++ cast.
Attachment #582161 - Flags: review?(jwalden+bmo) → review+
(Assignee)

Comment 5

6 years ago
https://hg.mozilla.org/integration/mozilla-inbound/rev/6ff43da616be
Target Milestone: --- → mozilla12
https://hg.mozilla.org/mozilla-central/rev/6ff43da616be
Status: NEW → RESOLVED
Last Resolved: 6 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.