711291 - Add custom icon property to PopupNotifications.show() options

Status: RESOLVED FIXED

(Toolkit :: General, defect)

Description

[[:fabrice] Fabrice Desré]

It can be useful to dynamically specify the icon of a popup notification and not rely on a CSS id rule.

This can be done by adding an |icon| property to the |options| parameter of PopupNotifications.show()

Comment 1

[Dão Gottwald [:dao]]

(In reply to Fabrice Desré [:fabrice] from comment #0)
> It can be useful to dynamically specify the icon of a popup notification and
> not rely on a CSS id rule.

I expected the goal of this bug to be that you don't need a custom XBL binding when putting an icon inside the popup.

Comment 2

[:Gavin Sharp [email: [e-mail]]]

Yes, that is the goal. There currently is an icon in the popup, you just can't easily change it's source without using CSS.

Comment 3

[Dão Gottwald [:dao]]

So basically you want this API to follow notification bars? That design is flawed, see bug 415400. The icon lives in the theme, it makes sense to set it there as well.

Comment 4

[Dão Gottwald [:dao]]

Attachment: patch

Ah, the icon property would be optional. Makes sense.

I chose popupIconURL rather than iconURL since there's also the anchor icon.

Comment 5

[Dão Gottwald [:dao]]

http://hg.mozilla.org/integration/mozilla-inbound/rev/229cbb8cf0b5

Need to update https://developer.mozilla.org/en/JavaScript_code_modules/PopupNotifications.jsm#Notification_options

Comment 6

[Matt Brubeck (:mbrubeck)]

https://hg.mozilla.org/mozilla-central/rev/229cbb8cf0b5

Comment 7

[Alfred Kayser]

The webapp icon needs to be enforced a maximum size:
.popup-notification-icon{
	max-width:64px;
	max-height:64px}
Now webapps can have very large icons and thereby blowing up the notification panel.

Comment 8

[Jason Smith [:jsmith]]

Given that the pop-up notification no longer shows an icon, is this bug still valid? If so, could you clarify why?

Comment 9

[:Gavin Sharp [email: [e-mail]]]

Not sure what you mean - this bug is FIXED. It added some capabilities that we're no longer using, but I don't see any pressing need to back them out.

Comment 10

[Jason Smith [:jsmith]]

Okay. So is there no way then to verify this from an end-user perspective? If there isn't, as long as the code change is in then, we'll marked this verified then.

Comment 11

[:Gavin Sharp [email: [e-mail]]]

There is currently no user of this API in Firefox, right.