Closed Bug 711325 Opened 10 years ago Closed 10 years ago

Remove "security.enable_ssl2" remnant in nsThunderbirdProfileMigrator.cpp

Categories

(SeaMonkey :: Startup & Profiles, defect)

defect
Not set
trivial

Tracking

(Not tracked)

VERIFIED FIXED
seamonkey2.11

People

(Reporter: sgautherie, Assigned: pallavikumarijha)

References

()

Details

Attachments

(1 file, 2 obsolete files)

{
/suite/profile/migration/src/nsThunderbirdProfileMigrator.cpp
    * line 497 -- MAKESAMETYPEPREFTRANSFORM("security.enable_ssl2", Bool),
}

Just delete the line.
Attachment #603233 - Flags: review?(sgautherie.bz)
Attachment #603233 - Flags: review?(sgautherie.bz)
Attachment #603233 - Flags: review?(iann_bugzilla)
Attachment #603233 - Flags: feedback+
Assignee: nobody → pallavikumarijha
Status: NEW → ASSIGNED
Flags: in-testsuite-
Whiteboard: [good first bug] → [good first bug][mentor=sgautherie][lang=c++]
Attachment #603233 - Flags: review?(iann_bugzilla) → review+
Keywords: checkin-needed
Please, don't 'checkin-needed' until you have attached a patch according to comment 2.
Keywords: checkin-needed
Oh ya, thank you
> Please, don't 'checkin-needed' until you have attached a patch
Err, Serge, there's a patch attached with r+
Keywords: checkin-needed
(In reply to Philip Chee from comment #5)
> > Please, don't 'checkin-needed' until you have attached a patch
> Err, Serge, there's a patch attached with r+

Err, read my comment to its end...
Keywords: checkin-needed
Attachment #607134 - Flags: review?(sgautherie.bz)
Comment on attachment 607134 [details] [diff] [review]
"security.enable_ssl2" remnant in nsThunderbirdProfileMigrator.cpp has been removed

That's almost it:

>"security.enable_ssl2" remnant in nsThunderbirdProfileMigrator.cpp has been removed

You must add the bug number.
In this case, you can just use
"Bug 711325. Remove "security.enable_ssl2" remnant in nsThunderbirdProfileMigrator.cpp. f=sgautherie r=IanN."
Attachment #607134 - Flags: review?(sgautherie.bz)
Sir,is this the only change i need to make?
Attached patch patch3Splinter Review
Attachment #607134 - Attachment is obsolete: true
Attachment #611758 - Flags: review?(sgautherie.bz)
Attachment #611758 - Flags: review?(sgautherie.bz)
Keywords: checkin-needed
Whiteboard: [good first bug][mentor=sgautherie][lang=c++]
Target Milestone: --- → seamonkey2.11
Attachment #603233 - Attachment is obsolete: true
Thanks for the patch!

http://hg.mozilla.org/comm-central/rev/6665f0a5e9c9
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
V.Fixed, per MXR search.
Status: RESOLVED → VERIFIED
Thanks for verification...:)
You need to log in before you can comment on or make changes to this bug.