Remove "security.enable_ssl2" remnant in nsThunderbirdProfileMigrator.cpp

VERIFIED FIXED in seamonkey2.11

Status

--
trivial
VERIFIED FIXED
7 years ago
7 years ago

People

(Reporter: sgautherie, Assigned: pallavikumarijha)

Tracking

Trunk
seamonkey2.11
Bug Flags:
in-testsuite -

Firefox Tracking Flags

(Not tracked)

Details

(URL)

Attachments

(1 attachment, 2 obsolete attachments)

(Reporter)

Description

7 years ago
{
/suite/profile/migration/src/nsThunderbirdProfileMigrator.cpp
    * line 497 -- MAKESAMETYPEPREFTRANSFORM("security.enable_ssl2", Bool),
}

Just delete the line.
(Assignee)

Comment 1

7 years ago
Created attachment 603233 [details] [diff] [review]
"security.enable_ssl2" remnant in nsThunderbirdProfileMigrator.cpp has been removed
Attachment #603233 - Flags: review?(sgautherie.bz)
(Reporter)

Updated

7 years ago
Attachment #603233 - Flags: review?(sgautherie.bz)
Attachment #603233 - Flags: review?(iann_bugzilla)
Attachment #603233 - Flags: feedback+
(Reporter)

Updated

7 years ago
Assignee: nobody → pallavikumarijha
Status: NEW → ASSIGNED
Flags: in-testsuite-

Updated

7 years ago
Whiteboard: [good first bug] → [good first bug][mentor=sgautherie][lang=c++]

Updated

7 years ago
Attachment #603233 - Flags: review?(iann_bugzilla) → review+
(Assignee)

Updated

7 years ago
Keywords: checkin-needed
(Reporter)

Comment 3

7 years ago
Please, don't 'checkin-needed' until you have attached a patch according to comment 2.
Keywords: checkin-needed
(Assignee)

Comment 4

7 years ago
Oh ya, thank you

Comment 5

7 years ago
> Please, don't 'checkin-needed' until you have attached a patch
Err, Serge, there's a patch attached with r+
Keywords: checkin-needed
(Reporter)

Comment 6

7 years ago
(In reply to Philip Chee from comment #5)
> > Please, don't 'checkin-needed' until you have attached a patch
> Err, Serge, there's a patch attached with r+

Err, read my comment to its end...
Keywords: checkin-needed
(Assignee)

Comment 7

7 years ago
Created attachment 607134 [details] [diff] [review]
"security.enable_ssl2" remnant in nsThunderbirdProfileMigrator.cpp has been removed
Attachment #607134 - Flags: review?(sgautherie.bz)
(Reporter)

Comment 8

7 years ago
Comment on attachment 607134 [details] [diff] [review]
"security.enable_ssl2" remnant in nsThunderbirdProfileMigrator.cpp has been removed

That's almost it:

>"security.enable_ssl2" remnant in nsThunderbirdProfileMigrator.cpp has been removed

You must add the bug number.
In this case, you can just use
"Bug 711325. Remove "security.enable_ssl2" remnant in nsThunderbirdProfileMigrator.cpp. f=sgautherie r=IanN."
Attachment #607134 - Flags: review?(sgautherie.bz)
(Assignee)

Comment 9

7 years ago
Sir,is this the only change i need to make?
(Assignee)

Comment 10

7 years ago
Created attachment 611758 [details] [diff] [review]
patch3
Attachment #607134 - Attachment is obsolete: true
Attachment #611758 - Flags: review?(sgautherie.bz)
(Reporter)

Updated

7 years ago
Attachment #611758 - Flags: review?(sgautherie.bz)
(Reporter)

Updated

7 years ago
Keywords: checkin-needed
Whiteboard: [good first bug][mentor=sgautherie][lang=c++]
Target Milestone: --- → seamonkey2.11
(Reporter)

Updated

7 years ago
Attachment #603233 - Attachment is obsolete: true
Thanks for the patch!

http://hg.mozilla.org/comm-central/rev/6665f0a5e9c9
Status: ASSIGNED → RESOLVED
Last Resolved: 7 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
(Reporter)

Comment 12

7 years ago
V.Fixed, per MXR search.
Status: RESOLVED → VERIFIED
(Assignee)

Comment 13

7 years ago
Thanks for verification...:)
You need to log in before you can comment on or make changes to this bug.