The default bug view has changed. See this FAQ.

gfx/angle/src/compiler/osinclude.h:22:2: error: #error Unsupported platform. on GNU/kfreebsd and probably Hurd

RESOLVED FIXED

Status

()

Core
Canvas: WebGL
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: glandium, Assigned: glandium)

Tracking

Trunk
All
Other
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment, 1 obsolete attachment)

(Assignee)

Description

5 years ago
GNU kfreebsd is the GNU userland with the FreeBSD kernel. Hurd is GNU vaporware. Both are currently unsupported by the check in osinclude.h.
(Assignee)

Comment 1

5 years ago
Created attachment 582209 [details] [diff] [review]
Add support for GNU/kFreeBSD and GNU/Hurd to gfx/angle/src/compiler/osinclude.h

This should be enough, I'll confirm later next week.
Attachment #582209 - Flags: review?(bjacob)
(Assignee)

Updated

5 years ago
Assignee: nobody → mh+mozilla
(Assignee)

Comment 2

5 years ago
Created attachment 582220 [details] [diff] [review]
Add support for GNU/kFreeBSD and GNU/Hurd to gfx/angle/src/compiler/osinclude.h

Oops that was totally not the right patch
Attachment #582220 - Flags: review?(bjacob)
(Assignee)

Updated

5 years ago
Attachment #582209 - Attachment is obsolete: true
Attachment #582209 - Flags: review?(bjacob)
Comment on attachment 582220 [details] [diff] [review]
Add support for GNU/kFreeBSD and GNU/Hurd to gfx/angle/src/compiler/osinclude.h

Review of attachment 582220 [details] [diff] [review]:
-----------------------------------------------------------------

r+ but actually, rather than adding another local patch, let's land this on ANGLE upstream right away.
Attachment #582220 - Flags: review?(bjacob) → review+
(Assignee)

Comment 4

5 years ago
Note there's a typo in the patch (define instead of defined). I'll know if the patch itself is enough in a few hours.
OK, let's use that time to ask Daniel to confirm it's ok to land in ANGLE.
(Assignee)

Comment 6

5 years ago
Firefox 9 builds on GNU/kFreeBSD with that patch (without the typo). I'm not sure what to look at in the test suite to know whether this actually works.
The basic recipe to start the WebGL mochitest is:

TEST_PATH=content/canvas/test/webgl/test_webgl_conformance_test_suite.html make mochitest-plain

Expect a few errors, depending on your GL drivers. Also, I don't know if your platform will be identified as Linux, but if it is, it is hardcoded to expect the same driver bugs as on the test slaves, so you might get a few UNEXPECTED-PASS.

It should stay open for a few minutes with the results when it's done. If it suddenly closes without showing the results, it means it crashed. If it crashes, you can add this environment variable to debug:

EXTRA_TEST_ARGS='--debugger=gdb'
Checked in as ANGLE r954. You're now a ANGLE developer. Congrats! Filing bug to update our ANGLE copy, will block this on it.
Depends on: 720438
Landed on inbound with bug 720438. I'm going to preventively close this bug as otherwise I'll forget.
Status: NEW → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.