The default bug view has changed. See this FAQ.

[BC]Table border incorrectly rendered after 'display:none'ing some table rows

VERIFIED FIXED in Firefox 11

Status

()

Core
Layout: Tables
VERIFIED FIXED
5 years ago
5 years ago

People

(Reporter: glazou, Assigned: Bernd)

Tracking

({regression, testcase})

Trunk
mozilla11
regression, testcase
Points:
---
Dependency tree / graph
Bug Flags:
in-testsuite +

Firefox Tracking Flags

(firefox11+ verified)

Details

(Whiteboard: [qa!])

Attachments

(3 attachments, 3 obsolete attachments)

(Reporter)

Description

5 years ago
Created attachment 582218 [details]
screenshot of the bug, OS X 10.6.5, Nightly 11.0a1 2011-12-15

This is a regression visible in Nigthlies (I am currently using 11.0a1 2011-12-15) and not in FF8.

1. Open http://bluegriffon.org/pages/Community#localizeBlueGriffon

2. select locales a few times using the dropdown menu inside the page

3. after a few locale selections, the table becomes incompletely rendered,
   see attached screenshot

The page gives a "display: none" to all table rows that are not of the
selected locale. Nothing else. Tested on Mac OS X 10.6.5.
Summary: Table border incorrectly rendered after 'display:none'ing some table rows → [BC]Table border incorrectly rendered after 'display:none'ing some table rows
Regression range (Linux64 builds):  2011-11-28-03-10-52 -- 2011-11-29-03-10-19
http://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=854aabf544d4&tochange=bc48009a6bbb
I suspect bug 460637.
Blocks: 460637
tracking-firefox11: --- → ?
Keywords: regression
OS: Mac OS X → All
Hardware: x86 → All
Daniel, FYI, changing the value using keyboard commands doesn't work since you only
have onclick on the <select>
(Reporter)

Comment 3

5 years ago
(In reply to Mats Palmgren [:mats] from comment #2)
> Daniel, FYI, changing the value using keyboard commands doesn't work since
> you only
> have onclick on the <select>

d'oh, yes, a mistake; but that has no link with the regression describes here.
(Assignee)

Comment 4

5 years ago
A reduced test case that demonstrates this would be fine
Keywords: qawanted, testcase-wanted
(Assignee)

Comment 5

5 years ago
Created attachment 582681 [details]
reduced testcase
(Assignee)

Updated

5 years ago
Keywords: qawanted, testcase-wanted → testcase
(Assignee)

Comment 6

5 years ago
Created attachment 583071 [details] [diff] [review]
patch
(Assignee)

Comment 7

5 years ago
the patch fixes only the reduced testcase but the page still does show problems.
(Assignee)

Comment 8

5 years ago
Created attachment 584170 [details] [diff] [review]
revised patch

this fixes the url and bug 712849
Attachment #583071 - Attachment is obsolete: true
(Assignee)

Updated

5 years ago
Attachment #584170 - Attachment is patch: true
(Assignee)

Comment 9

5 years ago
Created attachment 584174 [details] [diff] [review]
revised patch

https://tbpl.mozilla.org/?tree=Try&rev=6e29a33c204f
Attachment #584170 - Attachment is obsolete: true
(Assignee)

Comment 10

5 years ago
Created attachment 584314 [details] [diff] [review]
revised patch

https://tbpl.mozilla.org/?tree=Try&rev=513135fa8046
Assignee: nobody → bernd_mozilla
Attachment #584174 - Attachment is obsolete: true
Status: NEW → ASSIGNED
Attachment #584314 - Flags: review?(matspal)
Comment on attachment 584314 [details] [diff] [review]
revised patch

>+  // mark all following rows  damaged ...

s/mark/Mark/ and delete the extra space before "damaged"

>   SetDamageArea(0, aRgFirstRowIndex + startRowIndex, aMap.GetColCount(),
>-                1 + endRowIndex - startRowIndex, aDamageArea);
>+                aMap.GetRowCount() - aRgFirstRowIndex - startRowIndex,
>+                aDamageArea);

I think this would be clearer with a temp variable, like so:

  PRInt32 firstDamagedRow = aRgFirstRowIndex + startRowIndex;
  SetDamageArea(0, firstDamagedRow, aMap.GetColCount(),
                aMap.GetRowCount() - firstDamagedRow,
                aDamageArea);
Attachment #584314 - Flags: review?(matspal) → review+
(Assignee)

Comment 12

5 years ago
https://hg.mozilla.org/integration/mozilla-inbound/rev/ab7997839419

Updated

5 years ago
tracking-firefox11: ? → +
https://hg.mozilla.org/mozilla-central/rev/ab7997839419
Status: ASSIGNED → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla12
(Assignee)

Updated

5 years ago
Flags: in-testsuite+
(Assignee)

Comment 14

5 years ago
Comment on attachment 584314 [details] [diff] [review]
revised patch

this fixes a rendering regression that got uplifted to aurora
Attachment #584314 - Flags: approval-mozilla-aurora?

Updated

5 years ago
Blocks: 712849

Comment 15

5 years ago
Comment on attachment 584314 [details] [diff] [review]
revised patch

[triage comment]
Approved for aurora. This is a rendering regression we do not want to ship.
Attachment #584314 - Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
(Assignee)

Comment 16

5 years ago
fixed on aurora
Target Milestone: mozilla12 → mozilla11
(Assignee)

Comment 17

5 years ago
https://hg.mozilla.org/releases/mozilla-aurora/rev/e2fe885dce01
status-firefox11: --- → fixed
Whiteboard: [qa+]
Verified 
Build identifier: Mozilla/5.0 (X11; Linux i686; rv:11.0) Gecko/20100101 Firefox/11.0
Verified 
Mozilla/5.0 (Windows NT 6.1; WOW64; rv:11.0) Gecko/20100101 Firefox/11.0
Verified Build identifier: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.6; rv:11.0) Gecko/20100101 Firefox/11.0
Status: RESOLVED → VERIFIED
status-firefox11: fixed → verified
Whiteboard: [qa+] → [qa!]
You need to log in before you can comment on or make changes to this bug.