711359 - [BC]Table border incorrectly rendered after 'display:none'ing some table rows

Status: VERIFIED FIXED

(Core :: Layout: Tables, defect)

Description

[Daniel Glazman (:glazou) (not active in Mozilla any more)]

Attachment: screenshot of the bug, OS X 10.6.5, Nightly 11.0a1 2011-12-15

This is a regression visible in Nigthlies (I am currently using 11.0a1 2011-12-15) and not in FF8.

1. Open http://bluegriffon.org/pages/Community#localizeBlueGriffon

2. select locales a few times using the dropdown menu inside the page

3. after a few locale selections, the table becomes incompletely rendered,
   see attached screenshot

The page gives a "display: none" to all table rows that are not of the
selected locale. Nothing else. Tested on Mac OS X 10.6.5.

Comment 1

[Mats Palmgren (inactive)]

Regression range (Linux64 builds):  2011-11-28-03-10-52 -- 2011-11-29-03-10-19
http://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=854aabf544d4&tochange=bc48009a6bbb
I suspect bug 460637.

Comment 2

[Mats Palmgren (inactive)]

Daniel, FYI, changing the value using keyboard commands doesn't work since you only
have onclick on the <select>

Comment 3

[Daniel Glazman (:glazou) (not active in Mozilla any more)]

(In reply to Mats Palmgren [:mats] from comment #2)
> Daniel, FYI, changing the value using keyboard commands doesn't work since
> you only
> have onclick on the <select>

d'oh, yes, a mistake; but that has no link with the regression describes here.

Comment 4

[Bernd]

A reduced test case that demonstrates this would be fine

Comment 5

[Bernd]

Attachment: reduced testcase

Comment 6

[Bernd]

Attachment: patch

Comment 7

[Bernd]

the patch fixes only the reduced testcase but the page still does show problems.

Comment 8

[Bernd]

Attachment: revised patch

this fixes the url and bug 712849

Comment 9

[Bernd]

Attachment: revised patch

https://tbpl.mozilla.org/?tree=Try&rev=6e29a33c204f

Comment 10

[Bernd]

Attachment: revised patch

https://tbpl.mozilla.org/?tree=Try&rev=513135fa8046

Comment 11

[Mats Palmgren (inactive)]

Comment on attachment 584314 [details] [diff] [review]
revised patch

>+  // mark all following rows  damaged ...

s/mark/Mark/ and delete the extra space before "damaged"

>   SetDamageArea(0, aRgFirstRowIndex + startRowIndex, aMap.GetColCount(),
>-                1 + endRowIndex - startRowIndex, aDamageArea);
>+                aMap.GetRowCount() - aRgFirstRowIndex - startRowIndex,
>+                aDamageArea);

I think this would be clearer with a temp variable, like so:

  PRInt32 firstDamagedRow = aRgFirstRowIndex + startRowIndex;
  SetDamageArea(0, firstDamagedRow, aMap.GetColCount(),
                aMap.GetRowCount() - firstDamagedRow,
                aDamageArea);

Comment 12

[Bernd]

https://hg.mozilla.org/integration/mozilla-inbound/rev/ab7997839419

Comment 13

[Matt Brubeck (:mbrubeck)]

https://hg.mozilla.org/mozilla-central/rev/ab7997839419

Comment 14

[Bernd]

Comment on attachment 584314 [details] [diff] [review]
revised patch

this fixes a rendering regression that got uplifted to aurora

Comment 15

[LegNeato]

Comment on attachment 584314 [details] [diff] [review]
revised patch

[triage comment]
Approved for aurora. This is a rendering regression we do not want to ship.

Comment 16

[Bernd]

fixed on aurora

Comment 17

[Bernd]

https://hg.mozilla.org/releases/mozilla-aurora/rev/e2fe885dce01

Comment 18

[Maniac Vlad Florin (:vladmaniac)]

Verified 
Build identifier: Mozilla/5.0 (X11; Linux i686; rv:11.0) Gecko/20100101 Firefox/11.0

Comment 19

[Maniac Vlad Florin (:vladmaniac)]

Verified 
Mozilla/5.0 (Windows NT 6.1; WOW64; rv:11.0) Gecko/20100101 Firefox/11.0

Comment 20

[Alex Lakatos[:AlexLakatos]]

Verified Build identifier: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.6; rv:11.0) Gecko/20100101 Firefox/11.0