Closed
Bug 711381
Opened 14 years ago
Closed 14 years ago
v8-support.h fails to compile on mingw
Categories
(Core :: Graphics, defect)
Tracking
()
RESOLVED
FIXED
mozilla11
People
(Reporter: jacek, Assigned: jacek)
Details
Attachments
(1 file)
806 bytes,
patch
|
Felipe
:
review+
|
Details | Diff | Splinter Review |
I get an error:
v8-support.h:57:10: error: 'int32_t' does not name a type
Although mingw supports int32_t, it requires stdint.h to be included, which is not in this case. __int32 is, however, always supported to mimic MSVC behavior, so making #ifdef platfor, instead of compiler, specific fixes the problem.
Attachment #582238 -
Flags: review?(felipc)
Assignee | ||
Updated•14 years ago
|
Assignee: nobody → jacek
Comment 1•14 years ago
|
||
Comment on attachment 582238 [details] [diff] [review]
fix v1.0
Alternatively we could use the recently added mozilla/StdInt.h and get rid of some of the typedefs in platform.h
Attachment #582238 -
Flags: review?(felipc) → review+
Assignee | ||
Comment 2•14 years ago
|
||
Thanks for the review, pushed to m-i:
https://hg.mozilla.org/integration/mozilla-inbound/rev/8668dc5a4f60
Assignee | ||
Updated•14 years ago
|
Whiteboard: [inbound]
Comment 3•14 years ago
|
||
Status: NEW → RESOLVED
Closed: 14 years ago
Resolution: --- → FIXED
Whiteboard: [inbound]
Target Milestone: --- → mozilla11
Comment 4•14 years ago
|
||
(In reply to Felipe Gomes (:felipe) from comment #1)
> Comment on attachment 582238 [details] [diff] [review]
> fix v1.0
>
> Alternatively we could use the recently added mozilla/StdInt.h and get rid
> of some of the typedefs in platform.h
Indeed. Jacek, could you file a followup?
Assignee | ||
Comment 5•14 years ago
|
||
(In reply to Ms2ger from comment #4)
> Indeed. Jacek, could you file a followup?
Sure, filled bug 712254
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
Target Milestone: mozilla11 → ---
Version: Trunk → Other Branch
Assignee | ||
Comment 6•14 years ago
|
||
Restoring accidentally changed status
Status: REOPENED → RESOLVED
Closed: 14 years ago → 14 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla11
Version: Other Branch → Trunk
You need to log in
before you can comment on or make changes to this bug.
Description
•