711381 - v8-support.h fails to compile on mingw

Status: RESOLVED FIXED

Description

[Jacek Caban]

Created attachment 582238 [details] [diff] [review]
fix v1.0

I get an error:

v8-support.h:57:10: error: 'int32_t' does not name a type

Although mingw supports int32_t, it requires stdint.h to be included, which is not in this case. __int32 is, however, always supported to mimic MSVC behavior, so making #ifdef platfor, instead of compiler, specific fixes the problem.

Comment 1

[:Felipe Gomes (needinfo me!)]

Comment on attachment 582238 [details] [diff] [review]
fix v1.0

Alternatively we could use the recently added mozilla/StdInt.h and get rid of some of the typedefs in platform.h

Comment 2

[Jacek Caban]

Thanks for the review, pushed to m-i:

https://hg.mozilla.org/integration/mozilla-inbound/rev/8668dc5a4f60

Comment 3

[Matt Brubeck (:mbrubeck)]

https://hg.mozilla.org/mozilla-central/rev/8668dc5a4f60

Comment 4

[:Ms2ger (⌚ UTC+1/+2)]

(In reply to Felipe Gomes (:felipe) from comment #1)
> Comment on attachment 582238 [details] [diff] [review]
> fix v1.0
> 
> Alternatively we could use the recently added mozilla/StdInt.h and get rid
> of some of the typedefs in platform.h

Indeed. Jacek, could you file a followup?

Comment 5

[Jacek Caban]

(In reply to Ms2ger from comment #4)
> Indeed. Jacek, could you file a followup?

Sure, filled bug 712254

Comment 6

[Jacek Caban]

Restoring accidentally changed status