Closed Bug 71143 Opened 23 years ago Closed 23 years ago

nsISound is synchronous on Windows

Categories

(Core :: XUL, defect, P3)

Product:
Core
Component:
XUL
Platform:
x86
Windows 2000
Type:
defect

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla0.9.4

People

(Reporter: hyatt, Assigned: hyatt)

Details

(Keywords: helpwanted, perf)

Attachments

(1 file)

Sound is now async on win32. This was tested in a full-on spam session with AIM.
2.30 KB, patch
Details | Diff | Splinter Review 
Pav's impl of nsISound is synchronous on Win32.  This kills performance.  Please
fix!
Keywords: perf
Status: NEW → ASSIGNED
Target Milestone: --- → mozilla0.9.2
adding saari as he might have some insight as well to share :)
Priority: -- → P3
anyone have any ideas on how to fix this... then help pav.
Keywords: helpwanted
Target Milestone: mozilla0.9.2 → mozilla0.9.3
-> 0.9.4 per Pavlov
Target Milestone: mozilla0.9.3 → mozilla0.9.4
Target Milestone: mozilla0.9.4 → mozilla0.9.5
Ok, pushed pushed and pushed.  I'm taking this back. :)
Assignee: pavlov → hyatt
Status: ASSIGNED → NEW
Target Milestone: mozilla0.9.5 → mozilla0.9.4
This is a bad emojo bug with aim.  Targeting for 0.9.4.
Status: NEW → ASSIGNED
Ready for r/sr.  This makes a huge difference for me in perf in an active AIM 
conversation.  The UI stops locking up.

After some to-ing and fro-ing on #mozilla, r=markh
Fixed.
Status: ASSIGNED → RESOLVED
Closed: 23 years ago
Resolution: --- → FIXED
awesome! Cant wait to try this out.  Can you describe how one might test 
this?  Say playing a .wav file while having the ui update?

Note that I fixed this on win32.  I do not know if nsisound is async on mac or
linux.
Component: XP Toolkit/Widgets: XUL → XUL
QA Contact: jrgmorrison → xptoolkit.widgets
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: