Test defaultMuted with reflect.js

RESOLVED FIXED in mozilla12

Status

()

Core
DOM
RESOLVED FIXED
6 years ago
6 years ago

People

(Reporter: Ms2ger, Assigned: Plop)

Tracking

Trunk
mozilla12
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: [good first bug][mentor=Ms2ger][lang=js])

Attachments

(1 attachment, 1 obsolete attachment)

3.55 KB, patch
Ms2ger
: checkin+
Details | Diff | Splinter Review
(Reporter)

Description

6 years ago
<http://mxr.mozilla.org/mozilla-central/source/content/html/content/test/reflect.js?force=1> contains a function to test boolean reflection rather thoroughly, so it would be nice to use it for the defaultMuted test: <http://mxr.mozilla.org/mozilla-central/source/content/media/test/test_defaultMuted.html?force=1>.
(Reporter)

Updated

6 years ago
Whiteboard: [good first bug][mentor=Ms2ger][lang=js]
(Assignee)

Comment 1

6 years ago
Created attachment 583635 [details] [diff] [review]
Patch version 1
Attachment #583635 - Flags: review?(Ms2ger)
(Reporter)

Comment 2

6 years ago
Comment on attachment 583635 [details] [diff] [review]
Patch version 1

r=me, thanks for the patch.

It would be really nice if you could provide a patch as described at <https://developer.mozilla.org/en/Mercurial_FAQ#How_can_I_generate_a_patch_for_somebody_else_to_check-in_for_me.3f>.
Attachment #583635 - Flags: review?(Ms2ger) → review+
(Reporter)

Updated

6 years ago
Assignee: nobody → plop2plopplop
(Assignee)

Comment 3

6 years ago
Created attachment 583942 [details] [diff] [review]
Patch version 2
Attachment #583635 - Attachment is obsolete: true
Attachment #583942 - Flags: checkin?
(Assignee)

Updated

6 years ago
Keywords: checkin-needed
http://hg.mozilla.org/integration/mozilla-inbound/rev/a2c3c5fd7dce
Keywords: checkin-needed
Target Milestone: --- → mozilla12
(Reporter)

Comment 5

6 years ago
Thanks again for the patch.

https://hg.mozilla.org/mozilla-central/rev/fbef0361b27a
Status: NEW → RESOLVED
Last Resolved: 6 years ago
Resolution: --- → FIXED
(Reporter)

Updated

6 years ago
Attachment #583942 - Flags: checkin? → checkin+
You need to log in before you can comment on or make changes to this bug.