Last Comment Bug 711446 - Test defaultMuted with reflect.js
: Test defaultMuted with reflect.js
Status: RESOLVED FIXED
[good first bug][mentor=Ms2ger][lang=js]
:
Product: Core
Classification: Components
Component: DOM (show other bugs)
: Trunk
: All All
: -- normal (vote)
: mozilla12
Assigned To: Plop
:
Mentors:
Depends on:
Blocks: 706731
  Show dependency treegraph
 
Reported: 2011-12-16 07:19 PST by :Ms2ger
Modified: 2011-12-28 02:54 PST (History)
2 users (show)
See Also:
Crash Signature:
(edit)
QA Whiteboard:
Iteration: ---
Points: ---
Has Regression Range: ---
Has STR: ---


Attachments
Patch version 1 (3.42 KB, patch)
2011-12-21 14:49 PST, Plop
Ms2ger: review+
Details | Diff | Splinter Review
Patch version 2 (3.55 KB, patch)
2011-12-22 14:35 PST, Plop
Ms2ger: checkin+
Details | Diff | Splinter Review

Description :Ms2ger 2011-12-16 07:19:37 PST
<http://mxr.mozilla.org/mozilla-central/source/content/html/content/test/reflect.js?force=1> contains a function to test boolean reflection rather thoroughly, so it would be nice to use it for the defaultMuted test: <http://mxr.mozilla.org/mozilla-central/source/content/media/test/test_defaultMuted.html?force=1>.
Comment 1 Plop 2011-12-21 14:49:28 PST
Created attachment 583635 [details] [diff] [review]
Patch version 1
Comment 2 :Ms2ger 2011-12-22 01:01:50 PST
Comment on attachment 583635 [details] [diff] [review]
Patch version 1

r=me, thanks for the patch.

It would be really nice if you could provide a patch as described at <https://developer.mozilla.org/en/Mercurial_FAQ#How_can_I_generate_a_patch_for_somebody_else_to_check-in_for_me.3f>.
Comment 3 Plop 2011-12-22 14:35:18 PST
Created attachment 583942 [details] [diff] [review]
Patch version 2
Comment 5 :Ms2ger 2011-12-28 02:53:31 PST
Thanks again for the patch.

https://hg.mozilla.org/mozilla-central/rev/fbef0361b27a

Note You need to log in before you can comment on or make changes to this bug.