711508 - Toolbox.externalToolbars duplicated if the toolbar contains a menubar with autoHide enabled.

Status: RESOLVED FIXED

(Toolkit :: Toolbars and Toolbar Customization, defect)

Description

[Mike Conley (:mconley) (:⚙️)]

Thunderbird contains it's main menubar within a toolbar, and when autoHide is toggled, it looks like, for some reason or another, the constructor is recalled on that toolbar.

This causes the toolbox to have the same toolbar re-added as an external toolbar.

Comment 1

[Mike Conley (:mconley) (:⚙️)]

Attachment: Patch v1

This patch simply ensures that the external toolbar does not already exist in the toolbox before adding itself to the externalToolbars collection.

Comment 2

[Mike Conley (:mconley) (:⚙️)]

Neil:

You're my local XUL go-to guy - but let me know if you want me to redirect the review.

-Mike

Comment 3

[Neil Deakin]

Comment on attachment 582300 [details] [diff] [review]
Patch v1

Are you removing the toolbar from the document when autohide is toggled?

It looks like the toolbox getter doesn't handle being removed as it caches the _toolbox value, even though it could have changed by being moved somewhere else.

Comment 4

[Mike Conley (:mconley) (:⚙️)]

Neil:

No, we're just toggling the collapsed attribute.  Not sure why the constructor is called when we collapse and uncollapse though...

-Mike

Comment 5

[Mike Conley (:mconley) (:⚙️)]

Pushed to mozilla-inbound as https://hg.mozilla.org/integration/mozilla-inbound/rev/6c49a8d46f7d

Comment 6

[Matt Brubeck (:mbrubeck)]

https://hg.mozilla.org/mozilla-central/rev/6c49a8d46f7d