711578 - Session restore doesn't work for initial Fennec session crash

Status: VERIFIED FIXED

(Firefox for Android Graveyard :: General, defect, P3)

Description

[Brian Nicholson (:bnicholson)]

We create the sessionstore.js file on the first Fennec load, then copy it to sessionstore.bak on the second load. Since sessionstore.bak is required for the session restore, this means we won't restore the session if we crash on the first Fennec load.

Comment 1

[Henrik Skupin [:whimboo][⌚️UTC+2]]

Brian, what does first load mean? Since we flipped to the native UI on trunk any crash of Fennec doesn't restore my session. It was working properly with the old XUL ui. Is that a different issue from that one?

Comment 2

[Brian Nicholson (:bnicholson)]

(In reply to Henrik Skupin (:whimboo) from comment #1)
> Brian, what does first load mean? Since we flipped to the native UI on trunk
> any crash of Fennec doesn't restore my session. It was working properly with
> the old XUL ui. Is that a different issue from that one?

Session restore was just landed yesterday (bug 697858). "First load" means the first time Fennec is opened without any existing data. Also, XUL Fennec does have this bug.

STR:
1) Do a fresh Fennec install (either Force stop then clear data, or uninstall then reinstall).
2) Open Fennec.
3) Browse to any page.
4) Force close Fennec.
5) Open Fennec again.

Expected:
The page from step 3 is restored.

Actual:
No restore occurs.

Comment 3

[Henrik Skupin [:whimboo][⌚️UTC+2]]

I will wait until bug 697858 has been fully fixed before continuing here. Reason is that with yesterdays build session restore doesn't work at all for me. So I cannot give any good feedback here.

Comment 4

[Brian Nicholson (:bnicholson)]

Attachment: patch

Our current algorithm is:
- on init, see if sessionstore.js exists
  - if so, copy it to sessionstore.bak
- write session to sessionstore.js during browser use
- delete sessionstore.bak on quit
- if sessionstore.bak exists, we know we crashed

This is a problem because it takes two initializations for the .bak file to appear (sessionstore.js is created the first time, and sessionstore.bak is copied over after that).

This patch uses a new algorithm:
- on init, see if sessionstore.js exists
  - if so, move it to sessionstore.bak
- write session to sessionstore.js during browser use
- move sessionstore.js to sessionstore.bak on quit
- if sessionstore.js exists, we know we crashed

Comment 5

[Brian Nicholson (:bnicholson)]

http://hg.mozilla.org/integration/mozilla-inbound/rev/5be23e1bd1e7

Comment 6

[Brian Nicholson (:bnicholson)]

Comment on attachment 596735 [details] [diff] [review]
patch

[Approval Request Comment]
Fixes session restore on first Fennec run. Low risk.

Comment 7

[Marco Bonardo [:mak]]

https://hg.mozilla.org/mozilla-central/rev/5be23e1bd1e7

Comment 8

[Alex Keybl [:akeybl]]

Comment on attachment 596735 [details] [diff] [review]
patch

[Triage Comment]
Mobile only - approved for Aurora 12 and Beta 11.

Comment 9

[Matt Brubeck (:mbrubeck)]

Comment on attachment 596735 [details] [diff] [review]
patch

Clearing approval for Aurora 12 and Beta 11 because we are not currently planning a Native Fennec release of these versions.  If this changes in the future, we will likely do a mass uplift of all native fennec changes.  For now, let's get these bugs off the channel triage radar.

[Filter on the string "mbrubeck-bugspam" if you want to delete all of these emails at once.]

Comment 10

[Cristian Nicolae (:xti)]

Verified fixed on:

Firefox 13.0a1 (2012-02-29)
20120229031108
http://hg.mozilla.org/mozilla-central/rev/30b4f99a137c

--
Device: Samsung Galaxy S2
OS: Android 2.3.4