711591 - make the robotium test driver a bit more driver like

Status: RESOLVED FIXED

(Testing :: General, defect)

Description

[Joel Maher ( :jmaher ) (UTC -8)]

some tweaks that tfair and automatedtester had talked about.

This is a patch that I need to test with and tweak before asking for review.  Feel free to chime in now or then to comment.

Comment 1

[cmtalbert]

(In reply to Joel Maher (:jmaher) from comment #0)
> some tweaks that tfair and automatedtester had talked about.
> 
> This is a patch that I need to test with and tweak before asking for review.
> Feel free to chime in now or then to comment.

I think you forgot the patch...

Comment 2

[Joel Maher ( :jmaher ) (UTC -8)]

Attachment: updated tests with an asserts framework as well as general cleanup (1.0)

updated patch with local html files for test, and an added assert class.  This should be more compatible for selenium and other test driver syntax models.

Comment 3

[cmtalbert]

Comment on attachment 584437 [details] [diff] [review]
updated tests with an asserts framework as well as general cleanup (1.0)

Review of attachment 584437 [details] [diff] [review]:
-----------------------------------------------------------------

Not entirely sure who you were requesting review from, but since I'm around, I'll take it.  Feel free to ask again if you want someone else's feedback.  

I think the changes look good.  You might want to consider removing the setLogFile api from the driver code so no one gets confused, as I mentioned below.  But, as far as I can see, this code looks good r+.

::: mobile/android/base/tests/testAwesomebar.java.in
@@ +64,5 @@
>      actions = new FennecNativeActions(activity, solo, getInstrumentation());
>      driver.setLogFile((String)config.get("logfile"));
> +    
> +    asserter = new FennecNativeAssert();
> +    asserter.setLogFile((String)config.get("logfile"));

Do we need to remove the setLogFile function from the FennecNativeDriver code?   I think it would be a good thing to do so that there is only one way to call setLogFile. I'm asking as I don't see that in this patch.

Comment 4

[Joel Maher ( :jmaher ) (UTC -8)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/632f07583bd8

Comment 5

[Phil Ringnalda (:philor)]

Backed out in https://hg.mozilla.org/integration/mozilla-inbound/rev/2ea7afaa47a9 - one of the two in that push was hitting "TypeError: Cc['@mozilla.org/android/bridge;1'] is undefined at :0" in desktop mochitest-other.

Comment 6

[Joel Maher ( :jmaher ) (UTC -8)]

this actually wasn't backed out (or somehow landed again by accident).  I pulled the latest source and my other patch was missing, but this patch (new files and all) were in the tree.  I will see if this all makes it to mozilla-central on the next merge.

Comment 7

[Phil Ringnalda (:philor)]

/me does a quick merge to hide the evidence

https://hg.mozilla.org/mozilla-central/rev/632f07583bd8

Comment 8

[Brad Lassey [:blassey] (use needinfo?)]

Jorl, please request aurora approval or mark the whiteboard not-fennec-11