Closed
Bug 711611
Opened 13 years ago
Closed 13 years ago
NSPR's obsolete int32, int64, etc. types get defined without an opt-out #define
Categories
(Core :: JavaScript Engine, defect)
Core
JavaScript Engine
Tracking
()
RESOLVED
FIXED
mozilla11
People
(Reporter: Waldo, Assigned: Waldo)
Details
Attachments
(1 file)
|
583 bytes,
patch
|
bhackett1024
:
review+
|
Details | Diff | Splinter Review |
"These definitions are scheduled to be eliminated at the earliest possible time."
Yeah. Right. By the way, are you in the market for a bridge?
This leaks in through jslock.h, which in threadsafe builds includes various NSPR headers. Le sigh. Before this patch, an int32 i; in jsinterp.cpp would build. After, it fails to build.
I'll wait for try results on this, since it's possible this could have hidden other failures in Gecko, but the approach is reviewable without further ado.
Attachment #582387 -
Flags: review?(bhackett1024)
|
||
Updated•13 years ago
|
Attachment #582387 -
Flags: review?(bhackett1024) → review+
|
Assignee | |
Comment 1•13 years ago
|
||
Built on try, pushed:
https://hg.mozilla.org/integration/mozilla-inbound/rev/020e3a98f85e
Target Milestone: --- → mozilla11
|
||
Comment 2•13 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•