NSPR's obsolete int32, int64, etc. types get defined without an opt-out #define

RESOLVED FIXED in mozilla11

Status

()

Core
JavaScript Engine
RESOLVED FIXED
6 years ago
6 years ago

People

(Reporter: Waldo, Assigned: Waldo)

Tracking

unspecified
mozilla11
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

Created attachment 582387 [details] [diff] [review]
Potential patch, being tryservered now

"These definitions are scheduled to be eliminated at the earliest possible time."

Yeah.  Right.  By the way, are you in the market for a bridge?

This leaks in through jslock.h, which in threadsafe builds includes various NSPR headers.  Le sigh.  Before this patch, an int32 i; in jsinterp.cpp would build.  After, it fails to build.

I'll wait for try results on this, since it's possible this could have hidden other failures in Gecko, but the approach is reviewable without further ado.
Attachment #582387 - Flags: review?(bhackett1024)
Attachment #582387 - Flags: review?(bhackett1024) → review+
Built on try, pushed:

https://hg.mozilla.org/integration/mozilla-inbound/rev/020e3a98f85e
Target Milestone: --- → mozilla11
https://hg.mozilla.org/mozilla-central/rev/020e3a98f85e
Status: ASSIGNED → RESOLVED
Last Resolved: 6 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.