Closed Bug 711642 Opened 10 years ago Closed 10 years ago

ResizeOffscreenFBO should deguarantee that it does anything but resize the FBO

Categories

(Core :: Canvas: WebGL, defect)

defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla13

People

(Reporter: jgilbert, Assigned: jgilbert)

References

Details

Attachments

(1 file)

ResizeOffscreenFBO does things other than resizing FBOs. It shouldn't, because other code begins to expect it to then do things that are not guaranteed.

One thing I see is that we are setting the viewport to the correct size the first time we run. Unfortunately, we're bad at determining when is the first time vs. subsequent times. This should be done in the code which initializes the context, not in resize code.

An early-out added in bug 615976 makes it very important we know what our guarantees are, and aren't.
Depends on: 701269
We already set the viewport correctly for WebGL initialization.
Attachment #582426 - Flags: review?(bjacob)
Attachment #582426 - Flags: review?(bjacob) → review+
I will run this by try, then land it.
Blocks: 722195
Try run at https://tbpl.mozilla.org/?tree=Try&rev=e8b8a919fe13 is clean.
Assignee: jgilbert → nobody
Assignee: nobody → jgilbert
https://hg.mozilla.org/mozilla-central/rev/c96f7298db5b
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.