The default bug view has changed. See this FAQ.

ResizeOffscreenFBO should deguarantee that it does anything but resize the FBO

RESOLVED FIXED in mozilla13

Status

()

Core
Canvas: WebGL
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: jgilbert, Assigned: jgilbert)

Tracking

unspecified
mozilla13
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Assignee)

Description

5 years ago
ResizeOffscreenFBO does things other than resizing FBOs. It shouldn't, because other code begins to expect it to then do things that are not guaranteed.

One thing I see is that we are setting the viewport to the correct size the first time we run. Unfortunately, we're bad at determining when is the first time vs. subsequent times. This should be done in the code which initializes the context, not in resize code.

An early-out added in bug 615976 makes it very important we know what our guarantees are, and aren't.
(Assignee)

Updated

5 years ago
Depends on: 701269
(Assignee)

Comment 1

5 years ago
Created attachment 582426 [details] [diff] [review]
Deguarantee ResizeOffscreenFBO sets the viewport on first run

We already set the viewport correctly for WebGL initialization.
Attachment #582426 - Flags: review?(bjacob)
Attachment #582426 - Flags: review?(bjacob) → review+
(Assignee)

Comment 2

5 years ago
I will run this by try, then land it.
(Assignee)

Updated

5 years ago
Blocks: 722195
(Assignee)

Comment 3

5 years ago
Try run at https://tbpl.mozilla.org/?tree=Try&rev=e8b8a919fe13 is clean.
Assignee: jgilbert → nobody
(Assignee)

Updated

5 years ago
Assignee: nobody → jgilbert
(Assignee)

Comment 4

5 years ago
https://hg.mozilla.org/integration/mozilla-inbound/rev/c96f7298db5b
Target Milestone: --- → mozilla13
https://hg.mozilla.org/mozilla-central/rev/c96f7298db5b
Status: ASSIGNED → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.