711642 - ResizeOffscreenFBO should deguarantee that it does anything but resize the FBO

Status: RESOLVED FIXED

(Core :: Graphics: CanvasWebGL, defect)

Description

[Kelsey Gilbert [:jgilbert]]

ResizeOffscreenFBO does things other than resizing FBOs. It shouldn't, because other code begins to expect it to then do things that are not guaranteed.

One thing I see is that we are setting the viewport to the correct size the first time we run. Unfortunately, we're bad at determining when is the first time vs. subsequent times. This should be done in the code which initializes the context, not in resize code.

An early-out added in bug 615976 makes it very important we know what our guarantees are, and aren't.

Comment 1

[Kelsey Gilbert [:jgilbert]]

Attachment: Deguarantee ResizeOffscreenFBO sets the viewport on first run

We already set the viewport correctly for WebGL initialization.

Comment 2

[Kelsey Gilbert [:jgilbert]]

I will run this by try, then land it.

Comment 3

[Kelsey Gilbert [:jgilbert]]

Try run at https://tbpl.mozilla.org/?tree=Try&rev=e8b8a919fe13 is clean.

Comment 4

[Kelsey Gilbert [:jgilbert]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/c96f7298db5b

Comment 5

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/c96f7298db5b