Closed Bug 711841 Opened 8 years ago Closed 8 years ago
String() or Null String() or Null DOMString()
Atm, one needs to explicitly call SetIsVoid(). Would be nice to have something close to EmptyString()
Something like #define NullString() nsXPIDLString() #define NullCString() nsXPIDLCString()
Assignee: nobody → bugs
Or better to implement it like Empty(C)String
Since nsXPIDLString has the behavior anyway, we should be able to reuse that. https://tbpl.mozilla.org/?tree=Try&rev=ec49c8378fd2
This is not about a method which sets a string to null, but having a null string, which can be easily passed as a parameter to methods, or used in ctor member initialization.
Comment on attachment 582680 [details] [diff] [review] something like this glandium, will this cause a static ctor to run, and do you think that's a profile? Otherwise I think this is fine.
Attachment #582680 - Flags: review?(benjamin) → review?(mh+mozilla)
The patch as is won't cause a static ctor, but will cause a mutex being used each time NullString and NullCString are used.
IRC: glandium > smaug: mmm actually looking at the code gcc generates, it only acquires the lock if it the constant wasn't already initialized, so it's not as bad as i suggested That doesn't sound bad to me, and EmptyString has the same behavior.
Comment on attachment 582680 [details] [diff] [review] something like this rs=me
Attachment #582680 - Flags: review?(mh+mozilla) → review+
Status: NEW → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.