Closed
Bug 711903
Opened 13 years ago
Closed 13 years ago
EventUtils.synthesizeKey() shouldn't dispatch keypress event for modifier keys if the type isn't specified
Categories
(Core :: DOM: UI Events & Focus Handling, defect)
Core
DOM: UI Events & Focus Handling
Tracking
()
RESOLVED
FIXED
mozilla12
People
(Reporter: masayuki, Assigned: masayuki)
References
Details
Attachments
(2 files)
|
2.82 KB,
patch
|
smaug
:
review+
|
Details | Diff | Splinter Review |
|
3.73 KB,
patch
|
ehsan.akhgari
:
review+
|
Details | Diff | Splinter Review |
EventUtils.synthesizeKey() dispatches keydown event, keypress event and keyup event if the event type isn't specified. However, widgets don't dispatch keypress event for modifier keys. Therefore, it shouldn't dispatch it.
|
Assignee | |
Comment 1•13 years ago
|
||
Do you have a better idea for the name of "isKeypressFiredKey"?
Attachment #583070 -
Flags: review?(bugs)
|
|
Assignee | |
Comment 2•13 years ago
|
||
These tests should test the unexpected keypress events since some platforms may have the bug. # Is it better to insert an assertion in XP level code?
Attachment #583072 -
Flags: review?(ehsan)
|
||
Updated•13 years ago
|
Attachment #583072 -
Flags: review?(ehsan) → review+
|
||
Updated•13 years ago
|
Attachment #583070 -
Flags: review?(bugs) → review+
|
|
Assignee | |
Comment 3•13 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/9877c56df1a3 https://hg.mozilla.org/integration/mozilla-inbound/rev/eabdc8f1c344
Whiteboard: [inbound]
Target Milestone: --- → mozilla12
|
||
Comment 4•13 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/9877c56df1a3 https://hg.mozilla.org/mozilla-central/rev/eabdc8f1c344
Status: ASSIGNED → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
Whiteboard: [inbound]
|
||
Updated•5 years ago
|
Component: Event Handling → User events and focus handling
You need to log in
before you can comment on or make changes to this bug.
Description
•