Note: There are a few cases of duplicates in user autocompletion which are being worked on.

EventUtils.synthesizeKey() shouldn't dispatch keypress event for modifier keys if the type isn't specified

RESOLVED FIXED in mozilla12

Status

()

Core
Event Handling
RESOLVED FIXED
6 years ago
6 years ago

People

(Reporter: masayuki, Assigned: masayuki)

Tracking

Trunk
mozilla12
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(2 attachments)

EventUtils.synthesizeKey() dispatches keydown event, keypress event and keyup event if the event type isn't specified. However, widgets don't dispatch keypress event for modifier keys. Therefore, it shouldn't dispatch it.
Created attachment 583070 [details] [diff] [review]
Part.1 EventUtils.synthesizeKey() shouldn't dispatch keypress event for modifier keys if the event type isn't specified

Do you have a better idea for the name of "isKeypressFiredKey"?
Attachment #583070 - Flags: review?(bugs)
Created attachment 583072 [details] [diff] [review]
Part.2 Fix new test failure

These tests should test the unexpected keypress events since some platforms may have the bug.

# Is it better to insert an assertion in XP level code?
Attachment #583072 - Flags: review?(ehsan)
Attachment #583072 - Flags: review?(ehsan) → review+

Updated

6 years ago
Attachment #583070 - Flags: review?(bugs) → review+
https://hg.mozilla.org/integration/mozilla-inbound/rev/9877c56df1a3
https://hg.mozilla.org/integration/mozilla-inbound/rev/eabdc8f1c344
Whiteboard: [inbound]
Target Milestone: --- → mozilla12
https://hg.mozilla.org/mozilla-central/rev/9877c56df1a3
https://hg.mozilla.org/mozilla-central/rev/eabdc8f1c344
Status: ASSIGNED → RESOLVED
Last Resolved: 6 years ago
Resolution: --- → FIXED
Whiteboard: [inbound]
You need to log in before you can comment on or make changes to this bug.