Closed Bug 711954 Opened 8 years ago Closed 4 years ago

[skiplist] Add moz* DLLs to prefixSignatureRegEx

Categories

(Socorro :: Infra, task)

task
Not set

Tracking

(Not tracked)

RESOLVED INVALID

People

(Reporter: scoobidiver, Unassigned)

References

Details

(Whiteboard: [needs feedback from developers][qa-])

Please add:
'mozalloc.dll@0x.*'
'mozjs.dll@0x0x.*'
'mozutils.dll@0x.*'
to the skiplist as irrelevantSignatureRegEx
Blocks: 704488
No longer blocks: 704448
I'm pretty sure we don't want this on the irrelevant list. If we don't have symbols for a build, this would hide crashes in our own code - and even when we do, those crashes are possibly in our code, I wouldn't want to hide that fact. On the prefix list, this might make sense, though.
Hiding crashes places in our own code is not a solution for that. Finding out why we don't get symbols for those places is what we should try to solve.
(In reply to Robert Kaiser (:kairo@mozilla.com) from comment #3)
> Hiding crashes places in our own code is not a solution for that.
Filing duplicated bugs, which is the current way, is not the solution.
With the skiplist, stack traces won't be hidden and there's still the bug component to know where it belongs.
In addition, the crash signature is not skipped when there's nothing after.

> Finding out why we don't get symbols for those places is what we should try to
> solve.
File a bug for that.
(In reply to Scoobidiver from comment #4)
> (In reply to Robert Kaiser (:kairo@mozilla.com) from comment #3)
> > Hiding crashes places in our own code is not a solution for that.
> Filing duplicated bugs, which is the current way, is not the solution.

A bug should only ever be filed after searching if there is a similar one in existence - no matter if it's a crash or other bug.

> With the skiplist, stack traces won't be hidden and there's still the bug
> component to know where it belongs.

With a prefixList that's neither the case.

> > Finding out why we don't get symbols for those places is what we should try to
> > solve.
> File a bug for that.

I don't care who's filing it, but I strongly object to not showing those frames at all.
Component: Socorro → General
Product: Webtools → Socorro
Component: General → Infra
Blocks: 712726, 719104
Blocks: 725009
Blocks: 718192
I propose we add either moz.*\.dll.* or the three regexes in comment #0 to prefixSignatureRegEx here - Ted, Benjamin, does that sound reasonable, or would a different step be good here?
Summary: Add moz* DLLs to the skiplist as irrelevantSignatureRegEx → [skiplist] Add moz* DLLs to prefixSignatureRegEx
Whiteboard: [needs feedback from developers]
Another windows-y thing Kyle may have an opinion on...
(In reply to Kyle Huey [:khuey] (khuey@mozilla.com) from comment #8)
> Why don't we have symbols here?

I think we might have some for the files but possibly can't resolve them, my guess would be inlining or some stackwalking problems.
I think this is a bad idea and we should WONTFIX it. If we have stackwalking problems or symbol problems (beyond the MSVC 2010 issue we fixed), we should be fixing those, not trying to hide the symptoms.
(In reply to Ted Mielczarek [:ted] from comment #10)
> I think this is a bad idea and we should WONTFIX it. If we have stackwalking
> problems or symbol problems (beyond the MSVC 2010 issue we fixed), we should
> be fixing those, not trying to hide the symptoms.

As Scoobidiver has pointed out, we are getting enough of those reports. We have added xul.dll to the prefix list already because we had so many reports with it, I guess that's because of inlining or something like that. I guess we have similar things happening here.
Adding these to the prefix list isn't going to help anything. Instead of two crashes winding up with signatures:
1. [@ xul.dll@0x1234 ]
2. [@ xul.dll@0x4321 ]

you'd instead wind up with:
1. [@ xul.dll@0x1234 | something_else ]
2. [@ xul.dll@0x4321 | something_else ]

Which still won't get grouped together.
moz*.dll addresses move less often than xul.dll addresses.
In addition, Bugzilla allows you to group *.dll@address1 | signature1 and *.dll@address2 | signature1 while the *.dll@address1 and *.dll@address2 meta signatures aren't helpful.
(In reply to Ted Mielczarek [:ted] from comment #13)
> Adding these to the prefix list isn't going to help anything. Instead of two
> crashes winding up with signatures:
> 1. [@ xul.dll@0x1234 ]
> 2. [@ xul.dll@0x4321 ]
> 
> you'd instead wind up with:
> 1. [@ xul.dll@0x1234 | something_else ]
> 2. [@ xul.dll@0x4321 | something_else ]
> 
> Which still won't get grouped together.

Still, it gives a glance at the fact that something_else is the caller in all of them at a glance from all reports where you see signatures, and at the same time it doesn't make anything worse.
Blocks: 637269, 637270
Whiteboard: [needs feedback from developers] → [needs feedback from developers][qa-]
Resolving because too old.
Status: NEW → RESOLVED
Closed: 4 years ago
Resolution: --- → INVALID
You need to log in before you can comment on or make changes to this bug.