711954 - [skiplist] Add moz* DLLs to prefixSignatureRegEx

Status: RESOLVED INVALID

(Socorro :: Infra, task)

Description

[Scoobidiver (away)]

Please add:
'mozalloc.dll@0x.*'
'mozjs.dll@0x0x.*'
'mozutils.dll@0x.*'
to the skiplist as irrelevantSignatureRegEx

Comment 1

[Robert Kaiser]

I'm pretty sure we don't want this on the irrelevant list. If we don't have symbols for a build, this would hide crashes in our own code - and even when we do, those crashes are possibly in our code, I wouldn't want to hide that fact. On the prefix list, this might make sense, though.

Comment 2

[Scoobidiver (away)]

(In reply to Scoobidiver from comment #0)
> 'mozjs.dll@0x0x.*'
I meant 'mozjs.dll@0x.*'

(In reply to Robert Kaiser (:[e-mail]) from comment #1)
> On the prefix list, this might make sense, though.
The crash address move between each build, making almost impossible to track it across all Firefox versions.
See for instance bug 704488 that needs to be updated after each Beta and final versions.
See also:
https://crash-stats.mozilla.com/query/query?product=Firefox&version=ALL%3AALL&range_value=4&range_unit=weeks&query_search=signature&query_type=contains&query=mozalloc.dll%400x&reason=&build_id=&process_type=any&hang_type=any&do_query=1
https://crash-stats.mozilla.com/query/query?product=Firefox&version=ALL%3AALL&range_value=4&range_unit=weeks&query_search=signature&query_type=contains&query=mozjs.dll%400x&reason=&build_id=&process_type=any&hang_type=any&do_query=1
https://crash-stats.mozilla.com/query/query?product=Firefox&version=ALL%3AALL&range_value=4&range_unit=weeks&query_search=signature&query_type=contains&query=mozutils.dll%400x&reason=&build_id=&process_type=any&hang_type=any&do_query=1

Comment 3

[Robert Kaiser]

Hiding crashes places in our own code is not a solution for that. Finding out why we don't get symbols for those places is what we should try to solve.

Comment 4

[Scoobidiver (away)]

(In reply to Robert Kaiser (:[e-mail]) from comment #3)
> Hiding crashes places in our own code is not a solution for that.
Filing duplicated bugs, which is the current way, is not the solution.
With the skiplist, stack traces won't be hidden and there's still the bug component to know where it belongs.
In addition, the crash signature is not skipped when there's nothing after.

> Finding out why we don't get symbols for those places is what we should try to
> solve.
File a bug for that.

Comment 5

[Robert Kaiser]

(In reply to Scoobidiver from comment #4)
> (In reply to Robert Kaiser (:[e-mail]) from comment #3)
> > Hiding crashes places in our own code is not a solution for that.
> Filing duplicated bugs, which is the current way, is not the solution.

A bug should only ever be filed after searching if there is a similar one in existence - no matter if it's a crash or other bug.

> With the skiplist, stack traces won't be hidden and there's still the bug
> component to know where it belongs.

With a prefixList that's neither the case.

> > Finding out why we don't get symbols for those places is what we should try to
> > solve.
> File a bug for that.

I don't care who's filing it, but I strongly object to not showing those frames at all.

Comment 6

[Robert Kaiser]

I propose we add either moz.*\.dll.* or the three regexes in comment #0 to prefixSignatureRegEx here - Ted, Benjamin, does that sound reasonable, or would a different step be good here?

Comment 7

[Andrew McCreight [:mccr8]]

Another windows-y thing Kyle may have an opinion on...

Comment 8

[Kyle Huey (Exited; not receiving bugmail, old account, do not use)]

Why don't we have symbols here?

Comment 9

[Robert Kaiser]

(In reply to Kyle Huey [:khuey] ([e-mail]) from comment #8)
> Why don't we have symbols here?

I think we might have some for the files but possibly can't resolve them, my guess would be inlining or some stackwalking problems.

Comment 10

[(not currently active) Ted Mielczarek]

I think this is a bad idea and we should WONTFIX it. If we have stackwalking problems or symbol problems (beyond the MSVC 2010 issue we fixed), we should be fixing those, not trying to hide the symptoms.

Comment 11

[Scoobidiver (away)]

(In reply to Ted Mielczarek [:ted] from comment #10)
> If we have stackwalking problems or symbol problems (beyond the MSVC 2010 
> issue we fixed), we should be fixing those
They are there:
https://crash-stats.mozilla.com/query/query?product=Firefox&version=ALL%3AALL&range_value=4&range_unit=weeks&query_search=signature&query_type=contains&query=mozalloc.dll&reason=&build_id=&process_type=any&hang_type=any&do_query=1
https://crash-stats.mozilla.com/query/query?product=Firefox&version=ALL%3AALL&range_value=4&range_unit=weeks&query_search=signature&query_type=contains&query=mozjs.dll&reason=&build_id=&process_type=any&hang_type=any&do_query=1
https://crash-stats.mozilla.com/query/query?product=Firefox&version=ALL%3AALL&range_value=4&range_unit=weeks&query_search=signature&query_type=contains&query=mozutils.dll&reason=&build_id=&process_type=any&hang_type=any&do_query=1

> not trying to hide the symptoms.
It's valid for the ignore skiplist, but not for the prefix skiplist that allows you to breakdown signatures.

Comment 12

[Robert Kaiser]

(In reply to Ted Mielczarek [:ted] from comment #10)
> I think this is a bad idea and we should WONTFIX it. If we have stackwalking
> problems or symbol problems (beyond the MSVC 2010 issue we fixed), we should
> be fixing those, not trying to hide the symptoms.

As Scoobidiver has pointed out, we are getting enough of those reports. We have added xul.dll to the prefix list already because we had so many reports with it, I guess that's because of inlining or something like that. I guess we have similar things happening here.

Comment 13

[(not currently active) Ted Mielczarek]

Adding these to the prefix list isn't going to help anything. Instead of two crashes winding up with signatures:
1. [@ xul.dll@0x1234 ]
2. [@ xul.dll@0x4321 ]

you'd instead wind up with:
1. [@ xul.dll@0x1234 | something_else ]
2. [@ xul.dll@0x4321 | something_else ]

Which still won't get grouped together.

Comment 14

[Scoobidiver (away)]

moz*.dll addresses move less often than xul.dll addresses.
In addition, Bugzilla allows you to group *.dll@address1 | signature1 and *.dll@address2 | signature1 while the *.dll@address1 and *.dll@address2 meta signatures aren't helpful.

Comment 15

[Robert Kaiser]

(In reply to Ted Mielczarek [:ted] from comment #13)
> Adding these to the prefix list isn't going to help anything. Instead of two
> crashes winding up with signatures:
> 1. [@ xul.dll@0x1234 ]
> 2. [@ xul.dll@0x4321 ]
> 
> you'd instead wind up with:
> 1. [@ xul.dll@0x1234 | something_else ]
> 2. [@ xul.dll@0x4321 | something_else ]
> 
> Which still won't get grouped together.

Still, it gives a glance at the fact that something_else is the caller in all of them at a glance from all reports where you see signatures, and at the same time it doesn't make anything worse.

Comment 16

[Peter Bengtsson [:peterbe]]

Resolving because too old.