711958 - Add a 'length' property to DOMSVGStringList

Status: RESOLVED FIXED

(Core :: SVG, defect)

Description

[Jonathan Watt [:jwatt]]

Follow-up from the last comment in bug 607854 comment 7. For consistency with the other list classes, we should add a 'length' property to DOMSVGStringList to mirror the 'numberOfItems' property.

Comment 1

[Jonathan Watt [:jwatt]]

Attachment: patch

Comment 2

[Daniel Holbert [:dholbert]]

Comment on attachment 592131 [details] [diff] [review]
patch

Looks good!

Just one thing -- fix end-of-line whitespace after "GetNumberOfItems(aLength);" here:
> NS_IMETHODIMP
>+DOMSVGStringList::GetLength(PRUint32 *aLength)
>+{
>+  return GetNumberOfItems(aLength);  
>+}

r=me with that

Comment 3

[Joe Drew (not getting mail)]

https://hg.mozilla.org/mozilla-central/rev/b939fbd0a46f

Comment 4

[Eric Shepherd [:sheppy]]

I've documented this here, flagged as non-standard, since it's not in the spec.

https://developer.mozilla.org/en/DOM/SVGStringList

Also mentioned on Firefox 12 for developers.

Comment 5

[Jeremie Patonnier :Jeremie]

I added a note on https://developer.mozilla.org/en/Firefox_12_for_developers
I assumed that SVGStringList is also indexable as an Array. Am I right?

Comment 6

[Jeremie Patonnier :Jeremie]

(In reply to Jeremie Patonnier from comment #5)
> I assumed that SVGStringList is also indexable as an Array. Am I right?
Sorry for the noise, Array style indexing is bug #722071