Closed Bug 711958 Opened 8 years ago Closed 8 years ago

Add a 'length' property to DOMSVGStringList

Categories

(Core :: SVG, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
mozilla12

People

(Reporter: jwatt, Assigned: jwatt)

References

Details

(Keywords: dev-doc-complete)

Attachments

(1 file)

Follow-up from the last comment in bug 607854 comment 7. For consistency with the other list classes, we should add a 'length' property to DOMSVGStringList to mirror the 'numberOfItems' property.
Attached patch patchSplinter Review
Assignee: nobody → jwatt
Status: NEW → ASSIGNED
Attachment #592131 - Flags: review?(dholbert)
Comment on attachment 592131 [details] [diff] [review]
patch

Looks good!

Just one thing -- fix end-of-line whitespace after "GetNumberOfItems(aLength);" here:
> NS_IMETHODIMP
>+DOMSVGStringList::GetLength(PRUint32 *aLength)
>+{
>+  return GetNumberOfItems(aLength);  
>+}

r=me with that
Attachment #592131 - Flags: review?(dholbert) → review+
https://hg.mozilla.org/mozilla-central/rev/b939fbd0a46f
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla12
I've documented this here, flagged as non-standard, since it's not in the spec.

https://developer.mozilla.org/en/DOM/SVGStringList

Also mentioned on Firefox 12 for developers.
I added a note on https://developer.mozilla.org/en/Firefox_12_for_developers
I assumed that SVGStringList is also indexable as an Array. Am I right?
(In reply to Jeremie Patonnier from comment #5)
> I assumed that SVGStringList is also indexable as an Array. Am I right?
Sorry for the noise, Array style indexing is bug #722071
You need to log in before you can comment on or make changes to this bug.