Closed Bug 711993 Opened 12 years ago Closed 12 years ago

Check to make sure we have a valid URI in PermissionsHelper observer

Categories

(Firefox for Android Graveyard :: General, defect, P2)

Product:
Firefox for Android Graveyard
Component:
General
Platform:
All
Android
Type:
defect

Tracking

(firefox11 fixed, firefox12 fixed)

Status:
RESOLVED FIXED
Milestone:
Firefox 12
Tracking Flags:
Tracking Status
firefox11 --- fixed
firefox12 --- fixed

People

(Reporter: Margaret, Assigned: Margaret)

References

Details

Attachments

(1 file)

patch
1.21 KB, patch
mfinkle
: review+
akeybl
: approval-mozilla-aurora+
Details | Diff | Splinter Review 
We're getting an error on about: pages. For Permissions:Get, we should probably just return an empty permissions array in this case, and for Permissions:Clear, we can just return.
Assignee: nobody → margaret.leibovic
Depends on: 706876
Priority: -- → P4
Upping to P2, since bug 716979 is a dupe.
tracking-fennec: --- → ?
Priority: P4 → P2
Attached patch patch — — Splinter Review 
Actually, this bug is wrong as described. The only thing that will throw an exception is getting the host on an invalid URI. Also, we don't need to worry about fixing anything in the Permissions:Clear handler, because if we never got permissions in Permissions:Get because of a bad URI, clearPermission will never even get called.

The host string here is only used for display in the dialog title, so I figured we could just use the spec instead. Once bug 711774 is fixed, this won't even be an issue anymore because we'll never even end up enabling the menuitem for these bad URIs.
Attachment #588172 - Flags: review?(mark.finkle)
Attachment #588172 - Flags: review?(mark.finkle) → review+
https://hg.mozilla.org/mozilla-central/rev/40993c4c18d0
Status: NEW → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 12
Comment on attachment 588172 [details] [diff] [review]
patch

[Approval Request Comment]
Low-risk. This catches an exception you can run into on about: pages.
Attachment #588172 - Flags: approval-mozilla-aurora?
Comment on attachment 588172 [details] [diff] [review]
patch

[Triage Comment]
Mobile only - approved for Aurora.
Attachment #588172 - Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
tracking-fennec: - → ---
Product: Firefox for Android → Firefox for Android Graveyard
You need to log in before you can comment on or make changes to this bug.