Check to make sure we have a valid URI in PermissionsHelper observer

RESOLVED FIXED in Firefox 11

Status

()

Firefox for Android
General
P2
normal
RESOLVED FIXED
6 years ago
a year ago

People

(Reporter: Margaret, Assigned: Margaret)

Tracking

unspecified
Firefox 12
All
Android
Points:
---

Firefox Tracking Flags

(firefox11 fixed, firefox12 fixed)

Details

Attachments

(1 attachment)

(Assignee)

Description

6 years ago
We're getting an error on about: pages. For Permissions:Get, we should probably just return an empty permissions array in this case, and for Permissions:Clear, we can just return.
(Assignee)

Updated

6 years ago
Assignee: nobody → margaret.leibovic
Depends on: 706876
Priority: -- → P4
(Assignee)

Updated

6 years ago
Duplicate of this bug: 716979
(Assignee)

Comment 2

6 years ago
Upping to P2, since bug 716979 is a dupe.
tracking-fennec: --- → ?
Priority: P4 → P2
(Assignee)

Comment 3

6 years ago
Created attachment 588172 [details] [diff] [review]
patch

Actually, this bug is wrong as described. The only thing that will throw an exception is getting the host on an invalid URI. Also, we don't need to worry about fixing anything in the Permissions:Clear handler, because if we never got permissions in Permissions:Get because of a bad URI, clearPermission will never even get called.

The host string here is only used for display in the dialog title, so I figured we could just use the spec instead. Once bug 711774 is fixed, this won't even be an issue anymore because we'll never even end up enabling the menuitem for these bad URIs.
Attachment #588172 - Flags: review?(mark.finkle)
Attachment #588172 - Flags: review?(mark.finkle) → review+
(Assignee)

Comment 4

6 years ago
https://hg.mozilla.org/integration/mozilla-inbound/rev/40993c4c18d0
https://hg.mozilla.org/mozilla-central/rev/40993c4c18d0
Status: NEW → RESOLVED
Last Resolved: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 12
(Assignee)

Comment 6

6 years ago
Comment on attachment 588172 [details] [diff] [review]
patch

[Approval Request Comment]
Low-risk. This catches an exception you can run into on about: pages.
Attachment #588172 - Flags: approval-mozilla-aurora?

Comment 7

6 years ago
Comment on attachment 588172 [details] [diff] [review]
patch

[Triage Comment]
Mobile only - approved for Aurora.
Attachment #588172 - Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
https://hg.mozilla.org/releases/mozilla-aurora/rev/148296d69323
tracking-fennec: ? → -
status-firefox11: --- → fixed
status-firefox12: --- → fixed
tracking-fennec: - → ---
You need to log in before you can comment on or make changes to this bug.