712100 - Peptest doesn't install or launch on OSX

Status: RESOLVED FIXED

(Testing Graveyard :: Peptest, defect)

Description

[Aki Sasaki (not active)]

From bug 700415 comment 51:

On leopard:
17:43:12     INFO - Downloading http://ftp.mozilla.org/pub/mozilla.org/firefox/tinderbox-builds/mozilla-central-macosx64/1323973575//firefox-11.0a1.en-US.mac.dmg
17:43:18     INFO - Getting output from command: ['/Users/cltbld/talos-slave/test/build/venv/bin/mozinstall', '--source', '/Users/cltbld/talos-slave/test/firefox-11.0a1.en-US.mac.dmg', '--destination', '/Users/cltbld/talos-slave/test/build/application']
17:43:37     INFO - Output received:
17:43:37     INFO -  None

(mozinstall doesn't work from buildbot; works from the commandline.)

From bug 700415 comment 52:

Leopard: mozinstall works if I try it twice, and then I hit a dyld error:

18:15:08     INFO - Downloading http://ftp.mozilla.org/pub/mozilla.org/firefox/tinderbox-builds/mozilla-central-macosx64/1323973575//firefox-11.0a1.en-US.mac.dmg
18:15:13     INFO - Running command: ['/Users/cltbld/talos-slave/test/build/venv/bin/mozinstall', '--source', '/Users/cltbld/talos-slave/test/firefox-11.0a1.en-US.mac.dmg', '--destination', '/Users/cltbld/talos-slave/test/build/application']
18:15:32     INFO -  None
18:15:32     INFO - Return code: 0
18:15:32     INFO - Getting output from command: ['/Users/cltbld/talos-slave/test/build/venv/bin/mozinstall', '--source', '/Users/cltbld/talos-slave/test/firefox-11.0a1.en-US.mac.dmg', '--destination', '/Users/cltbld/talos-slave/test/build/application']
18:15:45     INFO - Output received:
18:15:45     INFO -  /Users/cltbld/talos-slave/test/build/application/Nightly.app/Contents/MacOS/firefox
18:15:45     INFO - rmtree: tmpfile_stderr
18:15:45     INFO - rmtree: tmpfile_stdout
18:15:45     INFO - Running command: ['/Users/cltbld/talos-slave/test/build/venv/bin/peptest', '--app', 'firefox', '--binary', '/Users/cltbld/talos-slave/test/build/application/Nightly.app/Contents/MacOS/firefox', '--test-path', '/Users/cltbld/talos-slave/test/build/tests/peptest/tests/firefox/firefox_all.ini', '--timeout', '60', '--tracer-threshold', '50', '--tracer-interval', '10', '--log-level', 'INFO']
18:15:47     INFO -  dyld: unknown required load command 0x80000022

Comment 1

[Aki Sasaki (not active)]

The dyld issue may be fixed by calling arch:

['arch', '-arch', 'i386', '/Users/cltbld/talos-slave/test/build/FirefoxNightly.app/Contents/MacOS/firefox-bin', '-foreground', '-no-remote', '-profile', '/var/folders/Xr/Xr--yJnSEY0U11ET5NZuMU+++TM/-Tmp-/tmpeEG-fF/', 'http://mochi.test:8888/tests/?autorun=1&closeWhenDone=1&consoleLevel=INFO&totalChunks=5&thisChunk=1&chunkByDir=4&hideResultsTable=1']

I sent ahal a sendchange script that will help him test the mozinstall portion via buildbot.

Comment 2

[(not currently active) Ted Mielczarek]

The leopard issue is one we've worked around in Talos/automation before, see bug 598507. The relevant bits in automationutils are here:
http://mxr.mozilla.org/mozilla-central/source/build/automationutils.py#441

We probably just need to yank that bit into mozprocess/mozrunner.

Comment 3

[Aki Sasaki (not active)]

Leopard and Lion are now orange instead of red ! :)

Snow leopard, however, gets this:

10:35:40     INFO - #####
10:35:40     INFO - ##### Running create-deps step.
10:35:40     INFO - #####
10:35:40     INFO - Downloading http://people.mozilla.com/~ahalberstadt/firefox-11.0a1.en-US.mac.tests.zip
10:35:44     INFO - mkdir: /Users/cltbld/talos-slave/test/build/tests
10:35:44     INFO - Extracting /Users/cltbld/talos-slave/test/firefox-11.0a1.en-US.mac.tests.zip to /Users/cltbld/talos-slave/test/build/tests
Traceback (most recent call last):
  File "scripts/scripts/peptest.py", line 355, in <module>
    peptest.run()
  File "/Users/cltbld/talos-slave/test/scripts/mozharness/base/script.py", line 624, in run
    self._possibly_run_method(method_name, error_if_missing=True)
  File "/Users/cltbld/talos-slave/test/scripts/mozharness/base/script.py", line 595, in _possibly_run_method
    return getattr(self, method_name)()
  File "scripts/scripts/peptest.py", line 243, in create_deps
    delete=False)
  File "/Users/cltbld/talos-slave/test/scripts/mozharness/base/script.py", line 205, in extract
    bundle.extractall(path=extdir)
  File "/System/Library/Frameworks/Python.framework/Versions/2.6/lib/python2.6/zipfile.py", line 940, in extractall
    self.extract(zipinfo, path, pwd)
  File "/System/Library/Frameworks/Python.framework/Versions/2.6/lib/python2.6/zipfile.py", line 928, in extract
    return self._extract_member(member, path, pwd)
  File "/System/Library/Frameworks/Python.framework/Versions/2.6/lib/python2.6/zipfile.py", line 965, in _extract_member
    target = file(targetpath, "wb")
IOError: [Errno 20] Not a directory: '/Users/cltbld/talos-slave/test/build/tests/bin/xpcshell'

Comment 4

[Andrew Halberstadt [:ahal]]

Attachment: Patch 1.0 - Wrap command with 'arch' on Leopard and below

I copied the code in ted's comment. I'm not entirely sure if/how it is possible to extract just the version number from mozinfo, so it uses platform.

Comment 5

[Aki Sasaki (not active)]

(In reply to Aki Sasaki [:aki] from comment #3)
> Snow leopard, however, gets this:

Fixed with http://hg.mozilla.org/users/asasaki_mozilla.com/mozharness/rev/34dc7a9e83de .

Comment 6

[Jeff Hammel]

Comment on attachment 583556 [details] [diff] [review]
Patch 1.0 - Wrap command with 'arch' on Leopard and below

+        if mozinfo.isMac() and hasattr(platform, 'mac_ver') and \
+                               platform.mac_ver()[0][:4] < '10.6':

We should upstream this to mozinfo.  Please write a bug dictating the need

Also, mozinfo.isMac is not a function:

(mozmill)│python -c 'import mozinfo; print mozinfo.isMac'
False

r+ with the isMac() -> isMac and the followup bug for mozinfo

Comment 7

[Andrew Halberstadt [:ahal]]

Oh weird, I thought I had fixed the isMac() thing. I must have forgot to make a new diff.

Anyway, master: https://github.com/mozilla/mozbase/commit/4b8fb1a3678dc4805f5eab139ea89f2224faac30