712115 - L10n mac nightlies busted on central and aurora

Status: VERIFIED FIXED

(Release Engineering :: General, defect, P1)

Description

[Axel Hecht [:Pike]]

Right now, the l10n nightlies are busted for mac, they can't find the stage dir.

Suspect would be bug 696436, as http://l10n.mozilla-community.org/~axel/nightlies/?date=2011-12-16 is green and http://l10n.mozilla-community.org/~axel/nightlies/?date=2011-12-17 is red.

Comment 1

[Axel Hecht [:Pike]]

So, yes, it seems like 696436 is the culprit.

The mozconfigs in the tree got an additional argument, 
ac_add_options --with-macbundlename-prefix=Firefox
https://hg.mozilla.org/releases/mozilla-aurora/diff/bd759f82e517/browser/config/mozconfigs/macosx-universal/nightly

Now, the l10n builds don't use a mozconfig but http://hg.mozilla.org/build/buildbotcustom/file/tip/process/factory.py#l3059.

Thus we need to fix this on the releng side :-/

Worse still, I have no idea how right now, as this needs to apply only for some branches, AFAICT?

Gavin, can you lay out what really needs to be impacted here?

Comment 2

[:Gavin Sharp [email: [e-mail]]]

Nightly and Aurora nightly mozconfigs on Mac now have --with-bundlename-prefix=Firefox specified, which modifies the value of MOZ_MACBUNDLE_NAME. I guess the easy fix would be to just add the same flag to the l10n pseudo-configs... It doesn't have any effect on non-Mac, so you could probably just add it everywhere.

Having these configs not be in sync is probably going to be a problem in the long-term, of course.

Comment 3

[Armen [:armenzg]]

Attachment: add --with-bundlename-prefix=Firefox to m-c and m-a

Comment 4

[Armen [:armenzg]]

Attachment: accept extraConfigureArgs variable and use it for L10n nightly builds

Comment 5

[Aki Sasaki (not active)]

Comment on attachment 583282 [details] [diff] [review]
add --with-bundlename-prefix=Firefox to m-c and m-a

Per IRC, I don't like the naming, but r=me if we name this l10n_extra_configure_args.

Comment 6

[Aki Sasaki (not active)]

Comment on attachment 583286 [details] [diff] [review]
accept extraConfigureArgs variable and use it for L10n nightly builds

Same here.

Comment 7

[Armen [:armenzg]]

Comment on attachment 583282 [details] [diff] [review]
add --with-bundlename-prefix=Firefox to m-c and m-a

http://hg.mozilla.org/build/buildbotcustom/rev/12a44c7cc07e

Comment 8

[Armen [:armenzg]]

Comment on attachment 583286 [details] [diff] [review]
accept extraConfigureArgs variable and use it for L10n nightly builds

http://hg.mozilla.org/build/buildbot-configs/rev/e122370afc64

Comment 9

[[e-mail] (:bhearsum)]

This made it to production tonight.

Comment 10

[Armen [:armenzg]]

I see some of the jobs going red.
I will clobber and see how it continues.

Comment 11

[Armen [:armenzg]]

I see tons of green.

This is working now:
http://tinderbox.mozilla.org/showlog.cgi?log=Mozilla-l10n-bn-IN/1324481280.1324481998.7149.gz&fulltext=1

Comment 12

[Axel Hecht [:Pike]]

http://ftp.mozilla.org/pub/mozilla.org/firefox/nightly/2011/12/2011-12-21-03-12-26-mozilla-central-l10n/ shows builds, but no partial. Also https://aus3.mozilla.org/update/3/Firefox/11.0a1/20111216031140/Darwin_x86_64-gcc3-u-i386-x86_64/de/nightly/Darwin%2010.8.0/default/default/update.xml?force=1 is empty.

So, while there are builds, I don't get get anything on my update channel for mac de nightly :-/

Comment 13

[Armen [:armenzg]]

Did you get any updates today?

Please file a separate bug if you still do.

Comment 14

[Axel Hecht [:Pike]]

Works again, thanks.