Form autocomplete is broken because we're not receiving compositionupdate events

RESOLVED FIXED in Firefox 11

Status

()

Firefox for Android
General
P2
normal
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: Margaret, Assigned: alexp)

Tracking

unspecified
Firefox 12
All
Android
Points:
---

Firefox Tracking Flags

(firefox11 fixed, firefox12 fixed, fennec11+)

Details

Attachments

(1 attachment)

(Reporter)

Description

5 years ago
After recent IME work landed, we don't dispatch composition events, but we depend on that in FormAssistant to show autocomplete suggestions.
Alex - Can you see if we should still be firing composition events. If not, should we be firing other key events and/or input events?
Assignee: nobody → alexp
Priority: -- → P2
(Assignee)

Comment 2

5 years ago
We do fire the NS_TEXT_TEXT event, but there is no corresponding nsIDOM* object, so it's visible as a simple UIEvent in JS.

I've been looking at an option to fire composition events. They trigger some input handling logic, which causes unwanted side-effects with this new approach. I'll make another try, as apparently composition events are important.
(Assignee)

Comment 3

5 years ago
Created attachment 583347 [details] [diff] [review]
Fix

This patch fixes the issue.
I don't really like this approach - it causes NS_COMPOSITION_START and NS_COMPOSITION_END events to be sent on every character, but it works, so can be used, at least as a short-term solution.
I'll continue looking into this.
Attachment #583347 - Flags: review?(blassey.bugs)
Attachment #583347 - Flags: review?(blassey.bugs) → review+
(Assignee)

Comment 4

5 years ago
https://hg.mozilla.org/integration/mozilla-inbound/rev/5f5815c42a83
Whiteboard: [fennec-aurora]

Comment 5

5 years ago
https://hg.mozilla.org/mozilla-central/rev/5f5815c42a83
Status: NEW → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 12
(Assignee)

Updated

5 years ago
Attachment #583347 - Flags: approval-mozilla-aurora?
(Assignee)

Updated

5 years ago
status-firefox11: --- → affected
tracking-firefox11: --- → ?
Attachment #583347 - Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
(Reporter)

Comment 6

5 years ago
https://hg.mozilla.org/releases/mozilla-aurora/rev/733f58c9368f
status-firefox11: affected → fixed
tracking-fennec: --- → 11+
status-firefox12: --- → fixed
tracking-firefox11: ? → ---
Whiteboard: [fennec-aurora]
You need to log in before you can comment on or make changes to this bug.