Closed
Bug 712118
Opened 12 years ago
Closed 12 years ago
Form autocomplete is broken because we're not receiving compositionupdate events
Categories
(Firefox for Android Graveyard :: General, defect, P2)
Tracking
(firefox11 fixed, firefox12 fixed, fennec11+)
RESOLVED
FIXED
Firefox 12
People
(Reporter: Margaret, Assigned: alexp)
Details
Attachments
(1 file)
1.58 KB,
patch
|
blassey
:
review+
blassey
:
approval-mozilla-aurora+
|
Details | Diff | Splinter Review |
After recent IME work landed, we don't dispatch composition events, but we depend on that in FormAssistant to show autocomplete suggestions.
Comment 1•12 years ago
|
||
Alex - Can you see if we should still be firing composition events. If not, should we be firing other key events and/or input events?
Assignee: nobody → alexp
Priority: -- → P2
Assignee | ||
Comment 2•12 years ago
|
||
We do fire the NS_TEXT_TEXT event, but there is no corresponding nsIDOM* object, so it's visible as a simple UIEvent in JS. I've been looking at an option to fire composition events. They trigger some input handling logic, which causes unwanted side-effects with this new approach. I'll make another try, as apparently composition events are important.
Assignee | ||
Comment 3•12 years ago
|
||
This patch fixes the issue. I don't really like this approach - it causes NS_COMPOSITION_START and NS_COMPOSITION_END events to be sent on every character, but it works, so can be used, at least as a short-term solution. I'll continue looking into this.
Attachment #583347 -
Flags: review?(blassey.bugs)
Updated•12 years ago
|
Attachment #583347 -
Flags: review?(blassey.bugs) → review+
Assignee | ||
Comment 4•12 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/5f5815c42a83
Updated•12 years ago
|
Whiteboard: [fennec-aurora]
Comment 5•12 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/5f5815c42a83
Status: NEW → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 12
Assignee | ||
Updated•12 years ago
|
Attachment #583347 -
Flags: approval-mozilla-aurora?
Assignee | ||
Updated•12 years ago
|
status-firefox11:
--- → affected
tracking-firefox11:
--- → ?
Updated•12 years ago
|
Attachment #583347 -
Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
Reporter | ||
Comment 6•12 years ago
|
||
https://hg.mozilla.org/releases/mozilla-aurora/rev/733f58c9368f
Updated•12 years ago
|
tracking-fennec: --- → 11+
Updated•12 years ago
|
Updated•3 years ago
|
Product: Firefox for Android → Firefox for Android Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•