Closed Bug 712118 Opened 12 years ago Closed 12 years ago

Form autocomplete is broken because we're not receiving compositionupdate events


(Firefox for Android Graveyard :: General, defect, P2)



(firefox11 fixed, firefox12 fixed, fennec11+)

Firefox 12
Tracking Status
firefox11 --- fixed
firefox12 --- fixed
fennec 11+ ---


(Reporter: Margaret, Assigned: alexp)



(1 file)

After recent IME work landed, we don't dispatch composition events, but we depend on that in FormAssistant to show autocomplete suggestions.
Alex - Can you see if we should still be firing composition events. If not, should we be firing other key events and/or input events?
Assignee: nobody → alexp
Priority: -- → P2
We do fire the NS_TEXT_TEXT event, but there is no corresponding nsIDOM* object, so it's visible as a simple UIEvent in JS.

I've been looking at an option to fire composition events. They trigger some input handling logic, which causes unwanted side-effects with this new approach. I'll make another try, as apparently composition events are important.
Attached patch FixSplinter Review
This patch fixes the issue.
I don't really like this approach - it causes NS_COMPOSITION_START and NS_COMPOSITION_END events to be sent on every character, but it works, so can be used, at least as a short-term solution.
I'll continue looking into this.
Attachment #583347 - Flags: review?(blassey.bugs)
Attachment #583347 - Flags: review?(blassey.bugs) → review+
Whiteboard: [fennec-aurora]
Closed: 12 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 12
Attachment #583347 - Flags: approval-mozilla-aurora?
Attachment #583347 - Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
tracking-fennec: --- → 11+
Whiteboard: [fennec-aurora]
Product: Firefox for Android → Firefox for Android Graveyard
You need to log in before you can comment on or make changes to this bug.