The default bug view has changed. See this FAQ.

Return correct websocket close code when browser navigates away from page.

RESOLVED FIXED in mozilla12

Status

()

Core
Networking: WebSockets
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: jduell, Assigned: jduell)

Tracking

({dev-doc-complete})

unspecified
mozilla12
dev-doc-complete
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

Created attachment 583028 [details] [diff] [review]
Return correct websocket close code when brower navigates away from page

Right now we close with 1000 (CLOSE_NORMAL) if Cancel is called.  But the IETF spec provides a code (1002: GOING_AWAY) for exactly this case.

No easy way to test this automatically (we'd have to rig pywebsocket to report failure/success: doesn't seem worth the considerable effort and code fork)--I will test by hand.

We could provide an error string here if we want in addition to the code, but spec says it's optional, and I don't think we need it.
Attachment #583028 - Flags: review?(bugs)
Attachment #583028 - Flags: review?(bugs) → review+
(Assignee)

Comment 1

5 years ago
https://hg.mozilla.org/integration/mozilla-inbound/rev/ed6e4d7917fb
https://hg.mozilla.org/mozilla-central/rev/ed6e4d7917fb
Assignee: nobody → jduell.mcbugs
Status: NEW → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla12
Keywords: dev-doc-needed
Noted here:

https://developer.mozilla.org/en/WebSockets/WebSockets_reference/CloseEvent#Gecko_notes

Also mentioned on Firefox 12 for developers.
Keywords: dev-doc-needed → dev-doc-complete
You need to log in before you can comment on or make changes to this bug.