Closed Bug 712188 Opened 8 years ago Closed 8 years ago

Return correct websocket close code when browser navigates away from page.

Categories

(Core :: Networking: WebSockets, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
mozilla12

People

(Reporter: jduell.mcbugs, Assigned: jduell.mcbugs)

Details

(Keywords: dev-doc-complete)

Attachments

(1 file)

Right now we close with 1000 (CLOSE_NORMAL) if Cancel is called.  But the IETF spec provides a code (1002: GOING_AWAY) for exactly this case.

No easy way to test this automatically (we'd have to rig pywebsocket to report failure/success: doesn't seem worth the considerable effort and code fork)--I will test by hand.

We could provide an error string here if we want in addition to the code, but spec says it's optional, and I don't think we need it.
Attachment #583028 - Flags: review?(bugs)
Attachment #583028 - Flags: review?(bugs) → review+
https://hg.mozilla.org/mozilla-central/rev/ed6e4d7917fb
Assignee: nobody → jduell.mcbugs
Status: NEW → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla12
You need to log in before you can comment on or make changes to this bug.