712188 - Return correct websocket close code when browser navigates away from page.

Status: RESOLVED FIXED

(Core :: Networking: WebSockets, defect)

Description

[Jason Duell]

Attachment: Return correct websocket close code when brower navigates away from page

Right now we close with 1000 (CLOSE_NORMAL) if Cancel is called.  But the IETF spec provides a code (1002: GOING_AWAY) for exactly this case.

No easy way to test this automatically (we'd have to rig pywebsocket to report failure/success: doesn't seem worth the considerable effort and code fork)--I will test by hand.

We could provide an error string here if we want in addition to the code, but spec says it's optional, and I don't think we need it.

Comment 1

[Jason Duell]

https://hg.mozilla.org/integration/mozilla-inbound/rev/ed6e4d7917fb

Comment 2

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/ed6e4d7917fb

Comment 3

[Eric Shepherd [:sheppy]]

Noted here:

https://developer.mozilla.org/en/WebSockets/WebSockets_reference/CloseEvent#Gecko_notes

Also mentioned on Firefox 12 for developers.