Last Comment Bug 712223 - [highlighter] Breadcrumbs bar doesn't always have the same size on Windows and Linux
: [highlighter] Breadcrumbs bar doesn't always have the same size on Windows an...
Status: RESOLVED FIXED
:
Product: Firefox
Classification: Client Software
Component: Developer Tools: Inspector (show other bugs)
: unspecified
: All All
: -- normal (vote)
: ---
Assigned To: Paul Rouget [:paul]
:
Mentors:
Depends on:
Blocks: 708257
  Show dependency treegraph
 
Reported: 2011-12-19 23:08 PST by Victor Porof [:vporof][:vp]
Modified: 2012-01-31 01:23 PST (History)
5 users (show)
See Also:
Crash Signature:
(edit)
QA Whiteboard:
Iteration: ---
Points: ---
Has Regression Range: ---
Has STR: ---


Attachments
example (160.95 KB, video/webm)
2011-12-19 23:08 PST, Victor Porof [:vporof][:vp]
no flags Details
patch - v1 (1.95 KB, patch)
2012-01-13 21:09 PST, Paul Rouget [:paul]
jwalker: review+
dao+bmo: review+
Details | Diff | Splinter Review

Description Victor Porof [:vporof][:vp] 2011-12-19 23:08:37 PST
Created attachment 583083 [details]
example

When the depth of the selected element in the tree is too big, the breadcrumbs bar increases in size. Perhaps this shouldn't happen? (It's ugly)
Comment 1 Paul Rouget [:paul] 2011-12-20 02:21:46 PST
This happens when the arrows appear. I think I know how to fix that.
Comment 2 Paul Rouget [:paul] 2012-01-13 21:09:01 PST
Created attachment 588596 [details] [diff] [review]
patch - v1
Comment 3 Joe Walker [:jwalker] (needinfo me or ping on irc) 2012-01-14 02:26:20 PST
Comment on attachment 588596 [details] [diff] [review]
patch - v1

Review of attachment 588596 [details] [diff] [review]:
-----------------------------------------------------------------

We should have a team discussion about -moz-appearance and theme/content split. However I'm happy to approve this anyway, lets discuss it when I get back.

I'm a little unclear if I'm allowed to r+ this, or I should f+ it. I'll be away soon, so I'll let you work out which type of + it should be.
Comment 4 Dão Gottwald [:dao] 2012-01-14 02:44:32 PST
(In reply to Joe Walker from comment #3)
> We should have a team discussion about -moz-appearance and theme/content
> split.

-moz-appearance values aren't implemented and don't behave consistently across platforms, so this needs to be in theme files. In fact, I'm not sure this bug affects Linux. Does it?
Comment 5 Joe Walker [:jwalker] (needinfo me or ping on irc) 2012-01-14 03:34:02 PST
(In reply to Dão Gottwald [:dao] from comment #4)
> (In reply to Joe Walker from comment #3)
> > We should have a team discussion about -moz-appearance and theme/content
> > split.
> 
> -moz-appearance values aren't implemented and don't behave consistently
> across platforms, so this needs to be in theme files. In fact, I'm not sure
> this bug affects Linux. Does it?

I wasn't aware that -moz-appearance was broken on some platforms, it runs counter to the advice in https://wiki.mozilla.org/DevTools/CSSTips, which will need fixing. We still need to have this discussion as there is some confusion as to what to do with -moz-appearance.
Comment 6 Dão Gottwald [:dao] 2012-01-14 04:54:34 PST
It's not broken. It behaves differently. In this case it enforces a minimum height or minimum padding or some such thing that causes the containing toolbar to grow vertically, at least on Windows.
Comment 7 Paul Rouget [:paul] 2012-01-14 09:45:26 PST
(In reply to Dão Gottwald [:dao] from comment #4)
> (In reply to Joe Walker from comment #3)
> > We should have a team discussion about -moz-appearance and theme/content
> > split.
> 
> -moz-appearance values aren't implemented and don't behave consistently
> across platforms, so this needs to be in theme files. In fact, I'm not sure
> this bug affects Linux. Does it?

It does.
Comment 8 Paul Rouget [:paul] 2012-01-28 11:25:20 PST
review ping?
Comment 9 Paul Rouget [:paul] 2012-01-30 03:43:57 PST
https://hg.mozilla.org/integration/fx-team/rev/3a02c994022d
Comment 10 Tim Taubert [:ttaubert] (on PTO, back Aug 29th) 2012-01-31 01:23:04 PST
https://hg.mozilla.org/mozilla-central/rev/3a02c994022d

Note You need to log in before you can comment on or make changes to this bug.