Closed
Bug 712223
Opened 12 years ago
Closed 12 years ago
[highlighter] Breadcrumbs bar doesn't always have the same size on Windows and Linux
Categories
(DevTools :: Inspector, defect)
DevTools
Inspector
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: vporof, Assigned: paul)
References
Details
Attachments
(2 files)
When the depth of the selected element in the tree is too big, the breadcrumbs bar increases in size. Perhaps this shouldn't happen? (It's ugly)
Assignee | ||
Comment 1•12 years ago
|
||
This happens when the arrows appear. I think I know how to fix that.
Assignee | ||
Updated•12 years ago
|
OS: Windows 7 → All
Summary: [highlighter] Breadcrumbs bar doesn't always have the same size on Windows → [highlighter] Breadcrumbs bar doesn't always have the same size on Windows and Linux
Assignee | ||
Comment 2•12 years ago
|
||
Assignee | ||
Updated•12 years ago
|
Attachment #588596 -
Flags: review?(jwalker)
Comment 3•12 years ago
|
||
Comment on attachment 588596 [details] [diff] [review] patch - v1 Review of attachment 588596 [details] [diff] [review]: ----------------------------------------------------------------- We should have a team discussion about -moz-appearance and theme/content split. However I'm happy to approve this anyway, lets discuss it when I get back. I'm a little unclear if I'm allowed to r+ this, or I should f+ it. I'll be away soon, so I'll let you work out which type of + it should be.
Attachment #588596 -
Flags: review?(jwalker) → review+
Comment 4•12 years ago
|
||
(In reply to Joe Walker from comment #3) > We should have a team discussion about -moz-appearance and theme/content > split. -moz-appearance values aren't implemented and don't behave consistently across platforms, so this needs to be in theme files. In fact, I'm not sure this bug affects Linux. Does it?
Comment 5•12 years ago
|
||
(In reply to Dão Gottwald [:dao] from comment #4) > (In reply to Joe Walker from comment #3) > > We should have a team discussion about -moz-appearance and theme/content > > split. > > -moz-appearance values aren't implemented and don't behave consistently > across platforms, so this needs to be in theme files. In fact, I'm not sure > this bug affects Linux. Does it? I wasn't aware that -moz-appearance was broken on some platforms, it runs counter to the advice in https://wiki.mozilla.org/DevTools/CSSTips, which will need fixing. We still need to have this discussion as there is some confusion as to what to do with -moz-appearance.
Comment 6•12 years ago
|
||
It's not broken. It behaves differently. In this case it enforces a minimum height or minimum padding or some such thing that causes the containing toolbar to grow vertically, at least on Windows.
Assignee | ||
Comment 7•12 years ago
|
||
(In reply to Dão Gottwald [:dao] from comment #4) > (In reply to Joe Walker from comment #3) > > We should have a team discussion about -moz-appearance and theme/content > > split. > > -moz-appearance values aren't implemented and don't behave consistently > across platforms, so this needs to be in theme files. In fact, I'm not sure > this bug affects Linux. Does it? It does.
Assignee | ||
Updated•12 years ago
|
Attachment #588596 -
Flags: review?(dao)
Assignee | ||
Comment 8•12 years ago
|
||
review ping?
Updated•12 years ago
|
Attachment #588596 -
Flags: review?(dao) → review+
Updated•12 years ago
|
Assignee: nobody → paul
Assignee | ||
Updated•12 years ago
|
Whiteboard: [land-in-fx-team]
Assignee | ||
Comment 9•12 years ago
|
||
https://hg.mozilla.org/integration/fx-team/rev/3a02c994022d
Whiteboard: [land-in-fx-team] → [fixed-in-fx-team]
Comment 10•12 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/3a02c994022d
Status: NEW → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Whiteboard: [fixed-in-fx-team]
Updated•6 years ago
|
Product: Firefox → DevTools
You need to log in
before you can comment on or make changes to this bug.
Description
•